From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id 4E3083858C2C for ; Tue, 7 Dec 2021 16:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E3083858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2c.google.com with SMTP id a24so13519315qvb.5 for ; Tue, 07 Dec 2021 08:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=m/s4z+RcXEwte61w66fumsEhYRb9JBqYZjAxadG3sBc=; b=iMePohLTCy2SpodqG1rzuXWSJMAlK8Gss/tfPu70yECLW82xqufpL+7GRq0M2Po/3/ dKU75hj0bN6vL5YICD/m+HjRM+wylzQu42XWdeLm5nPkPSEe13NXHzipkVJx4kGbwJf5 8HBgiab7+olIqSjkqctIqUQBMk9h0u29ngbWc1yYF7ZAAVhQr1OxqHW5wShegUY725+O 16Rs735XDPtCWddCwf9VzqJzIG3OktmHILa/pno38Zk6IF5nTTVO40hQp4DNpCVQvk8d BmfjAhcRcItyrjTTEoThkr7jVZMVpMDRiKuDDTDNlvCOuQtBABQPET1oS06hNacjwasm F6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=m/s4z+RcXEwte61w66fumsEhYRb9JBqYZjAxadG3sBc=; b=VsORQhFEiF+j39pYadqwtCseKeH/+/eOY9YPDIOiXrv8BWT0QF88/Uzen+ThlilPr3 bqGkSYPAxzyWQ3saArAgFTmYlxRS+7WPlqCW+UaQfOH42FbHVOHGO0ZgBf+Yn6cDYhDr kXnlH5JR+U78urYfSEkB7xWEkKssCWYVx1T9hhF5vjktFTxy3VwfWWVtr0U1IGnBYtDM DFQ70/XQLBBF1cu8FnCLBKhpUmGWNVLXqaF64xj41+B/OclnrEFQKAI/cOrue4NMyw9f bfAzfNSZAIDNFm2fXL8WYsTPDW4Qtnebs9lUrxDsX3QGmOfo6IQnIJ3wCcu8kZkcKZx6 x8KA== X-Gm-Message-State: AOAM531tA/S0pKrl8+0x4bWRt7XfdmPyseD7LXTx5TYNfXtmi6Y81fM4 diBA48SCJIXSfgTTFcvkHwaQLozD4Few7SZBmuV3IkA8GA== X-Google-Smtp-Source: ABdhPJwHgmG67hFZa6KH/tMZFcFrRZI3dIqWi2rtTfGwhIRcM41c2j3LH4/wbYBk6HCtN1jGC0rM2kaHQoJ6goR4M/8= X-Received: by 2002:a0c:ed52:: with SMTP id v18mr45286447qvq.61.1638893447720; Tue, 07 Dec 2021 08:10:47 -0800 (PST) MIME-Version: 1.0 References: <20211207125624.5465-1-jon.turney@dronecode.org.uk> In-Reply-To: From: C Howland Date: Tue, 7 Dec 2021 11:10:36 -0500 Message-ID: Subject: Re: Fw: [PATCH] Enable automake silent rules To: newlib@sourceware.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 16:10:50 -0000 > > > ------------------------------ > *From:* Newlib on > behalf of Corinna Vinschen > *Sent:* Tuesday, December 7, 2021 9:16 AM > *To:* newlib@sourceware.org > *Subject:* Re: [PATCH] Enable automake silent rules > > > On Dec 7 12:56, Jon Turney wrote: > > Use AM_SILENT_RULES, to enable automake silent rules (by default), if we > > are using a version of automake which supports it (>=1.11). > > > > Silent rules can be disabled by configuring with > '--disable-silent-rules', > > or invoking 'make V=1'. > > > > For ease of reviewing, this patch doesn't contain configure and > > Makefile.in regeneration. > > > > Future work: There are a few compilations which are not silenced by > > this, as they use custom rules. > > --- > > newlib/acinclude.m4 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4 > > index 05e545c9f..42af6b548 100644 > > --- a/newlib/acinclude.m4 > > +++ b/newlib/acinclude.m4 > > @@ -121,6 +121,7 @@ AC_SUBST(newlib_basedir) > > AC_CANONICAL_HOST > > > > AM_INIT_AUTOMAKE([cygnus no-define 1.9.5]) > > +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES(yes)]) > > > > # FIXME: We temporarily define our own version of AC_PROG_CC. This is > > # copied from autoconf 2.12, but does not call AC_PROG_CC_WORKS. We > > -- > > 2.34.1 > > Nice, please push. > > > Thanks, > Corinna > > Umm, not so fast? Some questions. Should this really be made the new default? OK, Corinna is on board with that. I personally don't want it as a default because I want to see command line arguments. Easy for me to get different, but only knowing how. That leads to the next question. Given that silent were made default, it is a big change in terms of what people see. How would you know to change it? (New feature, most people are far from experts in automake.) Therefore, the directions most definitely would need something added that explains it. (Without knowing about it, I can see it taking someone a long time to chase down why they suddenly lost the make output.) Something along the lines of Jon's explanation in the patch email needs to end up in README and probably also printed by a configure help. Craig