From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cc1964t@gmail.com>
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com
 [IPv6:2a00:1450:4864:20::62d])
 by sourceware.org (Postfix) with ESMTPS id 038743844019
 for <newlib@sourceware.org>; Thu, 17 Jun 2021 23:33:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 038743844019
Authentication-Results: sourceware.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x62d.google.com with SMTP id he7so12666297ejc.13
 for <newlib@sourceware.org>; Thu, 17 Jun 2021 16:33:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=k3rxOkeokGIgVVB6jUO9U9lMuRjzxsxZybFyemXRUeY=;
 b=KgrX/P8g+F/bazXeDYxUWgKP5dCHgwYlP2Fo9OgaNF+WkjD2LCZToDyKu20wlViJg3
 jhEow3vAzzny3JeR5/4inYmS6u1a8z1rZ0QsHOJi4tWxmjWOMjWZFsPtKVP4/nYmSkcf
 bkG93+oBG1RdU2+QI/wrHBu1RD3+P3TENwrqn/oV7JM6qexehvRJ5dR0sYnq8qKpZ8lZ
 RaTlUEF2u3DO2+Rh4scZ/x0krcNMAeSmM0XUADQ2Z8O6rARtP75ikN70Wlabs2aG+iLD
 Vj9O4Gre8BbbAvyh44dIOH7nceFM6I96+kBputYsaWyMae+ATXkCyKRizaZO/smWEr0H
 PyjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=k3rxOkeokGIgVVB6jUO9U9lMuRjzxsxZybFyemXRUeY=;
 b=RfxyfrbkeGS2p3w/cT0sI82M5ldMeAWNifZJ7HExedmEa0Gq86EPYxa7x6uQAnxvz2
 u/wBaa4rUg4CvCQ7lquh4+JpATFQzeRqR6fb16oUCIRc4cgPb8Ig6izGIspGW9CGFxqh
 AFrmjRzgkPPHcir5mddUfIqwzAeRQ+6/KOlW0ponOgmYisPohyDZXxqJ6RWG/pDZfQqG
 XsNCkyKlGxJS7PqhvWf/ULs9k2r4RoqLh0ZZdb7Ib6YoSrBgsNv3gGcjDkaAZ6sYP1Po
 8Bv8YssYCRXM4b+xvyMb0APHHLMAOv6zM1UPWxs8a9BDoDHtPiQD7qQgePIM769lqOev
 B4dA==
X-Gm-Message-State: AOAM531bdJY+dlzwqciINsrVaqJocdsOZ3hwSOmAGjWAHDBLZq9Bofy0
 KoFJbG6cvsnhI+I0gTJgLElqGuqBPTwIVE2AyPFmy7tduw==
X-Google-Smtp-Source: ABdhPJyrxB7Gf/PP5xsk/yVmuRwY7wdniqe6PSGXY0QUUfhrFcAFOAP5RbmYKopXIdfTNMiyvd2iDViSBBCPhwMMmDU=
X-Received: by 2002:a17:906:c791:: with SMTP id
 cw17mr7659785ejb.329.1623972785027; 
 Thu, 17 Jun 2021 16:33:05 -0700 (PDT)
MIME-Version: 1.0
From: C Howland <cc1964t@gmail.com>
Date: Thu, 17 Jun 2021 19:32:53 -0400
Message-ID: <CANk6obT=7OpdavfHvh-09yUb2qOkTrUWT-ssEJURNdRnh8MSag@mail.gmail.com>
Subject: Re: [PATCH 2/2] newlib/doc/makedoc.c: if realloc() fails, exit with
 an error message.
To: newlib@sourceware.org
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: newlib@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Newlib mailing list <newlib.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>,
 <mailto:newlib-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>,
 <mailto:newlib-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jun 2021 23:33:07 -0000

> ------------------------------
> *From:* Newlib <newlib-bounces+craig.howland=caci.com@sourceware.org> on
> behalf of Joel Sherrill <joel@rtems.org>
> *Sent:* Thursday, June 17, 2021 5:53 PM
> *To:* newlib@sourceware.org <newlib@sourceware.org>
> *Subject:* [PATCH 2/2] newlib/doc/makedoc.c: if realloc() fails, exit
> with an error message.
>
>
> ---
>  newlib/doc/makedoc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/newlib/doc/makedoc.c b/newlib/doc/makedoc.c
> index 966349c51..81aa6f941 100644
> --- a/newlib/doc/makedoc.c
> +++ b/newlib/doc/makedoc.c
> @@ -135,6 +135,11 @@ catchar (string_type *buffer, char ch)
>    {
>      buffer->size *=2;
>      buffer->ptr = realloc(buffer->ptr, buffer->size);
> +    if (!buffer->ptr)
> +    {
> +      fprintf(stderr,"Can't allocate memory\n");
> +      exit(1);
> +    }
>    }
>
>    buffer->ptr[buffer->write_idx ++ ] = ch;
> --
> 2.24.4
>
> Both patches look sane.