From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5E84F38582AE for ; Tue, 1 Nov 2022 20:23:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E84F38582AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667334181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F3WmFng4IknVfrCI7+ux53i4225EJun07NAxR9qYyk0=; b=OKVYQQBSJZE19urWSfUr9/T3ExaScKGgYMvgOZJgm/COzFYmQUH9Br02ojnz/+rtsXIPbu s8O7VlGE6KTS+TP5THqoOJEPDOyMDlnGOLpzky5m5WqDJXx/mjRVcv9lvy90CSN8jOsdNO 8CEDc7rbOIMpM7+eaZjo/w0PD/5moJ4= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-228-1IA48EC-Ph-Yk2qv9VLS1w-1; Tue, 01 Nov 2022 16:23:00 -0400 X-MC-Unique: 1IA48EC-Ph-Yk2qv9VLS1w-1 Received: by mail-yb1-f199.google.com with SMTP id q62-20020a25d941000000b006cac1a4000cso14012122ybg.14 for ; Tue, 01 Nov 2022 13:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F3WmFng4IknVfrCI7+ux53i4225EJun07NAxR9qYyk0=; b=tlCC3GVDLa+ZfLdeGl9aN6j0ZgwuL5aTsh+Gv9/FCHWfyQlIrskNxydk1jkKVWIIUz Qq7lRm58v2a4mI+IgFJBYgpjwq8unSJNTOsWzIP005NWbIL6v/CTFlIu84XXEkanjuoC g7kAB98Rygl+C5wDdAqgfSGA3kJMU4FAIAxCzk1TEmDlweh3tmKxOalWOLqQVU9PMNs9 hpgbs35bRX9wkAn2DWMsbcea+aAzrz1qiBZFQ7Y6tLbyrJ1g5YQLVN8X3jZox0uLKWzY SrS9f/81MFUQ3JZlChWjCWV3clgeUgSbC6xp++1VpvDoavCPZIDexIAbaF94BwQYp6ib rmqg== X-Gm-Message-State: ACrzQf2DA2Dbun1o47hjC5LJMVcrscHyn/RXtXVqp73NK18xZSLrKl66 Uq6YJ9XABoddcJVSqggt3JACmdVxp5AT0eVkVMHN2LkQx9/CAQPV2T2l3FPUIY8rn9ejjfKLB+h yGuJcdds2E/B/CCrqY6IZiRIBeacp67c= X-Received: by 2002:a25:d802:0:b0:6ca:92b7:f082 with SMTP id p2-20020a25d802000000b006ca92b7f082mr19824592ybg.128.1667334179274; Tue, 01 Nov 2022 13:22:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42shKIB7H6BxA6Uctr248IAVWh6JQ7EiIpQb172vfGTFUgHgUkVABF0WEYjerAYJDi2XmdtOHCGpyHF6UtPnE= X-Received: by 2002:a25:d802:0:b0:6ca:92b7:f082 with SMTP id p2-20020a25d802000000b006ca92b7f082mr19824215ybg.128.1667334174185; Tue, 01 Nov 2022 13:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20221030072513.9873-1-vapier@gentoo.org> In-Reply-To: <20221030072513.9873-1-vapier@gentoo.org> From: Jeff Johnston Date: Tue, 1 Nov 2022 16:22:42 -0400 Message-ID: Subject: Re: [PATCH] newlib: build+install info pages by default To: Mike Frysinger Cc: newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002caf4105ec6e7d1e" X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002caf4105ec6e7d1e Content-Type: text/plain; charset="UTF-8" LGTM. -- Jeff J. On Sun, Oct 30, 2022 at 4:40 AM Mike Frysinger wrote: > The no-installinfo option was added as part of the migration off of > the cygnus option in order to maintain compatibility. However, GNU > standards say we should be building+shipping info pages by default, > so let's enable these by default. > > Our release tarballs should be including these, so end devs shouldn't > have to build them themselves in practice. People building from git > will have to, but that also aligns with other GNU projects, including > the various toolchain ones. > --- > newlib/Makefile.in | 13 ++++++------- > newlib/acinclude.m4 | 2 +- > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/newlib/Makefile.in b/newlib/Makefile.in > index cb7b693279fa..f9b0adae7cd7 100644 > --- a/newlib/Makefile.in > +++ b/newlib/Makefile.in > @@ -973,8 +973,8 @@ am__uninstall_files_from_dir = { \ > || { echo " ( cd '$$dir' && rm -f" $$files ")"; \ > $(am__cd) "$$dir" && rm -f $$files; }; \ > } > -am__installdirs = "$(DESTDIR)$(toollibdir)" "$(DESTDIR)$(cctdir)" \ > - "$(DESTDIR)$(toollibdir)" > +am__installdirs = "$(DESTDIR)$(toollibdir)" "$(DESTDIR)$(infodir)" \ > + "$(DESTDIR)$(cctdir)" "$(DESTDIR)$(toollibdir)" > LIBRARIES = $(toollib_LIBRARIES) > ARFLAGS = cru > AM_V_AR = $(am__v_AR_@AM_V@) > @@ -3676,7 +3676,6 @@ pdfdir = @pdfdir@ > prefix = @prefix@ > program_transform_name = @program_transform_name@ > psdir = @psdir@ > -runstatedir = @runstatedir@ > sbindir = @sbindir@ > shared_machine_dir = @shared_machine_dir@ > sharedstatedir = @sharedstatedir@ > @@ -46273,10 +46272,10 @@ check-am: all-am > $(MAKE) $(AM_MAKEFLAGS) $(check_PROGRAMS) > $(MAKE) $(AM_MAKEFLAGS) check-DEJAGNU > check: check-am > -all-am: Makefile $(LIBRARIES) $(DATA) newlib.h _newlib_version.h \ > - all-local > +all-am: Makefile $(INFO_DEPS) $(LIBRARIES) $(DATA) newlib.h \ > + _newlib_version.h all-local > installdirs: > - for dir in "$(DESTDIR)$(toollibdir)" "$(DESTDIR)$(cctdir)" > "$(DESTDIR)$(toollibdir)"; do \ > + for dir in "$(DESTDIR)$(toollibdir)" "$(DESTDIR)$(infodir)" > "$(DESTDIR)$(cctdir)" "$(DESTDIR)$(toollibdir)"; do \ > test -z "$$dir" || $(MKDIR_P) "$$dir"; \ > done > install: install-am > @@ -46572,7 +46571,7 @@ info: info-am > > info-am: $(INFO_DEPS) > > -install-data-am: install-cctDATA install-data-local \ > +install-data-am: install-cctDATA install-data-local install-info-am \ > install-toollibDATA install-toollibLIBRARIES > > install-dvi: install-dvi-am > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4 > index 9e4834987716..ad9384049b97 100644 > --- a/newlib/acinclude.m4 > +++ b/newlib/acinclude.m4 > @@ -114,7 +114,7 @@ AC_SUBST(abs_newlib_basedir) > > AC_CANONICAL_HOST > > -AM_INIT_AUTOMAKE([foreign no-installinfo no-dist no-define subdir-objects > 1.15.1]) > +AM_INIT_AUTOMAKE([foreign no-dist no-define subdir-objects 1.15.1]) > AM_MAINTAINER_MODE > AM_SILENT_RULES(yes) > > -- > 2.37.3 > > --0000000000002caf4105ec6e7d1e--