From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E87493857703 for ; Thu, 12 Oct 2023 14:50:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E87493857703 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697122234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1rn7odRr/zz+2xXDC0nkGPECF09t/b5NOZa4rsR9MkQ=; b=jNwDkpVw35K2jnExMVlgZ9UsBJQzPP12kYHHbyIHcT1Dsb00UoChGiDYwx7mrm/HwG0kMN Sdw8cNhuWgseixcWA2e63VMYkpe14o+/+Zr4mnsMOJY3v8yol26WrFg8aKtiLCcRCncuAA Nlv6OT8Qq8DBTvmoDBbZ6XYH2bXBB+M= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-2pOgiw_dMb2xct6pJfKf_w-1; Thu, 12 Oct 2023 10:50:18 -0400 X-MC-Unique: 2pOgiw_dMb2xct6pJfKf_w-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50451c54281so246794e87.0 for ; Thu, 12 Oct 2023 07:50:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697122215; x=1697727015; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1rn7odRr/zz+2xXDC0nkGPECF09t/b5NOZa4rsR9MkQ=; b=sDo466z5wHxtnS0InOFEtHkRGoV+OOEMGMn8gp2EuOYLABM8ENO0LjHuivTf892tc0 vxvnzT8+lZVkznMq7v4vHSX6wCSzx/lGSxKBZj7s7jaXljcyk43kC/W/VjQan4CGghAh Mxah+OxDPuyTaYuqYHVRJCkONL1wrj/ewtLytHsamNMzXOy/a5yiiPGfKX/UzuA3R/ih Ukp0aYid2ScMoForin4T3Gp0X0OjLIYuLWYgMwVCAXZ2DEiRZTD7T1e3EE/SKGftr9ya LWn47Kj8f9A6ZChmIM6n/KlxjDTIQTOVe4j3lP8ARTuGBDYGfEtfyFQK/+DnsGlWiL0h z+Rg== X-Gm-Message-State: AOJu0YxHa/t1xf34Klm3x4X6YSvIneHMXlpkRSP0lK+YXhz+dL040yG/ cBuF6KgrvrMlRngaKnj4awqnfUU3L43aBrwIVbnFqA4qX/HsMb6m/IqgKMK4m3MWVsv2trIFGdW 8GitKYKjkYoZvEyat3V40vvQHPFG1M41Vx6Aabns= X-Received: by 2002:ac2:5981:0:b0:505:6edc:b548 with SMTP id w1-20020ac25981000000b005056edcb548mr18966143lfn.2.1697122215546; Thu, 12 Oct 2023 07:50:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeSxGkLwc/u4fKqMfDvRggaMJawg/qhhV1RxyygxIXz6I0/d2OXfr49CP+iEe8dv9FfwMQKaA5coe+yx3zde4= X-Received: by 2002:ac2:5981:0:b0:505:6edc:b548 with SMTP id w1-20020ac25981000000b005056edcb548mr18966131lfn.2.1697122215198; Thu, 12 Oct 2023 07:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20231006053106.8484-1-sebastian.huber@embedded-brains.de> <2426c7bf-db5e-4bb4-a6f5-12266f729dfe@embedded-brains.de> In-Reply-To: <2426c7bf-db5e-4bb4-a6f5-12266f729dfe@embedded-brains.de> From: Jeff Johnston Date: Thu, 12 Oct 2023 10:50:03 -0400 Message-ID: Subject: Re: [PATCH] sparc: Improve setjmp() To: Sebastian Huber Cc: newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000c72d000607860e60" X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000c72d000607860e60 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sebastian, I am not familiar with sparc to comment, but Corinna has performed maintenance on the setjmp.S file if you want to wait for her to look at the change. Otherwise, if you have a test case that verifies the change, feel free to merge and you can confirm with Corinna when she is back. -- Jeff J. On Thu, Oct 12, 2023 at 5:39=E2=80=AFAM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > On 06.10.23 07:31, Sebastian Huber wrote: > > Flush the windows in setjmp(). This helps if the stack is changed after > > the setjmp() and we want to jump back to the original stack using > > longjmp(). > > --- > > newlib/libc/machine/sparc/setjmp.S | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/newlib/libc/machine/sparc/setjmp.S > b/newlib/libc/machine/sparc/setjmp.S > > index 613df2ba2..d7185be4c 100644 > > --- a/newlib/libc/machine/sparc/setjmp.S > > +++ b/newlib/libc/machine/sparc/setjmp.S > > @@ -110,6 +110,8 @@ > > > > ENTRY(setjmp) > > ENTRY(_setjmp) > > + ta 0x03 /* Flush registers, just in case > another stack > > + is used after the setjmp(). */ > > st %sp, [%o0] /* caller's stack pointer */ > > st %i7, [%o0+4] /* caller's return pc */ > > st %fp, [%o0+8] /* store caller's frame pointer */ > > I am not sure if there is anyone left being able to review this change. > > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.huber@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht M=C3=BCnchen > Registernummer: HRB 157899 > Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler > Unsere Datenschutzerkl=C3=A4rung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ > > --000000000000c72d000607860e60--