From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B220D3857C5B for ; Thu, 1 Oct 2020 23:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B220D3857C5B Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-cWGI4XwkONeKKp046RnRpQ-1; Thu, 01 Oct 2020 19:24:35 -0400 X-MC-Unique: cWGI4XwkONeKKp046RnRpQ-1 Received: by mail-pg1-f197.google.com with SMTP id n24so87416pgl.3 for ; Thu, 01 Oct 2020 16:24:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=abLFsvDDmI962TqQR0olXGYQBt8VqgQOnndAVqYIHfA=; b=ceAVhesRh5F4t8u2Ljl+TkH3HaTxneKjm9mD903PcAYhIvb8XNde/yZJnrHS5XOwnl nQxywF3w7+hxtvNATQUPE8w5VGA4agjMUimWJ4VNMm8+SlwkTscOsmxYXPIlWj1qJpkQ d01nr5r2TqwljR8EhiMXMo0pJjVvhKVBcOEv7EfXyRaK6Op244oAcPHYVEXKyce6oD3o pdJ5l2BleJ6Me0vLvGpVthYvg1CipJLARokc1CY2XPuJZRm4rnjMLbtdT/2V7rjQKHXK UHkxlXvhdzeeU0RqanxBv2wQg/iWXhOfxV6ONUyWd1QY6zXwuAC1aev4fPrSEnTcy+gC Lmlg== X-Gm-Message-State: AOAM530gF2ebWeYUNSK/LYqrBZSmyLZljuSVe3iIUHG4YHto36HngYh4 Sv7vE7kJSvsWB5CLeYCXM59EOO+uSu5fWVC84QuIY5bjYlgQSyxxUOpBb1mAEiSY5kM0I52wfXF z3yFUOTclvDx5Ab4LItnZVv43ZILiOCM= X-Received: by 2002:aa7:9157:0:b029:142:2501:3984 with SMTP id 23-20020aa791570000b029014225013984mr5115901pfi.73.1601594672875; Thu, 01 Oct 2020 16:24:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9v2KjoshAj1Wb57Jur9nzZdKDLj/YqOHHMhz/SJ94CCN8dAC4y8981rTzeQxLjm1FWE5Dmu9bWzN6GtQBx0c= X-Received: by 2002:aa7:9157:0:b029:142:2501:3984 with SMTP id 23-20020aa791570000b029014225013984mr5115887pfi.73.1601594672659; Thu, 01 Oct 2020 16:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20201001141753.6657-1-torbjorn.svensson@st.com> <20201001141753.6657-3-torbjorn.svensson@st.com> In-Reply-To: <20201001141753.6657-3-torbjorn.svensson@st.com> From: Jeff Johnston Date: Thu, 1 Oct 2020 19:24:21 -0400 Message-ID: Subject: Re: [PATCH 2/3] libc/include/wchar.h: Remove parameter name To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 23:24:39 -0000 Looks good. Could you please resend the patch as an attachment? Thanks, -- Jeff J. On Thu, Oct 1, 2020 at 10:19 AM Torbj=C3=B6rn SVENSSON via Newlib < newlib@sourceware.org> wrote: > As discussed in GCC bug 97088 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97088), parameters in > prototypes of library functions should use reserved names, or no name > at all. > > This patch removes the 'ptr' parameter name from > wint_t _getwchar_r (struct _reent *); > wint_t _getwchar_unlocked_r (struct _reent *); > > to avoid possible clashes with user code in case someone uses > before including Newlib's wchar.h (or uses some other conflicting > definition) > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > newlib/libc/include/wchar.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/include/wchar.h b/newlib/libc/include/wchar.h > index c04a6510e..0d3e636f9 100644 > --- a/newlib/libc/include/wchar.h > +++ b/newlib/libc/include/wchar.h > @@ -248,8 +248,8 @@ int _fputws_unlocked_r (struct _reent *, const wchar_= t > *, __FILE *); > int _fwide_r (struct _reent *, __FILE *, int); > wint_t _getwc_r (struct _reent *, __FILE *); > wint_t _getwc_unlocked_r (struct _reent *, __FILE *); > -wint_t _getwchar_r (struct _reent *ptr); > -wint_t _getwchar_unlocked_r (struct _reent *ptr); > +wint_t _getwchar_r (struct _reent *); > +wint_t _getwchar_unlocked_r (struct _reent *); > wint_t _putwc_r (struct _reent *, wchar_t, __FILE *); > wint_t _putwc_unlocked_r (struct _reent *, wchar_t, __FILE *); > wint_t _putwchar_r (struct _reent *, wchar_t); > -- > 2.18.0 > >