From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 842043857802 for ; Thu, 15 Oct 2020 17:09:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 842043857802 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-EGoL5pf6NdievBrQohncpA-1; Thu, 15 Oct 2020 13:09:15 -0400 X-MC-Unique: EGoL5pf6NdievBrQohncpA-1 Received: by mail-pg1-f199.google.com with SMTP id t11so2157100pgu.22 for ; Thu, 15 Oct 2020 10:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=VoGPS438lJWODzfNKFwS9trD2lfENs/ir+LaRYfGDnE=; b=nU2SJZD0QKWhZw8Yjasd1T0X6tlTCOn6Jb6Y8/f8SH2IWQ7e21bOevRxZtPNxog3tO fAJyFdKmMI87rVJio8R9hAc0QgbtjsOS81ln8Ur3vGQEkv1mov5uv4h2AMTn3qZAb1Lp XoWdpO4toRYpurXrx94B7iklffU6/hv3j32wIpjkVci8osvXUtnCs7X8FWGkVhK7iosW wOViP7yYef2p5VhYIBWxbrwbqM4psoiRxoQ5yufaB76Lv2HO3niSonLffXqATgLGHCGP 244IPqH8nMxdFMYd3YFN6O4BfF1myFlt7Ot5pSBkWHQoZEx9foQp4EbhRlI2H6xq4SGL bl1Q== X-Gm-Message-State: AOAM533fNiofBjstIwDXwl+B0GTQbeEhb9dL+lOtdaIKWCKl0SOJQT0o IGPSVVADmC2omp2iNa5QttCSOgZWoq/ZDahWXmafyoz2wEB7undM9sHsO6i92fiR+Ei+dpMIAj6 Tx9gjkA+5do4LJJcbAPqGOeVXlVIhwII= X-Received: by 2002:a17:90a:e64f:: with SMTP id ep15mr5113592pjb.95.1602781754417; Thu, 15 Oct 2020 10:09:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLZeeEF3ZRj/uq7v4cjlpmwimR0bVyreU8CBts981BsxwdzAak8B9uabmJ4GYgKNnuyE3OIKl0AKU5ylrU2Oo= X-Received: by 2002:a17:90a:e64f:: with SMTP id ep15mr5113575pjb.95.1602781754169; Thu, 15 Oct 2020 10:09:14 -0700 (PDT) MIME-Version: 1.0 References: <20201005125011.28344-1-torbjorn.svensson@st.com> <20201015102139.GI26704@calimero.vinschen.de> In-Reply-To: From: Jeff Johnston Date: Thu, 15 Oct 2020 13:09:03 -0400 Message-ID: Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h To: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 17:09:19 -0000 I also like this solution, but again as I mentioned earlier, it technically requires a major release bump due to the removal of API from time.h and would be best to wait until we have something else warranting a major release bump. That said, what do you think Corinna? -- Jeff J. On Thu, Oct 15, 2020 at 12:47 PM Torbjorn SVENSSON via Newlib < newlib@sourceware.org> wrote: > Hello Corinna, > > Thanks for the feedback and I hope that you had a nice vacation! > > I haven't run tests with your patch applied, but just reading it should b= e > fine. > I see no reason why "sys/_tz_structs.h" would be included from > "bits/stdc++.h", and it is this particular include chain that is causing > the problems in the libstdc ++ test suite, so if it works for Cygwin, I'd > say go for it! > > Kind regards, > Torbj=C3=B6rn > > -----Original Message----- > From: Corinna Vinschen > Sent: den 15 oktober 2020 12:22 > To: Torbjorn SVENSSON > Cc: newlib@sourceware.org > Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to > local.h > > On Oct 15 06:52, Torbjorn SVENSSON via Newlib wrote: > > Ping! > > Due to vacation I only just checked now. The patch breaks the Cygwin > build. Especially __tzinfo_type has to be exposed from a public header > in newlib. > > So what about the attached patch instead? > > > Corinna >