From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6F6703858C53 for ; Wed, 4 May 2022 17:13:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F6703858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651684400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1qweb14d3KV9r/KXjThbxpLlRA4QNCEXI5A3X67ZQAI=; b=LDKRqlDOuqM4y6RegN78m0S/hKDlZXEV+ci6K8wFcF77wV2eKO3mDBz9S8zVhfx2uJVSls SIT3KMadQKRSUtJO4BVuhdLOpXMuodeKsPyaRwv/MXDAFU6cCrIsHfBi0M5q/2iUL2f2ER PAZnWAyj+2j1RyjHN6XIAD3rpi+VuNI= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-2IHhRU2uM8-IpojE1v2JAw-1; Wed, 04 May 2022 13:13:18 -0400 X-MC-Unique: 2IHhRU2uM8-IpojE1v2JAw-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-2dc7bdd666fso17099697b3.7 for ; Wed, 04 May 2022 10:13:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1qweb14d3KV9r/KXjThbxpLlRA4QNCEXI5A3X67ZQAI=; b=gUE2zlz8WNE0KalmFQlw/KIb1jHYVrgFU8pMqjtidtieanis6rqkyoJawUBQI2DXgR +kcVhkv4Tt7rQCacqQWHNukOukDTf/2W2bhNPZlHh3ZV/oViONZLq1CwKys3c/jClUqi nLh0jpV0UdOHyLCkY3MeeO18p3TnMFS/BvpKYqah/OW/8aQGa8i5MZWo8NkxZVGvhsm7 3aDH1IR6un4Rlxd/BzfBTBMy2GgWe8NuC/EhDsBoUPItyb/ztJnlTuN7I/pl6VAD4+6s BFlRkuxSHU2Vh6WYeG78ac1W5fkT3cOvbsO5D04TcGZF/4qMRCESIydW5Zv/Ba03W51z Tr8g== X-Gm-Message-State: AOAM532rmH9asX0StLts+SximId1m2THVovskGVfD+Y3Fj67zkwdEQPM ggT+0JeICir/IAxyoohL2XfGUyx731MeCv8A5LD/n5OmG44qbD2lxnvtdH+eWiMD2vHYWuYZNCW Semv1af+ZhV2jh3vMH3VifPpBGzdRbx0= X-Received: by 2002:a81:1292:0:b0:2f8:c149:5d15 with SMTP id 140-20020a811292000000b002f8c1495d15mr19316608yws.400.1651684398053; Wed, 04 May 2022 10:13:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzVM8JXhufBD1rpgGD8nt6HzxjmYSnqfBqiqlotY8iM9emGX91TAW8dkOrEcwuli4oq/YkunNEKK8moTphqEE= X-Received: by 2002:a81:1292:0:b0:2f8:c149:5d15 with SMTP id 140-20020a811292000000b002f8c1495d15mr19316594yws.400.1651684397870; Wed, 04 May 2022 10:13:17 -0700 (PDT) MIME-Version: 1.0 References: <20220504170304.1633855-1-dimitar@dinux.eu> In-Reply-To: <20220504170304.1633855-1-dimitar@dinux.eu> From: Jeff Johnston Date: Wed, 4 May 2022 13:13:07 -0400 Message-ID: Subject: Re: [PATCH] Fix nbdm.c build break To: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 17:13:21 -0000 Patch merged. Thanks. -- Jeff J. On Wed, May 4, 2022 at 1:03 PM Dimitar Dimitrov wrote: > The ndbm.c build broke with: > Commit 357d7fcc6 > In provide only necessary types > > The above commit exposed a latent missing-header bug: > newlib/newlib/libc/include/ndbm.h:83:38: error: unknown type name > =E2=80=98mode_t=E2=80=99 > > Signed-off-by: Dimitar Dimitrov > --- > newlib/libc/include/ndbm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/newlib/libc/include/ndbm.h b/newlib/libc/include/ndbm.h > index c5084b9c2..1e5072cf1 100644 > --- a/newlib/libc/include/ndbm.h > +++ b/newlib/libc/include/ndbm.h > @@ -40,6 +40,7 @@ > #ifndef _NDBM_H_ > #define _NDBM_H_ > > +#include /* For mode_t. */ > /* #include */ > > /* > -- > 2.35.1 > >