* [PATCH] Fix nbdm.c build break
@ 2022-05-04 17:03 Dimitar Dimitrov
2022-05-04 17:13 ` Jeff Johnston
0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2022-05-04 17:03 UTC (permalink / raw)
To: newlib
The ndbm.c build broke with:
Commit 357d7fcc6
In <stdio.h> provide only necessary types
The above commit exposed a latent missing-header bug:
newlib/newlib/libc/include/ndbm.h:83:38: error: unknown type name ‘mode_t’
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
newlib/libc/include/ndbm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/newlib/libc/include/ndbm.h b/newlib/libc/include/ndbm.h
index c5084b9c2..1e5072cf1 100644
--- a/newlib/libc/include/ndbm.h
+++ b/newlib/libc/include/ndbm.h
@@ -40,6 +40,7 @@
#ifndef _NDBM_H_
#define _NDBM_H_
+#include <sys/types.h> /* For mode_t. */
/* #include <db.h> */
/*
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix nbdm.c build break
2022-05-04 17:03 [PATCH] Fix nbdm.c build break Dimitar Dimitrov
@ 2022-05-04 17:13 ` Jeff Johnston
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnston @ 2022-05-04 17:13 UTC (permalink / raw)
To: Newlib
Patch merged. Thanks.
-- Jeff J.
On Wed, May 4, 2022 at 1:03 PM Dimitar Dimitrov <dimitar@dinux.eu> wrote:
> The ndbm.c build broke with:
> Commit 357d7fcc6
> In <stdio.h> provide only necessary types
>
> The above commit exposed a latent missing-header bug:
> newlib/newlib/libc/include/ndbm.h:83:38: error: unknown type name
> ‘mode_t’
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> newlib/libc/include/ndbm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/newlib/libc/include/ndbm.h b/newlib/libc/include/ndbm.h
> index c5084b9c2..1e5072cf1 100644
> --- a/newlib/libc/include/ndbm.h
> +++ b/newlib/libc/include/ndbm.h
> @@ -40,6 +40,7 @@
> #ifndef _NDBM_H_
> #define _NDBM_H_
>
> +#include <sys/types.h> /* For mode_t. */
> /* #include <db.h> */
>
> /*
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 17:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 17:03 [PATCH] Fix nbdm.c build break Dimitar Dimitrov
2022-05-04 17:13 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).