From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7435F3851C07 for ; Fri, 2 Oct 2020 21:03:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7435F3851C07 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-GCCkRn7tNsSnkuyrKR8RmA-1; Fri, 02 Oct 2020 17:03:07 -0400 X-MC-Unique: GCCkRn7tNsSnkuyrKR8RmA-1 Received: by mail-pj1-f69.google.com with SMTP id v10so990042pjy.2 for ; Fri, 02 Oct 2020 14:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wQzl8Y2xmaZknhHV9+svHhvrmPckwj9zfJvMfBb3tVk=; b=Lso86f0+diafyupVl6WIsahdCe9k5Xgwp+/As4SYb96v/awJeM2VB3UUfeCuxKSkXy lFmG0HYDfDrRE11Ce4u3bnIZHsJ1Yxp2t29dTh3g9DxSDoVS8ycToxKOzfwOgmL+/1sB uCOHuY++TqDV5xRfY9XR4jlPfMASSEKGdWSaah+S5u7kyO/AB96lAtEIyK9yY2+vc3xr OGeuNLIAmovHcQ+LtLp9dV5SAzFVWaE7nwE471HlCUh9jmXg/ODyVlIARywqREl0Ytuu hWh5ukaVcPtpSmxE2A9fjh2+4kX0Eid/BT2e4yW4G8jxAIGXZadUXPs1kctGKBvFs9vX ilpA== X-Gm-Message-State: AOAM533uCLTQAB7EJvrv84AcxZYYILZPPttEb85S3ZmIsWjUAYRVArHP /39B/DnpiSu8nrtRDaOwt5e4KoSKca7ADkINf7fMp3MbA6aEjBO+2PC7OUfkgDvYeBzvg8c18Z0 kqqQJJnau9n/Nph1Nzu5E/stk4U1/Z0U= X-Received: by 2002:a63:1665:: with SMTP id 37mr3932377pgw.383.1601672586603; Fri, 02 Oct 2020 14:03:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJA2Wss4sWfWRYm32VoLRFJyPADxZRNSck+nf3S4l57Y5l4muWdTn0YrXzKtC+cPNRMjOC9T9VLv9DkXs/sKk= X-Received: by 2002:a63:1665:: with SMTP id 37mr3932368pgw.383.1601672586399; Fri, 02 Oct 2020 14:03:06 -0700 (PDT) MIME-Version: 1.0 References: <20201001141753.6657-1-torbjorn.svensson@st.com> <20201001141753.6657-3-torbjorn.svensson@st.com> In-Reply-To: From: Jeff Johnston Date: Fri, 2 Oct 2020 17:02:54 -0400 Message-ID: Subject: Re: [PATCH 2/3] libc/include/wchar.h: Remove parameter name To: Torbjorn SVENSSON Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 21:03:11 -0000 Patch applied. Thanks. -- Jeff J. On Fri, Oct 2, 2020 at 2:53 AM Torbjorn SVENSSON wrote: > Patch attached. > > > > *From:* Jeff Johnston > *Sent:* den 2 oktober 2020 01:24 > *To:* Torbjorn SVENSSON > *Cc:* Newlib > *Subject:* Re: [PATCH 2/3] libc/include/wchar.h: Remove parameter name > > > > Looks good. Could you please resend the patch as an attachment? > > > > Thanks, > > > > -- Jeff J. > > > > On Thu, Oct 1, 2020 at 10:19 AM Torbj=C3=B6rn SVENSSON via Newlib < > newlib@sourceware.org> wrote: > > As discussed in GCC bug 97088 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97088), parameters in > prototypes of library functions should use reserved names, or no name > at all. > > This patch removes the 'ptr' parameter name from > wint_t _getwchar_r (struct _reent *); > wint_t _getwchar_unlocked_r (struct _reent *); > > to avoid possible clashes with user code in case someone uses > before including Newlib's wchar.h (or uses some other conflicting > definition) > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > newlib/libc/include/wchar.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/include/wchar.h b/newlib/libc/include/wchar.h > index c04a6510e..0d3e636f9 100644 > --- a/newlib/libc/include/wchar.h > +++ b/newlib/libc/include/wchar.h > @@ -248,8 +248,8 @@ int _fputws_unlocked_r (struct _reent *, const wchar_= t > *, __FILE *); > int _fwide_r (struct _reent *, __FILE *, int); > wint_t _getwc_r (struct _reent *, __FILE *); > wint_t _getwc_unlocked_r (struct _reent *, __FILE *); > -wint_t _getwchar_r (struct _reent *ptr); > -wint_t _getwchar_unlocked_r (struct _reent *ptr); > +wint_t _getwchar_r (struct _reent *); > +wint_t _getwchar_unlocked_r (struct _reent *); > wint_t _putwc_r (struct _reent *, wchar_t, __FILE *); > wint_t _putwc_unlocked_r (struct _reent *, wchar_t, __FILE *); > wint_t _putwchar_r (struct _reent *, wchar_t); > -- > 2.18.0 > >