From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3F0BB3857C5B for ; Thu, 1 Oct 2020 23:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F0BB3857C5B Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-GmBWbBiOM6arQYENoDfwXA-1; Thu, 01 Oct 2020 19:22:57 -0400 X-MC-Unique: GmBWbBiOM6arQYENoDfwXA-1 Received: by mail-pj1-f69.google.com with SMTP id d21so220437pjw.0 for ; Thu, 01 Oct 2020 16:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4jsouLn8ZN9sciZPW87DZC3naEz9BwvPt+Fjx/Si1Go=; b=Sf59b8xXnAw2xLkPMHwvorup3hZgh+d/l3+R0DKw+VmmemymSLJVhaBcHweFqYUFXe mIZcCuh0yrfdhETJ00OAYR60teit48CdDi6OQBkVBBn8ivO0gN7myfeXzP3cA/5Sit7T sLn5l/zENGq3szpL50GcLfl2fNPovqoO9jdyoB7H2YL0kydYn/dG3hJ3ze0SlJWfuwVX boivu746+eam8Cz2JXuVV3Bm/rlaBpj5PwNzSGbTb/SFVJ5Ym7i5x3JLjd95VIonVDS/ myvrBDxN1OBBqyLN1Ksv/XbHLxdSFEEwZ2UzlLBjax3T7VMhxpuZokx37GlRGkSBEQip ldKw== X-Gm-Message-State: AOAM532wMLTyfWa+mcUMqUZV6dJIFofsJ1P51l4XcecKzdoAEO5EYqfW XIoA6DD4T1LJJXXnx5/Rre3tiBh5ECxl28t1TTbQdY/72gt3Jn+ubovpXMZ/g3o5p5xD8fUxyJo DTz7/T8wjwc5fpB3mFzOPtpiAJSaEJQw= X-Received: by 2002:aa7:8d4c:0:b029:13f:e666:8f05 with SMTP id s12-20020aa78d4c0000b029013fe6668f05mr9773100pfe.0.1601594576382; Thu, 01 Oct 2020 16:22:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwe7vZFp/GCZUo+7sbWozTCeA2v9g8V2s/bAku2KVoksSBqkLQEZh+xrc1Fgp24s2nU7RpyUgo9iAAD0/tvNNs= X-Received: by 2002:aa7:8d4c:0:b029:13f:e666:8f05 with SMTP id s12-20020aa78d4c0000b029013fe6668f05mr9773091pfe.0.1601594576185; Thu, 01 Oct 2020 16:22:56 -0700 (PDT) MIME-Version: 1.0 References: <20201001141753.6657-1-torbjorn.svensson@st.com> <20201001141753.6657-2-torbjorn.svensson@st.com> In-Reply-To: <20201001141753.6657-2-torbjorn.svensson@st.com> From: Jeff Johnston Date: Thu, 1 Oct 2020 19:22:44 -0400 Message-ID: Subject: Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 23:23:03 -0000 Looks fine. Could you please resend the patch as an attachment? Thanks, -- Jeff J. On Thu, Oct 1, 2020 at 10:19 AM Torbj=C3=B6rn SVENSSON via Newlib < newlib@sourceware.org> wrote: > As discussed in GCC bug 97088 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97088), parameters in > prototypes of library functions should use reserved names, or no name > at all. > > This patch removes the 'j' parameter name from > extern intmax_t imaxabs(intmax_t); > > to avoid possible clashes with user code in case someone uses > before including Newlib's inttypes.h (or uses some other conflicting > definition) > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > newlib/libc/include/inttypes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/include/inttypes.h > b/newlib/libc/include/inttypes.h > index 073215476..570ed0481 100644 > --- a/newlib/libc/include/inttypes.h > +++ b/newlib/libc/include/inttypes.h > @@ -320,7 +320,7 @@ struct _reent; > extern "C" { > #endif > > -extern intmax_t imaxabs(intmax_t j); > +extern intmax_t imaxabs(intmax_t); > extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer); > extern intmax_t strtoimax(const char *__restrict, char **__restrict, > int); > extern intmax_t _strtoimax_r(struct _reent *, const char *__restrict, > char **__restrict, int); > -- > 2.18.0 > >