From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D35F83858436 for ; Mon, 25 Sep 2023 22:21:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D35F83858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695680481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l6a2BmQyGayyFpSmJYL2dyq1K8psfwmZjldS8cpf6I4=; b=Nvi7H6hYEDtUl2qo5OGFaNy1WVB8b5INuszcvL2RO9csRQh+xJ3dkDa2CZDfJ8bUoePIY7 cskvNZhrdK/ic+ZoZ4u+mTSQf5q78GIm92yVxf2HntEed3QrE9mM1XBtZW4m17ysOB3qmn bvc19G4c8cnLWjem8olwZMr0HBni/qY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-iOVxHUMZNmeXg5dCZ82Cww-1; Mon, 25 Sep 2023 18:21:19 -0400 X-MC-Unique: iOVxHUMZNmeXg5dCZ82Cww-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2bff4bc482bso18127761fa.0 for ; Mon, 25 Sep 2023 15:21:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695680477; x=1696285277; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l6a2BmQyGayyFpSmJYL2dyq1K8psfwmZjldS8cpf6I4=; b=CdyW2A/u/OK8XVD1hoxzzpAFhLaff0jP21iycqKctICH64N1e8CHT5L66puyCZqzR3 f6MSnAOF0OfVOqinkth0orZunXmmIopB7ROXnoQaapWoR5s23ckugCz9jVPnvhHufvRT o/dUbf5sYUtblsgWayGKXyIGRL5gALTAQf6cy8NXeOXEeDdpQ5KWgtITMSCUF3Raglcz iwNoJs35FwAHL09c0doUnLr6dFYq3EC2XmzBDJAQuiG7J6iR0T236wu0uPV4q2g03dXM vspBAkTfKBODCS04X8P1yFzNA3QbJ1bUrP1istU8owwJkpQ0v8RyYQ2F15w9mVI3oXjW 0lxw== X-Gm-Message-State: AOJu0Ywtb2APAgg2WpvpGEQrwkHopE+s5iIRYQE0z+9HptV6Slhqf0i3 sQxIMLuSXKt4HlnxcIM2kfaexdm5aua3cdnqHJNeMCrBX102pqfi2O8K/0BXzaXJ7raGJ8C21dm t9ztzB7MLKMqT2/31+KjwRG8r4s3BF8e16CogbjA= X-Received: by 2002:a2e:be23:0:b0:2bf:e5dc:aa68 with SMTP id z35-20020a2ebe23000000b002bfe5dcaa68mr6744517ljq.3.1695680477166; Mon, 25 Sep 2023 15:21:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFk7TjfAp6wa/o5+qX8YU2T7lRlyf4jbcUJwxSYEzCCZ5LItOWW5VPeuAQvs1jXskIa8Ei3yyMkKlBqmaqEofg= X-Received: by 2002:a2e:be23:0:b0:2bf:e5dc:aa68 with SMTP id z35-20020a2ebe23000000b002bfe5dcaa68mr6744506ljq.3.1695680476826; Mon, 25 Sep 2023 15:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20230925183744.848448-1-torbjorn.svensson@foss.st.com> In-Reply-To: <20230925183744.848448-1-torbjorn.svensson@foss.st.com> From: Jeff Johnston Date: Mon, 25 Sep 2023 18:21:05 -0400 Message-ID: Subject: Re: [PATCH] newlib: Add missing prototype for _getentropy To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= Cc: newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000007970d60606366036" X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007970d60606366036 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pushed to master. Thanks. -- Jeff J. On Mon, Sep 25, 2023 at 2:40=E2=80=AFPM Torbj=C3=B6rn SVENSSON < torbjorn.svensson@foss.st.com> wrote: > Ok for master? > > --- > > Fixes compile warnings like: > > .../newlib/libc/reent/getentropyr.c: In function '_getentropy_r': > .../newlib/libc/reent/getentropyr.c:48:14: warning: implicit declaration > of function '_getentropy'; did you mean 'getentropy'? > [-Wimplicit-function-declaration] > 48 | if ((ret =3D _getentropy (buf, buflen)) =3D=3D -1 && errno !=3D= 0) > | ^~~~~~~~~~~ > | getentropy > > Contributed by STMicroelectronics > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > newlib/libc/include/sys/unistd.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/newlib/libc/include/sys/unistd.h > b/newlib/libc/include/sys/unistd.h > index 807407700..25532251c 100644 > --- a/newlib/libc/include/sys/unistd.h > +++ b/newlib/libc/include/sys/unistd.h > @@ -262,6 +262,7 @@ void * _sbrk (ptrdiff_t __incr); > int _unlink (const char *__path); > _READ_WRITE_RETURN_TYPE _write (int __fd, const void *__buf, size_t > __nbyte); > int _execve (const char *__path, char * const __argv[], char * const > __envp[]); > +int _getentropy (void *, size_t); > #endif > > #if !defined(__INSIDE_CYGWIN__) > -- > 2.25.1 > > --0000000000007970d60606366036--