From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DF804385783C for ; Fri, 5 Jan 2024 21:54:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF804385783C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF804385783C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704491652; cv=none; b=CM2T1J8vfZGfGoNtKL0xDEzlVAj5nOYYooOOrYHtqSVPYj3Vmx0+3SUUZK/bWTT5l0I7jKFuKGRS+6CQeCbUqgQz8GW/Dkvou01ZO8suP6hm5Lrz93NGC1LEkwlXQhPd5LjmiUPbUxWXw3/NMVzclF81YzOQm0hlZ8G+Vapa4Dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704491652; c=relaxed/simple; bh=RU0/LCk3U/hu0E22pWOyWBwG0DlhZaVd7lwr2NoRJEQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uMrgAOTF4rPXRzTq9ImIJzn3hcZSS+mdSsulMUjh1vv8cGjzWBJ+l6vYGEWGowVO6H+4Hj/ofebkkKWm8KccXWMBG8Hl2rRzmHfjWMDfYZ6+Q5jiT+b+0N+EnSk3WB9S7JDtWKr/ZMzpfR/vUovljMYlEjwtVNL8OX+z0z2d8CQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704491650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sZbR+GpRjV0ejO0TNFewcQ71bxYQyUsMn8N94QYuszc=; b=MxasAzAzwXOgxXKAGOFRI1Q3+Ue2jgCdczOxytybnSDLB3eE7rI7G306ZdzUNwZJoPb+HQ WAt+nnlDMY62X6krJg/5U8qWLdnUyAOyHi6taxp/CYYaG/PcaToE4kicURDdW9SxnNBo26 NwPAgqu7B0dT7hrZH3izO82NNFF7aTs= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-yhKZD9CDNq2_Qsiv1Buerg-1; Fri, 05 Jan 2024 16:54:08 -0500 X-MC-Unique: yhKZD9CDNq2_Qsiv1Buerg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a296669708eso17246466b.1 for ; Fri, 05 Jan 2024 13:54:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704491647; x=1705096447; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZbR+GpRjV0ejO0TNFewcQ71bxYQyUsMn8N94QYuszc=; b=gAdvy/HKZghhasw5x7++mQ3l2MJNv2tnf5f9bwU7ih4hBWWgXvskJz90Bec6sDr9Cu AABVH0Y6/7fAKNISJfmZkeC+P15KnQ2ba2gGjgb11RbAIxBp12ynzpAbVy7m2cCeKX2G IUnI6lcTD3Ffsb7nI6+t40ThfMu3DPgI3rz2IcVJDI52bcqTFWs/GVtLTQbN35SBMQJt CHArV4IG1utO7WLVFZycQWBAmWHucJ/VXAzrwBXsck8H9Zd5y500CN/gtNVHngqyjLFj tVn4joEO6D+Tdb3tM7XGyvqUEf0HpBjaBCJpJ6Aw2AoQMAZsZDsdzORKSCRDCoAx0b5F i62g== X-Gm-Message-State: AOJu0Yzr2Q/iO84mJ/Jos6tpdghOzC/YL1wAV3G5UbEaZ3eSDXkvsnxf hjR0KSQRR1sqsRBvdq73f+EWR/a8EAAMpkEP80TbwvCyvUhK9gjMKDZbDM2mT/VMS3k341d+/O4 Lc1tfrOBCeZyBJUEXZ7zzUEF4jehMKuYsVbQfphIYYVNI/FQ= X-Received: by 2002:a17:907:9282:b0:a26:a4e8:5454 with SMTP id bw2-20020a170907928200b00a26a4e85454mr50597ejc.0.1704491647075; Fri, 05 Jan 2024 13:54:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2TTBH1sAZ/PEQxiI2eh0wANT/3ixU1FuU1JZxLodHfMrnRbUVETw7pROtaOVD9Y4a9lzGeufu2X5zkYqdJ4I= X-Received: by 2002:a17:907:9282:b0:a26:a4e8:5454 with SMTP id bw2-20020a170907928200b00a26a4e85454mr50593ejc.0.1704491646749; Fri, 05 Jan 2024 13:54:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Johnston Date: Fri, 5 Jan 2024 16:53:55 -0500 Message-ID: Subject: Re: newlib-4.4.0 yearly snapshot created To: Paul Zimmermann Cc: newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000020a34f060e39e382" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000020a34f060e39e382 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Paul, I don't seem to have a working simulator so I built a test on my x86 linux and specified all the newlib source files needed plus a stub function to avoid needing our _malloc_r and various _r methods. The test which does tgammaf(-1) returns inf whereas glibc returns nan. I have an older gcc so it isn't the level of gcc. There are a number of gamma function patches made between 4.1.0 and 4.2.0 so one of them is likely the culprit if you believe this has regressed. -- Jeff J. On Fri, Jan 5, 2024 at 4:25=E2=80=AFAM Paul Zimmermann wrote: > Hi Jeff, > > I did investigate. In fact I now get the issue with tgammaf even with > Newlib 4.2.0. It might be due to a change in the compiler used (I now use > gcc 13.2.0) or in my testing framework. > > Can you reproduce the issue? > > For the binary64 pow function, the accuracy has greatly improved with > respect > to 4.2.0. We got an error of up to 636 ulps, and now the largest error I > get > after a few tests is 0.892 ulp, which is better than the Intel Math Libra= ry > for this function (1.73 ulp). > > Paul > > > From: Jeff Johnston > > Date: Thu, 4 Jan 2024 13:44:27 -0500 > > Cc: newlib@sourceware.org > > > > > > [1:text/plain Show] > > > > > > [2:text/html Hide Save:noname (3kB)] > > > > Hi Paul, the problem you reported hasn't been solved yet and the > > snapshot is just a snapshot in time of the repo. > > > > Looking at the logs, I only see the following gamma change that occurs > > between 4.2.0 and 4.3.0: > > > > commit ec69debcb977d6395f9e91ee20133de473484e20 > > Author: Andoni Arregi > > Date: Fri Feb 11 12:16:00 2022 +0100 > > > > Improve lgammaf range for very small cases > > > > The original cut for small arguments at |x|<2**-70 (copied from the > > double version) produces that when computing nadj we get a subnormal > > number for t*x and thus, the division of pi/subnormal will be INF a= nd > > the logarithm of it too, which is wrong as a result for lgammaf in > this > > range. > > The proposed new limit seems to be safe and has been tested to > > produce accurate results. > > (Courtesy of Andreas Jung, ESA) > > > > I don't think this should have caused the regression you are seeing with > -1 > > as input, but can you confirm > > if it is? Otherwise, can you use the git bisect in concert with your > test > > to determine the > > source of the regression? > > > > Thanks, > > > > -- Jeff J. > > > > On Thu, Jan 4, 2024 at 11:03=E2=80=AFAM Paul Zimmermann < > Paul.Zimmermann@inria.fr> > > wrote: > > > > Hi Jeff, > > > > for what concerns the accuracy of math functions, the issue with huge > > error > > in pow (https://sourceware.org/pipermail/newlib/2023/020164.html) seems > > to > > have been fixed in 4.4.0, thanks! > > > > However, the regression for tgammaf(-1) with respect to 4.2.0 is still > > there: > > https://sourceware.org/pipermail/newlib/2023/020170.html. > > > > Happy New Year, > > Paul Zimmermann > > > > > From: Jeff Johnston > > > Date: Sun, 31 Dec 2023 12:23:22 -0500 > > > > > > > > > [1:text/plain Show] > > > > > > > > > [2:text/html Hide Save:noname (879B)] > > > > > > The 4.4.0 snapshot has been created and uploaded to the ftp site. F= or > > > details on changes, see the NEWS file. > > > > > > If there are any issues, I'll have to deal with them in the New Year. > > > > > > Thanks everyone for contributing last minute changes to handle the > > > c99/gcc-14 issues and thanks to all who made contributions/reviews > > this > > > year. Special thanks to Corinna for leading the project and reviewi= ng > > the > > > lion's share of the code. > > > > > > Happy New Year everyone, > > > > > > -- Jeff J. > > --00000000000020a34f060e39e382--