From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 596063857004 for ; Fri, 18 Dec 2020 17:42:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 596063857004 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-hegWKSjZPC6rP_N-cMsEDw-1; Fri, 18 Dec 2020 12:42:35 -0500 X-MC-Unique: hegWKSjZPC6rP_N-cMsEDw-1 Received: by mail-pl1-f198.google.com with SMTP id u14so1998728plx.23 for ; Fri, 18 Dec 2020 09:42:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N+fcDCmtK2qj2MH77Bv4XbN8A4C0xKpia/E1f9M6gao=; b=EGkQ/mXs50n+++8+hrRIvoWM+O5wCDuzbtS3O2rfx2wjv9SN0glcF7NGSBeHeEmIei fEHUcH5o+M7+KkV3VyCLxFxZyhr1evOkOMLpsz7U3opVBP8Ow5fpKhjt7htV1+TzpddL 1AuzwrEiVkdI3HnCS+QF+B/Ln3vLT/tRxqbjFZfPr06a8JCXJh9MWT85wrvuXxbSHtws +ZXHLJcztMkPBnYsJyHqcR4sj2/E35ewWhjrXGyxltzO4EbpbBzjHpNjAYr5wz6eG43D 4/5ORORCz3dZdLbz79R9i6W5ZOGJnq0FtBBoAp4UhtWJ+puNjb31xxyPfxNGHaIjcCcQ Copg== X-Gm-Message-State: AOAM530bi7OY49pYNL2mCJrBQxzCrg0FjbgR7hOtk4WlR1ur1MEj0MuG Rqx6EHlCR+ST53n0rQq+zVc/31mmC5pmRg6vRjJ9ks8u9IBLnzyUKMbPKbWKQpKT7qRjjiwRw7i 2lF2RVOkMKCrHkRjF4Zgod6Y40J/fIuQ= X-Received: by 2002:a63:d30e:: with SMTP id b14mr5042127pgg.237.1608313354592; Fri, 18 Dec 2020 09:42:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJySMDhnCPJqXPqn02zOZB3Z44APvPuDuCn/xUDjjOqbvsuXX/ib+JNL7MtWgdchvgwyCiT00udm3bSarztyAa0= X-Received: by 2002:a63:d30e:: with SMTP id b14mr5042119pgg.237.1608313354407; Fri, 18 Dec 2020 09:42:34 -0800 (PST) MIME-Version: 1.0 References: <871rfo76mw.fsf@keithp.com> <87v9d05jkl.fsf@keithp.com> <20201218084208.GN4560@calimero.vinschen.de> <20201218090726.GO4560@calimero.vinschen.de> In-Reply-To: <20201218090726.GO4560@calimero.vinschen.de> From: Jeff Johnston Date: Fri, 18 Dec 2020 12:42:23 -0500 Message-ID: Subject: Re: regression in tgamma? To: Newlib Cc: Corinna Vinschen X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2020 17:42:39 -0000 Thanks Paul, Corinna. I was testing locally in my directory and had a work-around for errno already in place. I will make the snapshot later this afternoon. -- Jeff J. On Fri, Dec 18, 2020 at 4:07 AM Corinna Vinschen via Newlib < newlib@sourceware.org> wrote: > On Dec 18 09:54, Paul Zimmermann wrote: > > Dear Corinna, > > > > sorry, here is the patch generated by "git format-patch". > > Thanks, I pushed the patch. > > > Corinna > > > > > > Paul > > > > >From bb94a62d68012fc38a0b6b14cedb806ff86b5c29 Mon Sep 17 00:00:00 2001 > > From: Paul Zimmermann > > Date: Fri, 18 Dec 2020 09:52:40 +0100 > > Subject: [PATCH] fixes to make compilation succeeds > > > > --- > > newlib/libm/math/w_tgamma.c | 1 + > > newlib/libm/math/wf_tgamma.c | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/newlib/libm/math/w_tgamma.c b/newlib/libm/math/w_tgamma.c > > index 0f90dd4c6..52d5d71d3 100644 > > --- a/newlib/libm/math/w_tgamma.c > > +++ b/newlib/libm/math/w_tgamma.c > > @@ -16,6 +16,7 @@ > > */ > > > > #include "fdlibm.h" > > +#include > > > > #ifndef _DOUBLE_IS_32BITS > > > > diff --git a/newlib/libm/math/wf_tgamma.c b/newlib/libm/math/wf_tgamma.c > > index 80aacf757..504cb4c29 100644 > > --- a/newlib/libm/math/wf_tgamma.c > > +++ b/newlib/libm/math/wf_tgamma.c > > @@ -15,6 +15,7 @@ > > > > #include "math.h" > > #include "fdlibm.h" > > +#include > > > > #ifdef __STDC__ > > float tgammaf(float x) > > @@ -34,7 +35,6 @@ > > errno = EDOM; > > else if (finite(x)) > > errno = ERANGE; > > - } > > return y; > > #endif > > } > > -- > > 2.29.2 > >