* [PATCH] Use right lock release in __register_exitproc()
@ 2022-05-17 17:04 Sebastian Huber
2022-05-17 19:33 ` Corinna Vinschen
2022-05-24 19:22 ` Jeff Johnston
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Huber @ 2022-05-17 17:04 UTC (permalink / raw)
To: newlib
---
newlib/libc/stdlib/__atexit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/stdlib/__atexit.c b/newlib/libc/stdlib/__atexit.c
index 04bdf194e..e59f04c2e 100644
--- a/newlib/libc/stdlib/__atexit.c
+++ b/newlib/libc/stdlib/__atexit.c
@@ -128,7 +128,7 @@ __register_exitproc (int type,
if (args == NULL)
{
#ifndef __SINGLE_THREAD__
- __lock_release(__atexit_recursive_mutex);
+ __lock_release_recursive(__atexit_recursive_mutex);
#endif
return -1;
}
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use right lock release in __register_exitproc()
2022-05-17 17:04 [PATCH] Use right lock release in __register_exitproc() Sebastian Huber
@ 2022-05-17 19:33 ` Corinna Vinschen
2022-05-24 19:22 ` Jeff Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2022-05-17 19:33 UTC (permalink / raw)
To: newlib
On May 17 19:04, Sebastian Huber wrote:
> ---
> newlib/libc/stdlib/__atexit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/stdlib/__atexit.c b/newlib/libc/stdlib/__atexit.c
> index 04bdf194e..e59f04c2e 100644
> --- a/newlib/libc/stdlib/__atexit.c
> +++ b/newlib/libc/stdlib/__atexit.c
> @@ -128,7 +128,7 @@ __register_exitproc (int type,
> if (args == NULL)
> {
> #ifndef __SINGLE_THREAD__
> - __lock_release(__atexit_recursive_mutex);
> + __lock_release_recursive(__atexit_recursive_mutex);
> #endif
> return -1;
> }
> --
> 2.35.3
Yeah, that looks wrong to me, either. Fortunately it had no negative
impact on Cygwin. Thanks for catching, please push.
Corinna
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use right lock release in __register_exitproc()
2022-05-17 17:04 [PATCH] Use right lock release in __register_exitproc() Sebastian Huber
2022-05-17 19:33 ` Corinna Vinschen
@ 2022-05-24 19:22 ` Jeff Johnston
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnston @ 2022-05-24 19:22 UTC (permalink / raw)
To: Sebastian Huber; +Cc: Newlib
Looks good, please go ahead.
-- Jeff J.
On Tue, May 17, 2022 at 1:04 PM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:
> ---
> newlib/libc/stdlib/__atexit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/stdlib/__atexit.c b/newlib/libc/stdlib/__atexit.c
> index 04bdf194e..e59f04c2e 100644
> --- a/newlib/libc/stdlib/__atexit.c
> +++ b/newlib/libc/stdlib/__atexit.c
> @@ -128,7 +128,7 @@ __register_exitproc (int type,
> if (args == NULL)
> {
> #ifndef __SINGLE_THREAD__
> - __lock_release(__atexit_recursive_mutex);
> + __lock_release_recursive(__atexit_recursive_mutex);
> #endif
> return -1;
> }
> --
> 2.35.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-24 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17 17:04 [PATCH] Use right lock release in __register_exitproc() Sebastian Huber
2022-05-17 19:33 ` Corinna Vinschen
2022-05-24 19:22 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).