From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 978763858D20 for ; Wed, 5 Apr 2023 20:12:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 978763858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680725564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p0fGxFGg0G9phom0w9T27FnCUr3Mn9K3xjtaGEswCdI=; b=T7tmjdwAIC2XZLPYkGu3ildbZYdJkDZehBQWjmoT+9LxPgvhkcOqrjz67TshY0X56D09E3 1mDkxryTRWw7fah6hWWtHDidX3ERKoybYQZwhZmOm4uHY4Bxafd+BZKvhkjbDqUIth+2Dy CFeJKfV/veOTo+0vbHjxeDkfhjwFPfI= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-58gb4nzwPRWnKZrvTxGOwg-1; Wed, 05 Apr 2023 16:12:40 -0400 X-MC-Unique: 58gb4nzwPRWnKZrvTxGOwg-1 Received: by mail-qv1-f70.google.com with SMTP id pe26-20020a056214495a00b005df3eac4c0bso13757895qvb.1 for ; Wed, 05 Apr 2023 13:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680725560; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p0fGxFGg0G9phom0w9T27FnCUr3Mn9K3xjtaGEswCdI=; b=yeDviaWcdHEEzFJG7j8GicKsnrN1c1oGgozflhFFZKyaHs5R0gXSKnunYL9G/nROp/ 8kDv6yR880qKRHypX6AId5MYzsIGTewBgEyM7yaW1lDaTCsvXs8wgKrogaafy+0EaWJf GkQ4s2gtzNH/oC2fYnu4NHIkHkUMtW1sOy4hAxi55fNPfg70YlOk06KsvMvKesAgvAk+ DArioAV3/fi/0mhGCjEBj4kl5aAC6RK9RvgGaV2mgcLfBipGUrueKA6QEIZLcWTiYpNG y3/ArqR6a4J4fhFuJsiV5BzzqDWC8CE291tzCznaUgJJR9hQH7vWHQa16gwAmyKnsuAw MHvg== X-Gm-Message-State: AAQBX9eBW7j1qHtfEd8i+IQ+MuQ/HAhMrgBOjhGDk/1Y+2pbhSRdix74 4YAIIUSD8b1HaKBs6EZS9MsvlkuiTxtyqr/loPD1rlCpnbxSuij3f4Kl6MWMTm7hS/reKYTSt6A xxMD8Arfd2cL1KzqhSJKzPDA8oquod6kY+dOOECI= X-Received: by 2002:a05:6214:4a4f:b0:56f:6925:eb2c with SMTP id ph15-20020a0562144a4f00b0056f6925eb2cmr82741qvb.10.1680725560418; Wed, 05 Apr 2023 13:12:40 -0700 (PDT) X-Google-Smtp-Source: AKy350buHTW83u990YL7PAN54PLrPMLjQj5cCsuV+lx5fpYcGybBiOUFD5YAjgQarY2BAdiXU9YMdSPIew99W6MbTcg= X-Received: by 2002:a05:6214:4a4f:b0:56f:6925:eb2c with SMTP id ph15-20020a0562144a4f00b0056f6925eb2cmr82740qvb.10.1680725560174; Wed, 05 Apr 2023 13:12:40 -0700 (PDT) MIME-Version: 1.0 References: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> In-Reply-To: From: Jeff Johnston Date: Wed, 5 Apr 2023 16:12:28 -0400 Message-ID: Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture To: newlib@sourceware.org, Jennifer Averett X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000fabf1305f89c69e6" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000fabf1305f89c69e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable See below. On Wed, Apr 5, 2023 at 5:24=E2=80=AFAM Corinna Vinschen wrote: > Hi Jennifer, > > On Apr 3 15:58, Jennifer Averett wrote: > > The attached set of patches add long double support for i386, aarch64 > and > > x86_64. The riscv and powerpc are supported by FreeBSD but will need > more > > work to be supported by newlib. FreeBSD has separate 64 and 32 bit > powerpc > > support which would have to be integrated for newlib. FreeBSD riscv > support > > is 64 and there are issues with fenv.h that would have to be addressed. > > Thanks for your patchset, it looks pretty well to me, though I like > to have input on this from my co-maintainer Jeff, too. > Looks good. I do have a comment about how the flag checks should not be removed in math.h. The _REENT_ONLY checking should still be honored as well as the m68k flag: __math_68881. There could be platforms where long double is supported (possibly doubles are 32 bits and long double is 64 bits), but there are only the 3 platforms that have the machine support headers at present. As well, from ieeefp.h there are other LDBL_MANT_DIG possibilities mentioned (e.g. 53, 65, 112) which the new code cannot handle. > I noticed that you exclude Cygwin from the new code, which makes sense > as long as we provide our own long double math taken from Mingw-w64. > > However, there's something not quite right. When trying to build I get > symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the link > stage (paths shortend for readability): > > ld: libm.a(libm_a-s_fdim.o): in function `fdimf': > newlib/libm/ld/s_fdim.c:47: multiple definition of `fdimf'; > libm.a(libm_a-sf_fdim.o):newlib/libm/common/sf_fdim.c:16: first defined h= ere > > ld: libm.a(libm_a-s_fdim.o): in function `fdiml': > newlib/libm/ld/s_fdim.c:48: multiple definition of `fdiml'; > libdll.a(fdiml.o):winsup/cygwin/math/fdiml.c:11: first defined here > > ld: libm.a(libm_a-s_scalbln.o): in function `scalblnf': > newlib/libm/ld/s_scalbln.c:46: multiple definition of `scalblnf'; > libm.a(libm_a-sf_scalbln.o):newlib/libm/common/sf_scalbln.c:34: first > defined here > > ld: libm.a(libm_a-s_scalbln.o): in function `scalblnl': > newlib/libm/ld/s_scalbln.c:53: multiple definition of `scalblnl'; > libdll.a(scalbnl.o):winsup/cygwin/scalbnl.S:19: first defined here > > The conflicts really ony occur for these four functions. Any chance > to fix these? > > > Thanks, > Corinna > > --000000000000fabf1305f89c69e6--