From: Jeff Johnston <jjohnstn@redhat.com>
To: Joe Ramsay <Joe.Ramsay@arm.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>,
"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH] Support regular file type in _swistat for ARM
Date: Thu, 4 Jun 2020 14:41:36 -0400 [thread overview]
Message-ID: <CAOox84tDn9+v-+V9hDbOKbxoDVusqKmXceXDv=Y8tJC=WJD+7g@mail.gmail.com> (raw)
In-Reply-To: <CD4FEEA0-A417-4424-8677-3B708483A109@arm.com>
cc'ing Richard.
On Thu, Jun 4, 2020 at 5:53 AM Joe Ramsay <Joe.Ramsay@arm.com> wrote:
> Hi!
>
> Previously, the implementation of _swistat() for ARM assumed all files
> to be of type character device. This change adds support for stat-ing
> regular files. Tested with arm-none-eabi
> ---
> libgloss/arm/syscalls.c | 43 +++++++++++++++++++++++++++++--------------
> 1 file changed, 29 insertions(+), 14 deletions(-)
>
> diff --git a/libgloss/arm/syscalls.c b/libgloss/arm/syscalls.c
> index fc394f9..b4bd329 100644
> --- a/libgloss/arm/syscalls.c
> +++ b/libgloss/arm/syscalls.c
> @@ -728,33 +728,48 @@ _sbrk (ptrdiff_t incr)
> int
> _swistat (int fd, struct stat * st)
> {
> - struct fdent *pfd;
> - int res;
> -
> - pfd = findslot (fd);
> + struct fdent *pfd = findslot (fd);
> if (pfd == NULL)
> {
> errno = EBADF;
> return -1;
> }
>
> - /* Always assume a character device,
> - with 1024 byte blocks. */
> - st->st_mode |= S_IFCHR;
> - st->st_blksize = 1024;
> + int isCharDevice, flen;
> #ifdef ARM_RDI_MONITOR
> - res = checkerror (do_AngelSWI (AngelSWI_Reason_FLen, &pfd->handle));
> + isCharDevice = checkerror (do_AngelSWI (AngelSWI_Reason_IsTTY,
> &pfd->handle));
> + flen = checkerror (do_AngelSWI (AngelSWI_Reason_FLen, &pfd->handle));
> #else
> asm ("mov r0, %2; swi %a1; mov %0, r0"
> - : "=r" (res)
> + : "=r" (isCharDevice)
> + : "i" (SWI_IsTTY), "r" (pfd->handle)
> + : "r0");
> + checkerror(isCharDevice);
> + asm ("mov r0, %2; swi %a1; mov %0, r0"
> + : "=r" (flen)
> : "i" (SWI_Flen), "r" (pfd->handle)
> : "r0");
> - checkerror (res);
> + checkerror(flen);
> #endif
> - if (res == -1)
> +
> + if (isCharDevice != 0 && isCharDevice != 1)
> + return error(-1);
> +
> + if (flen == -1)
> return -1;
> - /* Return the file size. */
> - st->st_size = res;
> +
> + st->st_size = flen;
> + /* Always assume 1024 byte blocks */
> + st->st_blksize = 1024;
> +
> + if (isCharDevice)
> + st->st_mode |= S_IFCHR;
> + else
> + {
> + st->st_mode |= S_IFREG;
> + st->st_blocks = (flen + 1023) / 1024;
> + }
> +
> return 0;
> }
>
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2020-06-04 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 9:53 Joe Ramsay
2020-06-04 18:41 ` Jeff Johnston [this message]
2020-06-22 11:51 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84tDn9+v-+V9hDbOKbxoDVusqKmXceXDv=Y8tJC=WJD+7g@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=Joe.Ramsay@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).