From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0147638582B0 for ; Thu, 7 Jul 2022 19:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0147638582B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657221028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSWlfnyOWtGDspEQKx5v35OTblnR0pdTEyOccgBrX2k=; b=CwH8dpWHhBqugl7QDLeVR4V9QWDSy9jBJUaS8yri/BzMgH/fsO6lz5FpmNzr2Gb1hdzaO/ xinaILsPlMOlseSlotvB2Fn9lbxASGNlW07Mj3dHFyyMKlXqNhpMXFz4MvPnv9Gl8q2+9t vrWwn0Nqea9rnUK1+gwpKqpo+cEkc3M= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-vTCEgyYvNpC9suO0jJtnJA-1; Thu, 07 Jul 2022 15:10:27 -0400 X-MC-Unique: vTCEgyYvNpC9suO0jJtnJA-1 Received: by mail-yb1-f200.google.com with SMTP id m68-20020a253f47000000b006683bd91962so14096188yba.0 for ; Thu, 07 Jul 2022 12:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WSWlfnyOWtGDspEQKx5v35OTblnR0pdTEyOccgBrX2k=; b=HPDwMwQ4mzTfjgDMbEFPamgNJiyDdjtSWX8kZmvbeMViLesa3/fpDd0LuD5tXossrr Tr/EcHK0Ci/7xZEepp7wlVPFWpH3z+HEIJEyZF0j896isTVWpR52zgMh0xifHrFPUw69 GgldU3ransyspIGvKqhr9XKQctWOr4eYU0edWuUiREZGmzAKkBzLtn2KwCvL+XXKVABc AyGLLbfk2azvp7HN0fyu/t6uFjJrTqDZSTEPZSSmvC8lTMFQYwV+1+LpVEwVn1eT8oU/ 2kPqV6kCcK4qDHL/O32blYsTofIJPfl7uBQcEZc+dShAigDM46++uX8mzlcukhRg8we1 lVaQ== X-Gm-Message-State: AJIora/8C2uGi+40W/Z670FBs7Ce4brtxBn/nX5oaQMXA8gmOMaR3Mst Z/C/eiHxh7FdSbfGFLObuPBjJ8468B8l6wgSQ8BZa80xlDMSRhC9sgWPWF+Zp1iuCObEO+bwqy2 F7D0jG1duS2vb+1KSTzQgPMw0e0oHBH4= X-Received: by 2002:a81:5909:0:b0:31c:864f:9464 with SMTP id n9-20020a815909000000b0031c864f9464mr31428741ywb.165.1657221026173; Thu, 07 Jul 2022 12:10:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ta6zvIpZsmqFMBbjd4CN760bDUajNr863yeRqYxm9Bo7afoo3PItBaenYIcxMMH8WzChsL8J9L1cxJcmibpus= X-Received: by 2002:a81:5909:0:b0:31c:864f:9464 with SMTP id n9-20020a815909000000b0031c864f9464mr31428715ywb.165.1657221025907; Thu, 07 Jul 2022 12:10:25 -0700 (PDT) MIME-Version: 1.0 References: <20220707092251.104834-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20220707092251.104834-1-sebastian.huber@embedded-brains.de> From: Jeff Johnston Date: Thu, 7 Jul 2022 15:10:14 -0400 Message-ID: Subject: Re: [PATCH] Reduce namespace pollution from To: Sebastian Huber Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 19:10:30 -0000 LGTM. -- Jeff J. On Thu, Jul 7, 2022 at 5:23 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Provide only __daddr_t through . > --- > newlib/libc/include/sys/_types.h | 4 ++++ > newlib/libc/include/sys/types.h | 6 ++---- > newlib/libc/sys/rtems/include/machine/_types.h | 4 ++-- > 3 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/newlib/libc/include/sys/_types.h > b/newlib/libc/include/sys/_types.h > index 017a0aaf6..d1112d5d1 100644 > --- a/newlib/libc/include/sys/_types.h > +++ b/newlib/libc/include/sys/_types.h > @@ -194,6 +194,10 @@ typedef _TIME_T_ __time_t; > > typedef _CLOCKID_T_ __clockid_t; > > +#ifndef __machine_daddr_t_defined > +typedef long __daddr_t; > +#endif > + > #define _TIMER_T_ unsigned long > typedef _TIMER_T_ __timer_t; > > diff --git a/newlib/libc/include/sys/types.h > b/newlib/libc/include/sys/types.h > index 4613ac81f..5035d540d 100644 > --- a/newlib/libc/include/sys/types.h > +++ b/newlib/libc/include/sys/types.h > @@ -115,10 +115,8 @@ typedef _TIME_T_ time_t; > #define _TIME_T_DECLARED > #endif > > -#ifndef __daddr_t_defined > -typedef long daddr_t; > -#define __daddr_t_defined > -#endif > +typedef __daddr_t daddr_t; > + > #ifndef __caddr_t_defined > typedef char * caddr_t; > #define __caddr_t_defined > diff --git a/newlib/libc/sys/rtems/include/machine/_types.h > b/newlib/libc/sys/rtems/include/machine/_types.h > index 5bbe5a5a6..48a320624 100644 > --- a/newlib/libc/sys/rtems/include/machine/_types.h > +++ b/newlib/libc/sys/rtems/include/machine/_types.h > @@ -30,8 +30,8 @@ typedef __uint64_t _CLOCK_T_; > typedef int _CLOCKID_T_; > #define __machine_clockid_t_defined > > -typedef __int64_t daddr_t; > -#define __daddr_t_defined > +typedef __int64_t __daddr_t; > +#define __machine_daddr_t_defined > > typedef int __accmode_t; /* access permissions */ > typedef __uint32_t __fixpt_t; /* fixed point number */ > -- > 2.35.3 > >