From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C1BC53857C71 for ; Thu, 7 Apr 2022 15:28:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1BC53857C71 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649345325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TKRgZL2lcb0ycJDcjysXZ8oE6gDLZrYjtAeIJ/m7bj8=; b=I1PHV4qHWsQzMUy5JJLwFMHE+QQ2Uhk5qGjPL3oWipyHTPiKfTKd+0BJCSlyyB5P3NkHvz xJ1vhIgbPMhY+fzzG6Cij1Kg8ppSlV+vUzMmm6qofGe1xueblA1IymaPM0KwpeLUM52lcW APnZb7rhOjxVGbxcflWFTvoDWwXGLu4= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-4ZyGJ7ClNOyBmDoBhdaHBA-1; Thu, 07 Apr 2022 11:28:44 -0400 X-MC-Unique: 4ZyGJ7ClNOyBmDoBhdaHBA-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-2eb5980c4f8so51408857b3.23 for ; Thu, 07 Apr 2022 08:28:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TKRgZL2lcb0ycJDcjysXZ8oE6gDLZrYjtAeIJ/m7bj8=; b=ndJhXlsC0V0pCpFuoAfLuSsfZBryHv9uFk1Haw+8g595wRxp+KYp5C7K1oYzxlaA81 5kbIK8bnNgX9ibxRX7fiNc0/J7Jj57RicBmmDNDT4gP3lWokdIhLm38KDEcfZIKDkNPj uc2F3yN3ETd/nm+8MOn8YKnqQC9wMijbyg6Zn7qtKUGBajyaHXiR97fgW3oP8IckJpvm PziqaGrfVWqT+YHlicKJtGq+QN00opJua6bH0xSb9PYVfj2qKn9Mxmqc3vAqc4mxGcSD syhOc4vC+ID//ATP6sTvcLlXGCt6YCv+hoTPfiLqI5EGOPP3tgIpn7q0S0Rlq4pOjvXI 3VVg== X-Gm-Message-State: AOAM531kmyRbUMuR3MkpgYC48oi6+2CmJIItKfeii/9VLpxFci/hsW7D CndiYYGM4N1DjcYxUOiGGZ3Ty5KctdHT91nC++a0fCn1EyBMU5U/fxm0dBpTikLH2B5BSa2ar4a +oFHoFYm6qlRCQ3rofMkFz/dyTgz0XAQ= X-Received: by 2002:a81:7357:0:b0:2e5:f8d1:eb92 with SMTP id o84-20020a817357000000b002e5f8d1eb92mr11729113ywc.461.1649345323631; Thu, 07 Apr 2022 08:28:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOvJmROK6CBwUJQBF9QRRiNy9LEaA3v+0IGB52/9q/kAyB+A1TW0COxtnXMZXc0xN/0ntNmwzvmT512bdFg4M= X-Received: by 2002:a81:7357:0:b0:2e5:f8d1:eb92 with SMTP id o84-20020a817357000000b002e5f8d1eb92mr11729075ywc.461.1649345323117; Thu, 07 Apr 2022 08:28:43 -0700 (PDT) MIME-Version: 1.0 References: <15d2933b-defd-f5d2-c402-7882dc20271c@jdoubleu.de> In-Reply-To: From: Jeff Johnston Date: Thu, 7 Apr 2022 11:28:32 -0400 Message-ID: Subject: Re: [PATCH] fix testsuite To: jdoubleu Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 15:28:47 -0000 Thanks, patch pushed. -- Jeff J. On Thu, Apr 7, 2022 at 5:38 AM jdoubleu wrote: > Wasn't sure what to write, since the fix was rather trivial. > > Appended a patch with some more description. Please feel free to change > the commit message, if you think something is still missing. > > > Thanks > --- > =F0=9F=99=8E=F0=9F=8F=BB=E2=80=8D=E2=99=82=EF=B8=8F jdoubleu > On 4/1/2022 3:02 PM, Corinna Vinschen wrote: > > Hi J, > > > > On Mar 24 17:54, jdoubleu wrote: > >> I found the issue: newlib/testsuite/lib/passfail.exp was using a the > >> function `newlib_target_compile` which is defined in newlib.exp but > hasn't > >> been included yet. > >> > >> I attached a patch. > >> > >> Still some tests fail to compile, but that seems more like an issue > with the > >> host environment or target board. > > > > Could you please add the description of the error you're seeing to the > > commit message of your patch, kind of as in your below first mail? > > Just "Fix testsuite" is a bit on the terse side :) > > > > > > Thanks, > > Corinna > >