From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 64C4A3858D3C for ; Fri, 8 Apr 2022 21:23:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64C4A3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649452980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7gU2jNVapny1NHCwx6q+OmOL9lp1OTmcbz+ITbg1v5g=; b=Japiia9jOwPRq+/g7Wo/6fIn+UbiSOuynF5QZKnPlNkmgGBwxTXMuRH6wonqhLyFuaxTeF nc1cY3bQObH/TmdGEbBdKgk9kgdDEsGigE3xu+idQhqEs1LQHYkMHEBqxrIaMddOOWNPMH GvM6YLcG0hFdpVh4n1CF/kAioa6x1wE= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-RFQ8diOdMuS7IoxBMGiq6g-1; Fri, 08 Apr 2022 17:22:59 -0400 X-MC-Unique: RFQ8diOdMuS7IoxBMGiq6g-1 Received: by mail-yb1-f199.google.com with SMTP id t190-20020a25c3c7000000b006410799ab3dso2205950ybf.21 for ; Fri, 08 Apr 2022 14:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7gU2jNVapny1NHCwx6q+OmOL9lp1OTmcbz+ITbg1v5g=; b=eGVztDfokpO1uOqRvqBOeQSUksRs+OvlSkj5b6mhAOsnMgSdWTMXdqyEvUUW0Xgn/X VVNGXXRO4FpcUJAKkJ5dclTj6zGCnQiRGmrtHlEIHTD/CMvexuStKfat3FIMAezVTTEH TjSIjvIfgzqK1Cv3nHZKFO0QQQk0q3V4eOGSElIffro+KyAzGCVmDf4x6a0kLTep7G3X L3rGS+Npw7VUcvpAUB6IznHGRX3RZK98aPU1/4bEx5tV9+UjGL5nPGq3doPy+69WQFXv lnnRfVA750kDLPen5Hq+cD5nhUAy3Z1mp8M4ohFHPNQx4AIV+VbFQ33ksjr78bjZwGu/ EZMA== X-Gm-Message-State: AOAM532s0IV/mMhrGObYDyy4a/K5p3KcrTSbPQ9JLkban11QprJrZHZ2 xJaE0si40PgL2O23EECb8lqY0MZPYGyFfPF7Bi3W4ouFZQ0lqHA7C8u+mm0zltbhDNaE6hdb4vA PICeztRzdYAW0CZdaXE4esFrvU9aEuEA= X-Received: by 2002:a5b:f8d:0:b0:628:620c:a45f with SMTP id q13-20020a5b0f8d000000b00628620ca45fmr14433243ybh.17.1649452979197; Fri, 08 Apr 2022 14:22:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPTs/AchDdUvlSfkd9qF3R1AJyse+9lVJi9da4ISKRUUZHHbCx8wVxuliVEaS6tNrvXs3x2y3S856ozQTv1e8= X-Received: by 2002:a5b:f8d:0:b0:628:620c:a45f with SMTP id q13-20020a5b0f8d000000b00628620ca45fmr14433232ybh.17.1649452979017; Fri, 08 Apr 2022 14:22:59 -0700 (PDT) MIME-Version: 1.0 References: <7d0a81fb-4553-a895-1353-97a6af61e6e3@foss.arm.com> In-Reply-To: <7d0a81fb-4553-a895-1353-97a6af61e6e3@foss.arm.com> From: Jeff Johnston Date: Fri, 8 Apr 2022 17:22:48 -0400 Message-ID: Subject: Re: [PATCH V2] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 To: Richard Earnshaw Cc: Andrea Corallo , Torbjorn SVENSSON , "newlib@sourceware.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 21:23:03 -0000 On Fri, Apr 8, 2022 at 6:09 AM Richard Earnshaw < Richard.Earnshaw@foss.arm.com> wrote: > > > On 04/04/2022 15:53, Andrea Corallo wrote: > > Torbjorn SVENSSON writes: > > > >> Hello, > >> > >> It would have been easier to review the patch if it was inline, but > >> this will have to do anyway. > > > > Hi Torbjorn, > > > > sorry most mail readers easily show inline attacchaments of type > > "text/plain" allowing for inline reply, at the same time this way they > > can still retain the notion of attached file. This is how I rutinary > > sent my patches to other GNU projects (including GCC) so far. Has > > newlib some specific rule around this? > > > >> I think there is a typo in math.h. Aren't you supposed to do "#ifndef" > and not "#ifdef"? > > > > I guess we are talking about this hunk? > > > > #ifdef __epiphany__ > > diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h > > index ba1a8a17e..da056b5b6 100644 > > --- a/newlib/libc/include/math.h > > +++ b/newlib/libc/include/math.h > > @@ -158,6 +158,15 @@ extern int isnan (double); > > #else > > /* Implementation-defined. Assume float_t and double_t have been > > * defined previously for this configuration (e.g. config.h). */ > > + > > + /* If __DOUBLE_TYPE is defined (__FLOAT_TYPE is then supposed to be > > + defined as well) float_t and double_t definition is suggested by > > + an arch specific header. */ > > + #ifdef __DOUBLE_TYPE > > + typedef __DOUBLE_TYPE double_t; > > + typedef __FLOAT_TYPE float_t; > > + #endif > > + /* Assume config.h has provided these types. */ > > #endif > > #else > > /* Assume basic definitions. */ > > > > I believe the #ifdef is correct. As the comment suggests if > > __DOUBLE_TYPE is defined we'll use it to define double_t otherwise we > > assume is config.h has provided the type definition. > > > > I'm reattaching the latest version of this patch with a typo fixed. > > > > Thanks! > > > > Andrea > > > > I think the hunks in machine/ieeefp.h warrant a comment as to why we > can't rely on __FLT_EVAL_METHOD__. Other than that it LGTM, but you'll > need Corinna or Jeff to approve. > > R. > > Please add the comment as suggested by Richard and it will be pushed. -- Jeff J.