From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id D544D3857C71 for ; Fri, 2 Oct 2020 21:01:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D544D3857C71 Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-AUP9MwQGN8uLo9p-FxbCNw-1; Fri, 02 Oct 2020 17:01:31 -0400 X-MC-Unique: AUP9MwQGN8uLo9p-FxbCNw-1 Received: by mail-pj1-f71.google.com with SMTP id ng5so1493854pjb.0 for ; Fri, 02 Oct 2020 14:01:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RVK+xE5xv5v2ChWV4fr/cN9vAilMCwgjLhSwP3auGJw=; b=aW/0FAsHm0acHYeH0I/WK4m52wET/HmFdKW0vmkwdamU/F/Zi7RFJ1PXBi9bUCdYF+ OBSUoarsvclG2SSZ0X3MSbYF95P9o72JrEboXwbePoSvUs22bjeebFlMf8vDXAplc5/g 0nF4SpiQtIr6hHd7K4zF3z3vfixqBtC9+bzeGWvnvfQ0i8pgWrePJHCwqi+Mnx4hLehy YVcZZQRRzB5hzcRX/W4Pp2kDHsl9sAYzNUU+32bMkP1cgFy1nLSkMHz1UICwzZFlCCia irF2cHw8K7ssD4oHKRCDiRd4mriAXlbHmfQzmrPKAJzP1IciOtnAbkuoRz4wYYGCTGaM F5sw== X-Gm-Message-State: AOAM530xSw5pniOKrX4WmfpRzwAw8842YWRFPU1+kC4LoLdX4sR/CDoW jN4+J0I6kNhigJoc6xtEl+WJ1yi6pWbne5/kGAMC+NSjXgvq0etGxPvSlWN5T9SFssgsLlYwBuc OCYK0HKi5H84QsBCLne4/HDrtWWnzkqM= X-Received: by 2002:aa7:8d4c:0:b029:13f:e666:8f05 with SMTP id s12-20020aa78d4c0000b029013fe6668f05mr4854513pfe.0.1601672489220; Fri, 02 Oct 2020 14:01:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHn4pY57PnYFBQqhV2pG1gC8QUruzr+Q3R9csCyROwpqKDUsvI3QCEkliouhyoA3Bessoh4eKLuE5t0pxgrMY= X-Received: by 2002:aa7:8d4c:0:b029:13f:e666:8f05 with SMTP id s12-20020aa78d4c0000b029013fe6668f05mr4854491pfe.0.1601672488933; Fri, 02 Oct 2020 14:01:28 -0700 (PDT) MIME-Version: 1.0 References: <20201001141753.6657-1-torbjorn.svensson@st.com> <20201001141753.6657-2-torbjorn.svensson@st.com> In-Reply-To: From: Jeff Johnston Date: Fri, 2 Oct 2020 17:01:17 -0400 Message-ID: Subject: Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name To: Torbjorn SVENSSON Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 21:01:42 -0000 Patch applied. Thanks. -- Jeff J. On Fri, Oct 2, 2020 at 2:52 AM Torbjorn SVENSSON wrote: > Patch attached. > > > > *From:* Jeff Johnston > *Sent:* den 2 oktober 2020 01:23 > *To:* Torbjorn SVENSSON > *Cc:* Newlib > *Subject:* Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name > > > > Looks fine. Could you please resend the patch as an attachment? > > > > Thanks, > > > > -- Jeff J. > > > > On Thu, Oct 1, 2020 at 10:19 AM Torbj=C3=B6rn SVENSSON via Newlib < > newlib@sourceware.org> wrote: > > As discussed in GCC bug 97088 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97088), parameters in > prototypes of library functions should use reserved names, or no name > at all. > > This patch removes the 'j' parameter name from > extern intmax_t imaxabs(intmax_t); > > to avoid possible clashes with user code in case someone uses > before including Newlib's inttypes.h (or uses some other conflicting > definition) > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > newlib/libc/include/inttypes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/include/inttypes.h > b/newlib/libc/include/inttypes.h > index 073215476..570ed0481 100644 > --- a/newlib/libc/include/inttypes.h > +++ b/newlib/libc/include/inttypes.h > @@ -320,7 +320,7 @@ struct _reent; > extern "C" { > #endif > > -extern intmax_t imaxabs(intmax_t j); > +extern intmax_t imaxabs(intmax_t); > extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer); > extern intmax_t strtoimax(const char *__restrict, char **__restrict, > int); > extern intmax_t _strtoimax_r(struct _reent *, const char *__restrict, > char **__restrict, int); > -- > 2.18.0 > >