From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4EED53858402 for ; Mon, 29 Nov 2021 23:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EED53858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638228436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9lbq7Ur8ePto3SonIoPapYUn4omu8tMAnUm2yUiHq9s=; b=GYnubsqNnig5eeiP8/5N9N//p2LmHtRnxKFUvhAKbiJQBI40Y7r9AYRXQ3k4jHyIAiQZsA blUHXPlifKLvJxfcVaAwilp37tMPmItVVk99yA4ReymIPll7BOmmewJjqhXSSeKUO5mTcL H1GOLeKChVglqndL4af4hx7LionoP1o= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-oJU-rqByMT2gROj482j2ag-1; Mon, 29 Nov 2021 18:27:12 -0500 X-MC-Unique: oJU-rqByMT2gROj482j2ag-1 Received: by mail-pl1-f198.google.com with SMTP id y6-20020a17090322c600b001428ab3f888so7149166plg.8 for ; Mon, 29 Nov 2021 15:27:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgrSz3HwSyjDAvqsLxcQ8hFcGG9oG/V0wmMjnKuoH1w=; b=Y3xC6cWlu4S0fHAosmJKjqrQ5LTYPPX615Rt2HmJoOP3XDvAx95c6zxf/Evn/RcQFm Hb2iQqqjRUhHLhEB7SmSHV+BG1BZ2aB2U7XYdl7BHSdc5xBH9BUEfQ1DqYoadWWg2gLU ywJ+YDxWkpL5UZ19Od3H3C6gxfVC69DPxn0krtn1rxwl6rtw+GLBuMHO1ftacvp28ezZ F2cD0Qw9Lyr7zvKecPzc76mFRMu/AaqqU95thMFqpl24WtBhqt8oIp76PfXdj/juiPLy WR3N3L6Up+9rUCVpTuC2x3DXZpUP/V4QUBt75Uue/oq4NkZc8KGQKXfy4h4e8DEG73Zw 269A== X-Gm-Message-State: AOAM532ZSAwH/nPm1ImC9j9lK2Kj8ULUetZ9mdzCCwe7MGBSVqy/o1HR oU1Z1JHtQTnEuOM2oXJ0dkKHmY3xxmi2Gw92YD009iry1o925IQYMTY5Cz65KrTW+4y5BPIKV37 5O1IxqhaB4r/9JV7drnobJKurSOubwow= X-Received: by 2002:a17:902:9882:b0:143:91ca:ca6e with SMTP id s2-20020a170902988200b0014391caca6emr62695029plp.64.1638228431547; Mon, 29 Nov 2021 15:27:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpCqKnv2CPwlyB5yQYIrfFb2wHdJUZt51cZ6TuZ51jwOipWj0wwlnNDtTE+xiMh8yRQl/Y8fJVX33B6VQw0H8= X-Received: by 2002:a17:902:9882:b0:143:91ca:ca6e with SMTP id s2-20020a170902988200b0014391caca6emr62695003plp.64.1638228431263; Mon, 29 Nov 2021 15:27:11 -0800 (PST) MIME-Version: 1.0 References: <20211125220413.35e7869f@faultier2go.lan> In-Reply-To: <20211125220413.35e7869f@faultier2go.lan> From: Jeff Johnston Date: Mon, 29 Nov 2021 18:27:00 -0500 Message-ID: Subject: Re: Compilation for mips-mti-elf fails To: Marian Buschsieweke Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000b51e8605d1f5c755" X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2021 23:27:19 -0000 --000000000000b51e8605d1f5c755 Content-Type: text/plain; charset="UTF-8" Hi Marian, Thanks for the patch. That directory has a Makefile.am file so it must be modified and the Makefile.in generated. I have included a modified version of your patch. If you have no objections, I'll check it in. Regards, -- Jeff J. On Thu, Nov 25, 2021 at 4:04 PM Marian Buschsieweke < marian.buschsieweke@ovgu.de> wrote: > Hi, > > compiling for newlib with GCC 11.2.0 for mips-mti-elf with multilib > now fails with "Error: unrecognized opcode `cfc1 $3,$31'" while compiling > newlib/libm/machine/mips/fenv.c > > More precisely, newlib/libc/machine/mips/machine/fenv-fp.h included by > fenv.c > contains multiple calls of the function line macro __cfc1() which is > defined in > newlib/libc/machine/mips/sys/fenv.h as > > #define __cfc1(__fcsr) __asm __volatile("cfc1 %0, $31" : "=r" > (__fcsr)) > > Apparently, this is not compatible with mips16. Adding -mno-mips16 to the > invocation of the compiler fixes the comiplation. (The same was already > done for > cma101.c and cygmon.c in libgloss.) > > Attached is a potential fix. > > Kind regards, > Marian > --000000000000b51e8605d1f5c755 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Modifying-patch-from-marian.buschsieweke-ovgu.de.patch" Content-Disposition: attachment; filename="0001-Modifying-patch-from-marian.buschsieweke-ovgu.de.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kwlau9ge0 RnJvbSBmM2RmM2UxNDVkMWIyYTU0YTI0OGRiM2EyYTY4MjcxNjY0ZGRlODZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIEpvaG5zdG9uIDxqam9obnN0bkByZWRoYXQuY29tPgpE YXRlOiBNb24sIDI5IE5vdiAyMDIxIDE3OjMzOjUyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gTW9k aWZ5aW5nIHBhdGNoIGZyb206IG1hcmlhbi5idXNjaHNpZXdla2VAb3ZndS5kZQoKVGhlIGNvZGUg YWNjZXNzaW5nIHRoZSBmbG9hdGluZyBwb2ludCBjb250cm9sL3N0YXR1cyByZWdpc3RlciwgbmFt ZWx5CgoJI2RlZmluZQlfX2NmYzEoX19mY3NyKQlfX2FzbSBfX3ZvbGF0aWxlKCJjZmMxICUwLCAk MzEiIDogIj1yIiAoX19mY3NyKQoKZG9lcyBub3QgY29tcGlsZSB3aXRoIG1pcHMxNi4gVGhpcyBj aGFuZ2VkIHRoZSBtYWtlZmlsZSB0byBwYXNzIC1tbm8tbWlwczE2IHRvIGF2b2lkIHRoZSBmb2xs b3dpbmcKY29tcGlsZXIgZXJyb3I6CgoJbWlwcy1tdGktZWxmIGZhaWxzIHdpdGggIkVycm9yOiB1 bnJlY29nbml6ZWQgb3Bjb2RlIGBjZmMxICQzLCQzMSciCi0tLQogbmV3bGliL2xpYm0vbWFjaGlu ZS9taXBzL01ha2VmaWxlLmFtIHwgMTIgKysrKysrKysrKy0tCiBuZXdsaWIvbGlibS9tYWNoaW5l L21pcHMvTWFrZWZpbGUuaW4gfCAyMSArKysrKysrKysrKystLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbmV3 bGliL2xpYm0vbWFjaGluZS9taXBzL01ha2VmaWxlLmFtIGIvbmV3bGliL2xpYm0vbWFjaGluZS9t aXBzL01ha2VmaWxlLmFtCmluZGV4IGJiMTQyYTYuLmNlZjQ5NTcgMTAwNjQ0Ci0tLSBhL25ld2xp Yi9saWJtL21hY2hpbmUvbWlwcy9NYWtlZmlsZS5hbQorKysgYi9uZXdsaWIvbGlibS9tYWNoaW5l L21pcHMvTWFrZWZpbGUuYW0KQEAgLTYsOCArNiw3IEBAIElOQ0xVREVTID0gLUkgJChuZXdsaWJf YmFzZWRpcikvLi4vbmV3bGliL2xpYm0vY29tbW9uICQoTkVXTElCX0NGTEFHUykgXAogTElCX1NP VVJDRVMgPSBcCiAJZmVjbGVhcmV4Y2VwdC5jIGZlZ2V0ZW52LmMgZmVnZXRleGNlcHRmbGFnLmMg XAogCWZlZ2V0cm91bmQuYyBmZWhvbGRleGNlcHQuYyBmZXJhaXNlZXhjZXB0LmMgZmVzZXRlbnYu YyBcCi0JZmVzZXRleGNlcHRmbGFnLmMgZmVzZXRyb3VuZC5jIGZldGVzdGV4Y2VwdC5jIGZldXBk YXRlZW52LmMgXAotCWZlbnYuYworCWZlc2V0ZXhjZXB0ZmxhZy5jIGZlc2V0cm91bmQuYyBmZXRl c3RleGNlcHQuYyBmZXVwZGF0ZWVudi5jCiAKIG5vaW5zdF9MSUJSQVJJRVMgPSBsaWIuYQogbGli X2FfU09VUkNFUyA9ICQoTElCX1NPVVJDRVMpCkBAIC0xNyw1ICsxNiwxNCBAQCBub2luc3RfREFU QSA9CiAKIGluY2x1ZGUgJChzcmNkaXIpLy4uLy4uLy4uL01ha2VmaWxlLnNoYXJlZAogCitMSUJB RERfT0JKUyA9IFwKKwlsaWJfYS1mZW52LiQoT0JKRVhUKQorCitsaWJfYS1mZW52Lm86IGZlbnYu YworCSQoQ09NUElMRSkgLW1uby1taXBzMTYgLWMgLW8gJEAgYHRlc3QgLWYgJ2ZlbnYuYycgfHwg ZWNobyAnJChzcmNkaXIpLydgZmVudi5jCisKK2xpYl9hLWZlbnYub2JqOiBmZW52LmMKKwkkKENP TVBJTEUpIC1tbm8tbWlwczE2IC1jIC1vICRAIGBpZiB0ZXN0IC1mICdmZW52LmMnOyB0aGVuICQo Q1lHUEFUSF9XKSAnZmVudi5jJzsgZWxzZSAkKENZR1BBVEhfVykgJyQoc3JjZGlyKS9mZW52LmMn OyBmaWAKKwogQUNMT0NBTF9BTUZMQUdTID0gLUkgLi4vLi4vLi4gLUkgLi4vLi4vLi4vLi4KIENP TkZJR19TVEFUVVNfREVQRU5ERU5DSUVTID0gJChuZXdsaWJfYmFzZWRpcikvY29uZmlndXJlLmhv c3QKZGlmZiAtLWdpdCBhL25ld2xpYi9saWJtL21hY2hpbmUvbWlwcy9NYWtlZmlsZS5pbiBiL25l d2xpYi9saWJtL21hY2hpbmUvbWlwcy9NYWtlZmlsZS5pbgppbmRleCAyYTQyMTQ1Li5jZmFiNzE3 IDEwMDY0NAotLS0gYS9uZXdsaWIvbGlibS9tYWNoaW5lL21pcHMvTWFrZWZpbGUuaW4KKysrIGIv bmV3bGliL2xpYm0vbWFjaGluZS9taXBzL01ha2VmaWxlLmluCkBAIC03NSw3ICs3NSw3IEBAIGFt X19vYmplY3RzXzEgPSBsaWJfYS1mZWNsZWFyZXhjZXB0LiQoT0JKRVhUKSBsaWJfYS1mZWdldGVu di4kKE9CSkVYVCkgXAogCWxpYl9hLWZlaG9sZGV4Y2VwdC4kKE9CSkVYVCkgbGliX2EtZmVyYWlz ZWV4Y2VwdC4kKE9CSkVYVCkgXAogCWxpYl9hLWZlc2V0ZW52LiQoT0JKRVhUKSBsaWJfYS1mZXNl dGV4Y2VwdGZsYWcuJChPQkpFWFQpIFwKIAlsaWJfYS1mZXNldHJvdW5kLiQoT0JKRVhUKSBsaWJf YS1mZXRlc3RleGNlcHQuJChPQkpFWFQpIFwKLQlsaWJfYS1mZXVwZGF0ZWVudi4kKE9CSkVYVCkg bGliX2EtZmVudi4kKE9CSkVYVCkKKwlsaWJfYS1mZXVwZGF0ZWVudi4kKE9CSkVYVCkKIGFtX2xp Yl9hX09CSkVDVFMgPSAkKGFtX19vYmplY3RzXzEpCiBsaWJfYV9PQkpFQ1RTID0gJChhbV9saWJf YV9PQkpFQ1RTKQogREVGQVVMVF9JTkNMVURFUyA9IC1JLkBhbV9faXNyY0AKQEAgLTE4OSw2ICsx ODksNyBAQCBwcmVmaXggPSBAcHJlZml4QAogcHJvZ3JhbV90cmFuc2Zvcm1fbmFtZSA9IEBwcm9n cmFtX3RyYW5zZm9ybV9uYW1lQAogcHNkaXIgPSBAcHNkaXJACiBzYmluZGlyID0gQHNiaW5kaXJA CitzaGFyZWRfbWFjaGluZV9kaXIgPSBAc2hhcmVkX21hY2hpbmVfZGlyQAogc2hhcmVkc3RhdGVk aXIgPSBAc2hhcmVkc3RhdGVkaXJACiBzcmNkaXIgPSBAc3JjZGlyQAogc3lzX2RpciA9IEBzeXNf ZGlyQApAQCAtMjAzLDggKzIwNCw3IEBAIElOQ0xVREVTID0gLUkgJChuZXdsaWJfYmFzZWRpcikv Li4vbmV3bGliL2xpYm0vY29tbW9uICQoTkVXTElCX0NGTEFHUykgXAogTElCX1NPVVJDRVMgPSBc CiAJZmVjbGVhcmV4Y2VwdC5jIGZlZ2V0ZW52LmMgZmVnZXRleGNlcHRmbGFnLmMgXAogCWZlZ2V0 cm91bmQuYyBmZWhvbGRleGNlcHQuYyBmZXJhaXNlZXhjZXB0LmMgZmVzZXRlbnYuYyBcCi0JZmVz ZXRleGNlcHRmbGFnLmMgZmVzZXRyb3VuZC5jIGZldGVzdGV4Y2VwdC5jIGZldXBkYXRlZW52LmMg XAotCWZlbnYuYworCWZlc2V0ZXhjZXB0ZmxhZy5jIGZlc2V0cm91bmQuYyBmZXRlc3RleGNlcHQu YyBmZXVwZGF0ZWVudi5jCiAKIG5vaW5zdF9MSUJSQVJJRVMgPSBsaWIuYQogbGliX2FfU09VUkNF UyA9ICQoTElCX1NPVVJDRVMpCkBAIC0yMjEsNiArMjIxLDkgQEAgRE9DQk9PS19DSEVXID0gJHt0 b3Bfc3JjZGlyfS8uLi9kb2MvbWFrZWRvY2Jvb2sucHkKIERPQ0JPT0tfT1VUX0ZJTEVTID0gJChD SEVXT1VUX0ZJTEVTOi5kZWY9LnhtbCkKIERPQ0JPT0tfQ0hBUFRFUlMgPSAkKENIQVBURVJTOi50 ZXg9LnhtbCkKIENMRUFORklMRVMgPSAkKENIRVdPVVRfRklMRVMpICQoRE9DQk9PS19PVVRfRklM RVMpCitMSUJBRERfT0JKUyA9IFwKKwlsaWJfYS1mZW52LiQoT0JKRVhUKQorCiBBQ0xPQ0FMX0FN RkxBR1MgPSAtSSAuLi8uLi8uLiAtSSAuLi8uLi8uLi8uLgogQ09ORklHX1NUQVRVU19ERVBFTkRF TkNJRVMgPSAkKG5ld2xpYl9iYXNlZGlyKS9jb25maWd1cmUuaG9zdAogYWxsOiBhbGwtYW0KQEAg LTM0OCwxMiArMzUxLDYgQEAgbGliX2EtZmV1cGRhdGVlbnYubzogZmV1cGRhdGVlbnYuYwogbGli X2EtZmV1cGRhdGVlbnYub2JqOiBmZXVwZGF0ZWVudi5jCiAJJChDQykgJChERUZTKSAkKERFRkFV TFRfSU5DTFVERVMpICQoSU5DTFVERVMpICQoQU1fQ1BQRkxBR1MpICQoQ1BQRkxBR1MpICQobGli X2FfQ0ZMQUdTKSAkKENGTEFHUykgLWMgLW8gbGliX2EtZmV1cGRhdGVlbnYub2JqIGBpZiB0ZXN0 IC1mICdmZXVwZGF0ZWVudi5jJzsgdGhlbiAkKENZR1BBVEhfVykgJ2ZldXBkYXRlZW52LmMnOyBl bHNlICQoQ1lHUEFUSF9XKSAnJChzcmNkaXIpL2ZldXBkYXRlZW52LmMnOyBmaWAKIAotbGliX2Et ZmVudi5vOiBmZW52LmMKLQkkKENDKSAkKERFRlMpICQoREVGQVVMVF9JTkNMVURFUykgJChJTkNM VURFUykgJChBTV9DUFBGTEFHUykgJChDUFBGTEFHUykgJChsaWJfYV9DRkxBR1MpICQoQ0ZMQUdT KSAtYyAtbyBsaWJfYS1mZW52Lm8gYHRlc3QgLWYgJ2ZlbnYuYycgfHwgZWNobyAnJChzcmNkaXIp LydgZmVudi5jCi0KLWxpYl9hLWZlbnYub2JqOiBmZW52LmMKLQkkKENDKSAkKERFRlMpICQoREVG QVVMVF9JTkNMVURFUykgJChJTkNMVURFUykgJChBTV9DUFBGTEFHUykgJChDUFBGTEFHUykgJChs aWJfYV9DRkxBR1MpICQoQ0ZMQUdTKSAtYyAtbyBsaWJfYS1mZW52Lm9iaiBgaWYgdGVzdCAtZiAn ZmVudi5jJzsgdGhlbiAkKENZR1BBVEhfVykgJ2ZlbnYuYyc7IGVsc2UgJChDWUdQQVRIX1cpICck KHNyY2RpcikvZmVudi5jJzsgZmlgCi0KIElEOiAkKEhFQURFUlMpICQoU09VUkNFUykgJChMSVNQ KSAkKFRBR1NfRklMRVMpCiAJbGlzdD0nJChTT1VSQ0VTKSAkKEhFQURFUlMpICQoTElTUCkgJChU QUdTX0ZJTEVTKSc7IFwKIAl1bmlxdWU9YGZvciBpIGluICQkbGlzdDsgZG8gXApAQCAtNTU0LDYg KzU1MSwxMiBAQCBkb2Nib29rOiAkKERPQ0JPT0tfT1VUX0ZJTEVTKQogCSAgJHt0b3Bfc3JjZGly fS8uLi9kb2MvY2hhcHRlci10ZXhpMmRvY2Jvb2sucHkgPCQoc3JjZGlyKS8kJHtjaGFwdGVyJS54 bWx9LnRleCA+Li4vJCRjaGFwdGVyIDsgXAogCWRvbmUKIAorbGliX2EtZmVudi5vOiBmZW52LmMK KwkkKENPTVBJTEUpIC1tbm8tbWlwczE2IC1jIC1vICRAIGB0ZXN0IC1mICdmZW52LmMnIHx8IGVj aG8gJyQoc3JjZGlyKS8nYGZlbnYuYworCitsaWJfYS1mZW52Lm9iajogZmVudi5jCisJJChDT01Q SUxFKSAtbW5vLW1pcHMxNiAtYyAtbyAkQCBgaWYgdGVzdCAtZiAnZmVudi5jJzsgdGhlbiAkKENZ R1BBVEhfVykgJ2ZlbnYuYyc7IGVsc2UgJChDWUdQQVRIX1cpICckKHNyY2RpcikvZmVudi5jJzsg ZmlgCisKICMgVGVsbCB2ZXJzaW9ucyBbMy41OSwzLjYzKSBvZiBHTlUgbWFrZSB0byBub3QgZXhw b3J0IGFsbCB2YXJpYWJsZXMuCiAjIE90aGVyd2lzZSBhIHN5c3RlbSBsaW1pdCAoZm9yIFN5c1Yg YXQgbGVhc3QpIG1heSBiZSBleGNlZWRlZC4KIC5OT0VYUE9SVDoKLS0gCjEuOC4zLjEKCg== --000000000000b51e8605d1f5c755--