From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2928C385840F for ; Thu, 7 Apr 2022 21:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2928C385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649367366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QsJfvghgqnzMOEnULaNXL6jNPnyUvy7w/VH79MJkVwM=; b=U/SztwUzFF30Wpjgix54At0SjIzPVvS9SH79S8duBQ3v99tznRtwTu+g60fEMLyDHbPHSp csuDupuXvYUS1SUOh2bQgSCZhMKwmivt19QPzTHUATwSxg0loROxs30H+c0qDK+6TnZNNL mFsbvJX0b2B8F/BDk3usQTm+wVEc/lo= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-WzY2nvDZNLWQzK69x6zMwQ-1; Thu, 07 Apr 2022 17:36:05 -0400 X-MC-Unique: WzY2nvDZNLWQzK69x6zMwQ-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-2dc7bdd666fso59204277b3.7 for ; Thu, 07 Apr 2022 14:36:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QsJfvghgqnzMOEnULaNXL6jNPnyUvy7w/VH79MJkVwM=; b=SrZQ0yoK3EQgpTzPharHL6obUZn7L+ueN8AWSsVk0xOhPeEw9rHG4fygMRw7Aw9b8B bgKeR+D9L8WPfvVx8iDnaVsb6dZZAzsLnOmtBr0gsmr2JR3y6g8/g0ApwY4Ae4yLkCut ok2dRYCUnqBSYwMCLxhBShf4LxCdtB9VQOf4pi1QIetsgoy4rUvO4Tm5z9TWfglrnlo3 dWtahmXoYrOZ6SOgMymanlbyjGyyROJMZAMg5+hbn60dVdZ7Ho5wiOFYa/D/A8OisDUa NtK9w+lCyl0DPwPxwu2pAVl5wQ4uEvM/xnZqBXPmncaR466nkHSwN9QAlGML+vli3vCx J2Dw== X-Gm-Message-State: AOAM5307+fGm8jauqcHa/VHNZ5JrvOO7p5iH9XkHhlkLdZzIeIhykNGi vy37OIJPrtmVvA4R7jrwjz6bnPTvGigP/9QFv/xIQjxQkhK01Kb4ZrV7RsKR0Ne0EOL7eb2xkrB chhE1QhsM3qlcO2HbkfOywXwCBkISiKk= X-Received: by 2002:a0d:f487:0:b0:2eb:54f5:3abf with SMTP id d129-20020a0df487000000b002eb54f53abfmr13704157ywf.141.1649367364863; Thu, 07 Apr 2022 14:36:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcFL7EnkenTIiV9tvoJtUK/C2xLrMRfXClLcOJsdVhUNz3sEUIGR95zxgxGt+Tot2RJPlgzzdkRGF5k22ESv0= X-Received: by 2002:a0d:f487:0:b0:2eb:54f5:3abf with SMTP id d129-20020a0df487000000b002eb54f53abfmr13704147ywf.141.1649367364678; Thu, 07 Apr 2022 14:36:04 -0700 (PDT) MIME-Version: 1.0 References: <20220405040358.18332-1-Brian.Inglis@SystematicSW.ab.ca> <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca> In-Reply-To: <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca> From: Jeff Johnston Date: Thu, 7 Apr 2022 17:35:53 -0400 Message-ID: Subject: Re: [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): POSIX angle bracket <> support To: Brian Inglis Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 21:36:11 -0000 Hi Brian, Looks good. The only issue I have are the added includes (limits.h and unistd.h) which don't appear to be needed. Is there a reason for this? -- Jeff J. On Tue, Apr 5, 2022 at 12:04 AM Brian Inglis < Brian.Inglis@systematicsw.ab.ca> wrote: > > local defines for POSIX minimum TZ abbr size 3 TZNAME_MIN and > maximum TZ abbr size supported 10 TZNAME_MAX > allow POSIX angle bracket < > quoted signed alphanumeric tz abbr e.g. > > allow POSIX unquoted alphabetic tz abbr e.g. MESZ > allow same suuport for DST tz abbr > --- > newlib/libc/time/tzset_r.c | 67 +++++++++++++++++++++++++++++++------- > 1 file changed, 55 insertions(+), 12 deletions(-) > >