From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7EA763857C61 for ; Sat, 26 Sep 2020 02:54:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7EA763857C61 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-oNMAjLhjMtS6_OPn91c87A-1; Fri, 25 Sep 2020 22:54:43 -0400 X-MC-Unique: oNMAjLhjMtS6_OPn91c87A-1 Received: by mail-pg1-f199.google.com with SMTP id a129so3664795pgc.1 for ; Fri, 25 Sep 2020 19:54:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zuD7LKYx+HeXQEwkkEcyFnbu4Hz37N4qWo1sNWy6Nt0=; b=N5YPsyskLxUct+OmqjEeITszcom/xRd8cc9SiAfs09BYzoxSjqf9o8tcInsi3kzVdN 13FbBxqmkaqiBDJrphLEGHZecVLPP7LbmcN1lDEudR3njnKlzNpA1XnZdFbPjJr+fokf 1yO5KJoL/ibgcBm6wXMr4TPIymuPgPgi7l1IkoV8qvrc0qru6oU74I+pEu3fyE4GLHYU erHpr7KmEfaPy+b2+b+aSlfVfW+q6eX/vt0M6p6/uwnlv6ytnV7qS6E/Ga+NBB73L0pz 3B6BvlFy7xplAGO2qqUclMYKDFWpiPeyDo2q6ME16TNUKqaSR2zeLGZPKWUiSFX+1LFJ +2rA== X-Gm-Message-State: AOAM5327B+QtCGcl7GVno2yIMMXASeeh3Py2gf7fpbhq47e5lz8ZPquO EXZWP39wYtGwU9t29qu7mpthmU0gwhoBxwnFczJXjJ12rc4FbahAGuvTwa6pXjZknamvIWmblXy nU/7wI/tOEn8pxj+cnP315iOYNZzFcO0= X-Received: by 2002:a17:90a:67cb:: with SMTP id g11mr486832pjm.56.1601088882405; Fri, 25 Sep 2020 19:54:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUikH0Z1FUJDEG1xOQGbtIm8kwX+fudvC1MrXfdI5mI+41vSfDFmcrYCXcd40I7Rcz+L1a88umBNOw+BOMHwU= X-Received: by 2002:a17:90a:67cb:: with SMTP id g11mr486824pjm.56.1601088882159; Fri, 25 Sep 2020 19:54:42 -0700 (PDT) MIME-Version: 1.0 References: <1600702161-13623-1-git-send-email-christophe.lyon@linaro.org> In-Reply-To: From: Jeff Johnston Date: Fri, 25 Sep 2020 22:54:30 -0400 Message-ID: Subject: Re: [PATCH] libc/include/math.h: Remove parameter name To: Christophe Lyon Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2020 02:54:52 -0000 Patch pushed to master. Thanks. -- Jeff J On Wed, Sep 23, 2020 at 5:23 AM Christophe Lyon wrote: > On Wed, 23 Sep 2020 at 00:07, Jeff Johnston wrote: > > > > Hi Christophe, > > > > Can you please resend the patch as an attachment? > > > > Sure, here it is. > > Christohe > > > Thanks, > > > > -- Jeff J. > > > > On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib < > newlib@sourceware.org> wrote: > >> > >> As discussed in GCC bug 97088 > >> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in > >> prototypes of library functions should use reserved names, or no name > >> at all. > >> > >> This patch removes the 'x' parameter name from > >> extern int __isinff (float); > >> extern int __isinfd (double); > >> extern int __isnanf (float); > >> extern int __isnand (double); > >> extern int __fpclassifyf (float); > >> extern int __fpclassifyd (double); > >> extern int __signbitf (float); > >> extern int __signbitd (double); > >> > >> to avoid possible clashes with user code in case someone uses > >> before including Newlib's math.h (or uses some other conflicting > >> definition) > >> --- > >> newlib/libc/include/math.h | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h > >> index 5e6155c..ba1a8a1 100644 > >> --- a/newlib/libc/include/math.h > >> +++ b/newlib/libc/include/math.h > >> @@ -201,14 +201,14 @@ extern int isnan (double); > >> # define math_errhandling (_MATH_ERRHANDLING_ERRNO | > _MATH_ERRHANDLING_ERREXCEPT) > >> #endif > >> > >> -extern int __isinff (float x); > >> -extern int __isinfd (double x); > >> -extern int __isnanf (float x); > >> -extern int __isnand (double x); > >> -extern int __fpclassifyf (float x); > >> -extern int __fpclassifyd (double x); > >> -extern int __signbitf (float x); > >> -extern int __signbitd (double x); > >> +extern int __isinff (float); > >> +extern int __isinfd (double); > >> +extern int __isnanf (float); > >> +extern int __isnand (double); > >> +extern int __fpclassifyf (float); > >> +extern int __fpclassifyd (double); > >> +extern int __signbitf (float); > >> +extern int __signbitd (double); > >> > >> /* Note: isinf and isnan were once functions in newlib that took double > >> * arguments. C99 specifies that these names are reserved for > macros > >> -- > >> 2.7.4 > >> >