From: Jeff Johnston <jjohnstn@redhat.com>
To: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
newlib@sourceware.org
Subject: Re: Various libgloss problems after recent changes
Date: Fri, 10 Feb 2023 12:16:51 -0500 [thread overview]
Message-ID: <CAOox84u8CHh=P0X=WWnHRz2WKTRX5AZiX+X9+R7QYQCcYuMGUQ@mail.gmail.com> (raw)
In-Reply-To: <b808342f-4cc9-8eae-f1ad-423fdfd130f9@foss.arm.com>
[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]
On Fri, Feb 10, 2023 at 6:21 AM Richard Earnshaw <
Richard.Earnshaw@foss.arm.com> wrote:
>
>
> On 09/02/2023 22:54, Jeff Johnston wrote:
> > Hi Jeff,
> >
> > Want to try out the attached patch?
> >
> > -- Jeff J.
> >
> >
> > On Sun, Feb 5, 2023 at 7:48 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> >
> >> The fr30-elf and xstormy16-elf ports have been failing to build for
> >> about a month with this error:
> >>
> >> > fr30-elf-as -I. -I../../../../..//newlib-cygwin/libgloss/fr30/..
> >> -I./.. -idirafter
> >> ../../../../..//newlib-cygwin/libgloss/fr30/../../include -o crt0.o
> >> ../../../../..//newlib-cygwin/libgloss/fr30/crt0.s
> >>> fr30-elf-as: unrecognized option '-idirafter'
> >>
> >>
> >> For a full log:
> >>
> >> http://law-sandy.freeddns.org:8080/job/fr30-elf/1984/console
> >>
> >> Hopefully this is easy to fix so we can get those ports under regular
> >> testing again.
> >>
> >> Jeff
> >>
> >>
>
> I'm slightly confused. Why would some ports have -idirafter and some
> not, unless they're not using GCC (or a very old one).
>
> So wouldn't a autoconf test for -idirafter be a better approach rather
> than hard-coding it.
>
Yes, I should have picked a better flag name - I really just wanted to
exclude the 2 platforms that don't need the -idirafter statement in the
first place.
A better way would be to simply add a flag to indicate specifically that a
config wants to include files in top level include.
> Note that if it's due to the option not being supported in old versions
> of gcc, then that's a bigger problem because the reason the option was
> added in the first place (IIRC) was to support moving arm-acle-compat.h
> out of the newlib subdir so it could be used with libgloss. And
> arm-acle-compat.h is there to support older versions of GCC.
>
> And that brings up another question. Just how old a version of GCC do
> we want to support these days? ACLE support was added to GCC 10 years
> ago, in GCC-4.8. If we can drop support for compilers older than that,
> we can drop using the compatibility header and get rid of the need for
> -idirafter entirely.
>
> R.
>
>
next prev parent reply other threads:[~2023-02-10 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 0:48 Jeff Law
2023-02-09 22:54 ` Jeff Johnston
2023-02-10 11:21 ` Richard Earnshaw
2023-02-10 16:54 ` Jeff Law
2023-02-21 21:39 ` Jeff Johnston
2023-02-22 7:16 ` Jeff Law
2023-02-22 16:20 ` Jeff Johnston
2023-02-22 16:40 ` Jeff Law
2023-02-22 17:54 ` Jeff Law
2023-02-22 18:06 ` Jeff Johnston
2023-02-10 17:16 ` Jeff Johnston [this message]
2023-12-04 6:49 ` Mike Frysinger
2023-02-10 16:52 ` Jeff Law
2023-12-04 7:03 ` [PATCH 1/2] Revert "Fix libgloss/newlib build to conditionally use top include dir" Mike Frysinger
2023-12-04 7:03 ` [PATCH 2/2] libgloss: drop $(INCLUDES) when using $(AS) Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84u8CHh=P0X=WWnHRz2WKTRX5AZiX+X9+R7QYQCcYuMGUQ@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=jeffreyalaw@gmail.com \
--cc=newlib@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).