From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B18C1385483F for ; Fri, 10 Feb 2023 17:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B18C1385483F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676049424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fsEuZhtEnwJVkXn+BzP0qa6X4klRf/5oil1zM76kNRo=; b=IS6LUEFO4H3NmAeSELjiJ2OwlHNBTzWP6RBLEmTlJMgxpYrN4ZNtAilpooOBVS+TjpdSFv LSjYFjftYMxPg1KXpzXnheWNkPUQw5R+LMRmlCILlv6tU5v03FOAcSTXcmHNsPeqNO/RhG uBm4tyIYvS667SxP3KgmeKSy7p6hMZ0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-340-lz4FgdLUOpK3ksjurFl6dg-1; Fri, 10 Feb 2023 12:17:03 -0500 X-MC-Unique: lz4FgdLUOpK3ksjurFl6dg-1 Received: by mail-qv1-f72.google.com with SMTP id c10-20020a05621401ea00b004c72d0e92bcso3459814qvu.12 for ; Fri, 10 Feb 2023 09:17:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fsEuZhtEnwJVkXn+BzP0qa6X4klRf/5oil1zM76kNRo=; b=Fb45bIWglZ/LP3IjjJwVMEVykhbRwaIHTI8ImvOKObAOlsluRTI6JuePGUwNEzG1IG /qLN+43s2SlcaRvyo1YlvO0kDGoOPvnMSE6weYhO/ZCuMCx3nLC/V3bkecRBUhh2frha 1ujF/CNApL+Lg0tBEqTNClCjOAKJVWmJUAKW5hTbkHZ0AI7bbO6TGmslFulIZE/Nh0aE 5NkQgJSRyb9Qh1Isx5JzKMbOnK7xceygZYCqOijMwpigGh+kgRyBFvuKeINa7H+CcK/x HC/HGo9kbPRrJMBRkkig2Zg8WdrRAUTJhjztgOYn7LZ6t4Yexrt9vthWl9j1Idi21zVT 6VqA== X-Gm-Message-State: AO0yUKVge/ik6SZcMvGyjfVPxlodSFDU2anFhoqEFfEYX0TLdz8Dv3Xt MC9lYKHYzy9cvEvi0DZ+xBjNQBIT3Cz3lJFMhuvEWNkxYM/2YsOX8yp8usZ2DQfq+2wljaJGX4J KtmG6bWx0bjjyRZLm2vvsUO+PMDj1u65XGedY X-Received: by 2002:ac8:5a4f:0:b0:3b8:6ca8:77a6 with SMTP id o15-20020ac85a4f000000b003b86ca877a6mr3025401qta.123.1676049422598; Fri, 10 Feb 2023 09:17:02 -0800 (PST) X-Google-Smtp-Source: AK7set98q6nb2v+BOeu1eNTkS36CKI6RIyPqv560WoRULMBHNj7TbK+88c43SJsXyN4IQUM6sMMNW7gF6HUiNdLfYQA= X-Received: by 2002:ac8:5a4f:0:b0:3b8:6ca8:77a6 with SMTP id o15-20020ac85a4f000000b003b86ca877a6mr3025391qta.123.1676049422343; Fri, 10 Feb 2023 09:17:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Johnston Date: Fri, 10 Feb 2023 12:16:51 -0500 Message-ID: Subject: Re: Various libgloss problems after recent changes To: Richard Earnshaw Cc: Jeff Law , Mike Frysinger , newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000071f84905f45baa97" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000071f84905f45baa97 Content-Type: text/plain; charset="UTF-8" On Fri, Feb 10, 2023 at 6:21 AM Richard Earnshaw < Richard.Earnshaw@foss.arm.com> wrote: > > > On 09/02/2023 22:54, Jeff Johnston wrote: > > Hi Jeff, > > > > Want to try out the attached patch? > > > > -- Jeff J. > > > > > > On Sun, Feb 5, 2023 at 7:48 PM Jeff Law wrote: > > > >> The fr30-elf and xstormy16-elf ports have been failing to build for > >> about a month with this error: > >> > >> > fr30-elf-as -I. -I../../../../..//newlib-cygwin/libgloss/fr30/.. > >> -I./.. -idirafter > >> ../../../../..//newlib-cygwin/libgloss/fr30/../../include -o crt0.o > >> ../../../../..//newlib-cygwin/libgloss/fr30/crt0.s > >>> fr30-elf-as: unrecognized option '-idirafter' > >> > >> > >> For a full log: > >> > >> http://law-sandy.freeddns.org:8080/job/fr30-elf/1984/console > >> > >> Hopefully this is easy to fix so we can get those ports under regular > >> testing again. > >> > >> Jeff > >> > >> > > I'm slightly confused. Why would some ports have -idirafter and some > not, unless they're not using GCC (or a very old one). > > So wouldn't a autoconf test for -idirafter be a better approach rather > than hard-coding it. > Yes, I should have picked a better flag name - I really just wanted to exclude the 2 platforms that don't need the -idirafter statement in the first place. A better way would be to simply add a flag to indicate specifically that a config wants to include files in top level include. > Note that if it's due to the option not being supported in old versions > of gcc, then that's a bigger problem because the reason the option was > added in the first place (IIRC) was to support moving arm-acle-compat.h > out of the newlib subdir so it could be used with libgloss. And > arm-acle-compat.h is there to support older versions of GCC. > > And that brings up another question. Just how old a version of GCC do > we want to support these days? ACLE support was added to GCC 10 years > ago, in GCC-4.8. If we can drop support for compilers older than that, > we can drop using the compatibility header and get rid of the need for > -idirafter entirely. > > R. > > --00000000000071f84905f45baa97--