From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3ED3C385780B for ; Tue, 22 Sep 2020 22:07:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3ED3C385780B Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-L8ln38kvPyChzxMNEdpe5A-1; Tue, 22 Sep 2020 18:07:38 -0400 X-MC-Unique: L8ln38kvPyChzxMNEdpe5A-1 Received: by mail-pl1-f200.google.com with SMTP id u11so5858621pls.16 for ; Tue, 22 Sep 2020 15:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qDZ8gEUZNzPpnokrS6MHjxIgMJWfRNi+i6t6RDb4J7w=; b=ieLij1oqw3pV9mZZbudA3iteH4L/rBK43S06u+PhMLTHboVraULuZLtHXhkrzXGvbq qQgVSikfMdo5c+1ovoM19bcopzRBPECqoP7EqJWRYcRaoAlNdCXIjYAPb4ioWVwvc+eW P8jGgsMx8SDTm6K1CDE8qtIuJWTe5J7kkdPW7U4wySwDkP3MOwCA+RNWA39xnv2QUN4T LyvDStqHV8RU9OkCK5RygVFMsu7haovwg4Njr8RJJmKl/qEECBILWbVTIjx7iQqjuQia 29F6MfTSeXivqEtx1txOkH8dWfDFzPqSfrlKqkDzNjkH2/Gdep+J4yATFybngbKBZBLa bxIA== X-Gm-Message-State: AOAM532+fQxg2Cs4z4aX8MMk1lPHByDeCu2dSUwDgRN1U0pTA79iDfd1 Bicwmr0IzbkjXmHh65apfyTXhtZheeJNTLLscrYQqkYlgfeHCSAdtV6glN6vOLNnJDQgI6TeuHN PxHcMeur8s3Wxd0Lquymo7dh/HlprYNc= X-Received: by 2002:a17:902:d354:b029:d1:e5e7:bdd3 with SMTP id l20-20020a170902d354b02900d1e5e7bdd3mr6415935plk.51.1600812457054; Tue, 22 Sep 2020 15:07:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAoBsUI69I3P6FsiAogm8J6YYa/aH2Nu5dJvaeU3+o+GXwzykLLuDlINA5bInZ4XtDFo7ZizTRjYpZ3bzbcRo= X-Received: by 2002:a17:902:d354:b029:d1:e5e7:bdd3 with SMTP id l20-20020a170902d354b02900d1e5e7bdd3mr6415917plk.51.1600812456789; Tue, 22 Sep 2020 15:07:36 -0700 (PDT) MIME-Version: 1.0 References: <1600702161-13623-1-git-send-email-christophe.lyon@linaro.org> In-Reply-To: <1600702161-13623-1-git-send-email-christophe.lyon@linaro.org> From: Jeff Johnston Date: Tue, 22 Sep 2020 18:07:25 -0400 Message-ID: Subject: Re: [PATCH] libc/include/math.h: Remove parameter name To: Christophe Lyon Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 22:07:45 -0000 Hi Christophe, Can you please resend the patch as an attachment? Thanks, -- Jeff J. On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib < newlib@sourceware.org> wrote: > As discussed in GCC bug 97088 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in > prototypes of library functions should use reserved names, or no name > at all. > > This patch removes the 'x' parameter name from > extern int __isinff (float); > extern int __isinfd (double); > extern int __isnanf (float); > extern int __isnand (double); > extern int __fpclassifyf (float); > extern int __fpclassifyd (double); > extern int __signbitf (float); > extern int __signbitd (double); > > to avoid possible clashes with user code in case someone uses > before including Newlib's math.h (or uses some other conflicting > definition) > --- > newlib/libc/include/math.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h > index 5e6155c..ba1a8a1 100644 > --- a/newlib/libc/include/math.h > +++ b/newlib/libc/include/math.h > @@ -201,14 +201,14 @@ extern int isnan (double); > # define math_errhandling (_MATH_ERRHANDLING_ERRNO | > _MATH_ERRHANDLING_ERREXCEPT) > #endif > > -extern int __isinff (float x); > -extern int __isinfd (double x); > -extern int __isnanf (float x); > -extern int __isnand (double x); > -extern int __fpclassifyf (float x); > -extern int __fpclassifyd (double x); > -extern int __signbitf (float x); > -extern int __signbitd (double x); > +extern int __isinff (float); > +extern int __isinfd (double); > +extern int __isnanf (float); > +extern int __isnand (double); > +extern int __fpclassifyf (float); > +extern int __fpclassifyd (double); > +extern int __signbitf (float); > +extern int __signbitd (double); > > /* Note: isinf and isnan were once functions in newlib that took double > * arguments. C99 specifies that these names are reserved for > macros > -- > 2.7.4 > >