From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id D50A23890405 for ; Thu, 17 Dec 2020 21:28:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D50A23890405 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-vkwbTHvQNU6RK9oDQN9l7Q-1; Thu, 17 Dec 2020 16:28:24 -0500 X-MC-Unique: vkwbTHvQNU6RK9oDQN9l7Q-1 Received: by mail-pl1-f200.google.com with SMTP id q12so158952plr.9 for ; Thu, 17 Dec 2020 13:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1KqM8YUg/WeopRyN/bdb0I8dGDzUFveq4LEp/hya4HA=; b=ag4X7Ca09bnnJoBbTQEnz1nmx8iYZWDTJFFfq+7vOOsfLg19JH+9HHJkutuvi4NmDX KA2RsKhaE/87cZyoXjGYlqTGfBjYJ9yIrNcBCeuA3wbf46umGX74mrBMnl0ZBqYgS0oY faNe4VVIPgY3lhqP2IYsfYfi/0DgghqMTZr+M7j/bt38LcVo+NRm+9y5g8+1pSc03ltL EmGThmIzOYPf4DySdC2nyowvN6J1sTT9WLyYrMKBOqwuID0yJiIZsjP4dNixmj/Y7J9U U1HpuudKt6V8Km1Ia9WRjCU2hm2HYtdkH0FKrMnKGhrtUy6GWE+aGfO9559dolQpsang 6yOw== X-Gm-Message-State: AOAM532XdC9iDe06kgC2rdZGHSeBJDCH+eXG5n3XVh3UbGtc8MN2sikE dwVpYY8O6/8Ggfaa36VUpcHuRAbWDe4vd30fMQP0Ghsrw8vBxsWVM/aKbgPrnjV2vjmybbg00/z Z4T/4/Esp12hDgin2KTT0ocktroagOUs= X-Received: by 2002:a05:6a00:795:b029:19e:28de:e92a with SMTP id g21-20020a056a000795b029019e28dee92amr1160531pfu.36.1608240503327; Thu, 17 Dec 2020 13:28:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3zzH+0apBSDsBTPA2fYw2c1WUGLLn6+HQGwP8dIWwnmTsGelJn+MKmCoOQjVLiJx3uRdj1oDphw25cX1i7Ow= X-Received: by 2002:a05:6a00:795:b029:19e:28de:e92a with SMTP id g21-20020a056a000795b029019e28dee92amr1160516pfu.36.1608240503126; Thu, 17 Dec 2020 13:28:23 -0800 (PST) MIME-Version: 1.0 References: <871rfo76mw.fsf@keithp.com> <87v9d05jkl.fsf@keithp.com> In-Reply-To: <87v9d05jkl.fsf@keithp.com> From: Jeff Johnston Date: Thu, 17 Dec 2020 16:28:12 -0500 Message-ID: Subject: Re: regression in tgamma? To: Keith Packard Cc: Paul Zimmermann , Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 21:28:29 -0000 Thanks Keith, I have modified er_lgamma.c, erf_lgamma.c, w_tgamma.c, wf_tgamma.c based on code changes in picolibc. I did not add the new ___ieee754_ sub-functions and instead modified the existing code assuming that the function was called with *signgam = 0. We can always do a merge from picolibc in the future. With the new code, the test runs as expected. Paul, please confirm before tomorrow. Thanks, -- Jeff J. On Thu, Dec 17, 2020 at 2:17 PM Keith Packard wrote: > Jeff Johnston writes: > > > I am also seeing inf instead of -inf for both tgamma and tgammaf in my > > testing. > > Yeah, looks like there are quite a few fixes in picolibc that I haven't > had time to send over to newlib. > > I've also fixed a bunch of exception problems when compiling with clang, > which is happy to evaluate expressions known at compile time, even > though that doesn't generate exceptions at runtime. (things like 'return > one/zero;') > > I've also generated tests for return values, exceptions and errnos for > the math functions to make sure they match the relevant specs and also > match glibc (mostly as a way to check the tests). > > Anyone is welcome to pull those fixes out of picolibc and get them into > newlib; I probably won't have time for a while. > > -- > -keith >