From: Jeff Johnston <jjohnstn@redhat.com>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: incorrectly rounded square root
Date: Mon, 31 May 2021 16:52:15 -0400 [thread overview]
Message-ID: <CAOox84uTC=ZWnvepSNzhPjxVTHJcO+dKuZxUYPPUgoqinbq4Xw@mail.gmail.com> (raw)
In-Reply-To: <mwfsz29azt.fsf@tomate.loria.fr>
Hi Paul,
Not all platforms supply a machine implementation of fesetround. Which
platform are you using?
-- Jeff J.
On Tue, May 4, 2021 at 4:09 AM Paul Zimmermann <Paul.Zimmermann@inria.fr>
wrote:
> Hi,
>
> according to IEEE 754, the square root function should be correctly rounded
> for all rounding modes. I noticed this is not the case in Newlib:
>
> $ cat test_sqrt.c
> #include <stdio.h>
> #include <math.h>
> #include <fenv.h>
>
> #ifdef NEWLIB
> int errno;
> int* __errno () { return &errno; }
> #endif
>
> int main()
> {
> int rnd[4] = { FE_TONEAREST, FE_TOWARDZERO, FE_UPWARD, FE_DOWNWARD };
> char Rnd[4] = "NZUD";
> float x = 0x1.ff07fep+127f;
> float y;
> for (int i = 0; i < 4; i++)
> {
> fesetround (rnd[i]);
> y = sqrtf (x);
> printf ("RND%c: %a\n", Rnd[i], y);
> }
> }
>
> $ gcc -DNEWLIB -fno-builtin test_sqrt.c
> /localdisk/zimmerma/newlib-4.1.0/libm.a -lm
> $ ./a.out
> RNDN: 0x1.ff83fp+63
> RNDZ: 0x1.ff83fp+63
> RNDU: 0x1.ff83fp+63
> RNDD: 0x1.ff83fp+63
>
> The RNDZ and RNDD results are wrong. With glibc I get:
>
> $ gcc -fno-builtin test_sqrt.c -lm
> $ ./a.out
> RNDN: 0x1.ff83fp+63
> RNDZ: 0x1.ff83eep+63
> RNDU: 0x1.ff83fp+63
> RNDD: 0x1.ff83eep+63
>
> Best regards,
> Paul Zimmermann
>
>
next prev parent reply other threads:[~2021-05-31 20:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 8:08 Paul Zimmermann
2021-05-31 20:52 ` Jeff Johnston [this message]
2021-06-01 7:11 ` Paul Zimmermann
2021-06-01 16:28 ` Jeff Johnston
2021-06-02 7:51 ` Paul Zimmermann
2021-06-02 13:07 ` Joel Sherrill
2021-06-02 18:43 ` Jeff Johnston
2021-06-02 19:07 ` Marco Atzeri
2021-06-02 19:12 ` Joel Sherrill
2021-06-03 3:01 ` Jeff Johnston
2021-06-03 10:21 ` Paul Zimmermann
2021-06-03 15:50 ` Jeff Johnston
2021-06-04 7:14 ` Paul Zimmermann
2021-06-04 18:44 ` Jeff Johnston
2021-06-04 18:59 ` Joel Sherrill
2021-06-05 13:25 ` Brian Inglis
2021-06-07 9:51 ` Paul Zimmermann
2021-06-12 22:31 ` Maciej W. Rozycki
2021-06-03 11:25 ` Paul Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84uTC=ZWnvepSNzhPjxVTHJcO+dKuZxUYPPUgoqinbq4Xw@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=Paul.Zimmermann@inria.fr \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).