From: Jeff Johnston <jjohnstn@redhat.com>
To: Jordi Sanfeliu <jordi@fibranet.cat>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty
Date: Tue, 18 Jul 2023 13:44:33 -0400 [thread overview]
Message-ID: <CAOox84uUgb+4L2v+ufe8Rsk_qDeVzEr_8=CoFW1L4ooPmXUM4w@mail.gmail.com> (raw)
In-Reply-To: <ef655547-bc0e-d569-eb32-905f8b433c8f@fibranet.cat>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Yes, sorry. Your patch didn't apply so I quickly manually changed it and
messed it up.
Fix applied.
-- Jeff J.
On Tue, Jul 18, 2023 at 3:08 AM Jordi Sanfeliu <jordi@fibranet.cat> wrote:
> Hello Jeff,
>
> I'm reviewing the patch you applied to getlogin.c and it seems to me
> that there is an extra opening parenthesis.
>
> You forgot the diff line:
>
> + if ((tty = ttyname (0)) == 0)
>
> Can you confirm it?
>
> Regards.
>
>
>
> On 7/17/23 21:06, Jeff Johnston wrote:
> > Original patch pushed, thanks.
> >
> > -- Jeff J.
> >
>
> --
> Jordi Sanfeliu
> FIBRANET Network Services Provider
> https://www.fibranet.cat
>
>
next prev parent reply other threads:[~2023-07-18 17:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 17:33 Jordi Sanfeliu
2023-07-12 18:50 ` Torbjorn SVENSSON
2023-07-12 20:06 ` Brian Inglis
2023-07-13 16:26 ` Torbjorn SVENSSON
2023-07-13 8:06 ` Jordi Sanfeliu
2023-07-13 16:25 ` Torbjorn SVENSSON
2023-07-13 16:57 ` Jordi Sanfeliu
2023-07-13 19:01 ` Jeff Johnston
2023-07-17 7:54 ` Corinna Vinschen
2023-07-13 21:12 ` Stefan Tauner
2023-07-17 19:06 ` Jeff Johnston
2023-07-18 5:57 ` Jordi Sanfeliu
2023-07-18 7:08 ` Jordi Sanfeliu
2023-07-18 17:44 ` Jeff Johnston [this message]
2023-07-18 18:59 ` Jordi Sanfeliu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84uUgb+4L2v+ufe8Rsk_qDeVzEr_8=CoFW1L4ooPmXUM4w@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=jordi@fibranet.cat \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).