From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9B46A38582AC for ; Tue, 18 Jul 2023 17:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B46A38582AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689702287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R7kDds1oUwtdMjnBbKXBAEXyWoe/cZdzQVyiwWekFLs=; b=LITLcmCgNesBa9eA698KwnY2EVE10z0P6+wTce2XXz4KfJax53DaS/8UKMxEC+sp5fot8p KTtGUXEs6YHdB5Ddy8v3mATPOqxA1c/nWfnuC8/04mmrw0RP+Kq0FkZLi/F1jTU+FCCehO f8WjfP08GNTHhczJrLQEWfovmNuSssE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-TjEQsnPxOrW2mzk-UCrV6Q-1; Tue, 18 Jul 2023 13:44:45 -0400 X-MC-Unique: TjEQsnPxOrW2mzk-UCrV6Q-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-401e1fc831fso10927431cf.1 for ; Tue, 18 Jul 2023 10:44:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689702285; x=1692294285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R7kDds1oUwtdMjnBbKXBAEXyWoe/cZdzQVyiwWekFLs=; b=DdPf3jfyWeLb9SsJODm6XTM8YYR7tlhZ6c0EIssASweaPfLI05sHLBFuqq/THrEpBh Ly/r/1+ccdJl4AavRHDUM26alogdp8HgbAgPonQ/HW21fYzglE8OVIYDzTUUudDWOqQV xiLLG9lE+lhuPFKyCUlZbd8GmgEXKhsPebGY57xontAnletIzJtsXWWuhYC5EAU2nllL vc9zWQ79BlO8u0TFT2cQiL4x0joXa9xXnIjd1ZWTwWV7JwMo1SqXuaAC7pGgfC+jLi/C xpJnVqitb5E9kuI7MSi7QlqFap6hPTlQzTzoMkJo7xuok6A+sIbAiEH0VKWBRyfBEdWz l1ng== X-Gm-Message-State: ABy/qLYYv86/BcqKTTaPwfoLhn4BuWb2m/4S4i8OyBongOp+UfNx8J3V MThD/z4CFbApwRYWoT+/sow1sKI9/H2R8Ygo0XEGnVERCK6X1rF8BGwkpzOkIzSrecHcRSEL6PO GXoqJHsa+oMgNfFDCYLPcZTEQ9Ma9mhm9lmYN394= X-Received: by 2002:ac8:570d:0:b0:403:aac6:7a1d with SMTP id 13-20020ac8570d000000b00403aac67a1dmr301279qtw.3.1689702285070; Tue, 18 Jul 2023 10:44:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEfS0/g10h5qz+sb2WMlt4iVNeB6JbtgZo5CI9Ox3dcx1ExjLadr+N7uoYgApdm2IAxHRpQbZyKm+MKLC418GU= X-Received: by 2002:ac8:570d:0:b0:403:aac6:7a1d with SMTP id 13-20020ac8570d000000b00403aac67a1dmr301267qtw.3.1689702284797; Tue, 18 Jul 2023 10:44:44 -0700 (PDT) MIME-Version: 1.0 References: <1de3b3ee-7dd8-db16-6e17-365dbd9fde84@fibranet.cat> In-Reply-To: From: Jeff Johnston Date: Tue, 18 Jul 2023 13:44:33 -0400 Message-ID: Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty To: Jordi Sanfeliu Cc: newlib@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000007643a70600c67859" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007643a70600c67859 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, sorry. Your patch didn't apply so I quickly manually changed it and messed it up. Fix applied. -- Jeff J. On Tue, Jul 18, 2023 at 3:08=E2=80=AFAM Jordi Sanfeliu = wrote: > Hello Jeff, > > I'm reviewing the patch you applied to getlogin.c and it seems to me > that there is an extra opening parenthesis. > > You forgot the diff line: > > + if ((tty =3D ttyname (0)) =3D=3D 0) > > Can you confirm it? > > Regards. > > > > On 7/17/23 21:06, Jeff Johnston wrote: > > Original patch pushed, thanks. > > > > -- Jeff J. > > > > -- > Jordi Sanfeliu > FIBRANET Network Services Provider > https://www.fibranet.cat > > --0000000000007643a70600c67859--