Hi Neal,

It looks like this got missed during the holiday season.

When you patch configure.ac, you need to regenerate configure (not directly
edit it).  You can either run autoconf or autoreconf which will need
autoconf 2.69 installed on your system.  When you submit a patch, you don't
submit the generated files such as configure, but you will need to
regenerate it to test your changes locally.  Thus, your patch should have
the changes needed to configure.ac but not configure   The configure file
will get regenerated for the repo by whoever reviews, approves, and merges
the patch.

-- Jeff J.


On Fri, Dec 15, 2023 at 7:08 AM Frager, Neal <neal.frager@amd.com> wrote:

> Hi Thomas,
>
> > This patch is required to fix how the newlib headers are installed
> > when using a sysroot install directory.
> >
> > The cross compiler expects headers to be in
> > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
> > by default newlib installed the headers into
> > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h
> >
> > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
> > ${target_noncanonical} provides an extra arm-none-eabi/ that must be
> removed.
> >
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
> > Co-developed-by: Chris Wardman <cjwfirmware@vxmdesign.com>
> > ---
> >  configure | 7 +++++++
> >  1 file changed, 7 insertions(+)
>
> > The configure script is generated from configure.ac, so you should not
> > patch configure but configure.ac.
>
> When building newlib, I am not seeing the configure script get
> generated.  If I only patch configure.ac, the configure script stays
> the same and my patch appears ignored.
>
> Do you know what I could be missing?
>
> > +  --with-install-sysroot  use sysroot install directory
> >    --with-debug-prefix-map='A=B C=D ...'
> >                            map A to B, C to D ... in debug information
> >    --with-build-config='NAME NAME2...'
> > @@ -7057,7 +7059,12 @@ esac
> >
> >  # Some systems (e.g., one of the i386-aix systems the gas testers are
> >  # using) don't handle "\$" correctly, so don't use it here.
> > +# Check whether --with-install-sysroot was given.
> > +if test "${with_install_sysroot+set}" = set; then :
>
> > --with/--without options are usually not used for boolean things,
> > instead --enable/--disable option are used for boolean things.
>
> > However here, I think that what would make sense is a --with-tooldir
> > option. When not passed, the value is
> > '${exec_prefix}'/${target_noncanonical}, and when passed, the value is
> > the one passed in the option:
>
> > ./configure ... --with-tooldir=/blabla
>
> I made this correction, and the --with-tooldir option only works
> if I patch it directly into the configure script.
>
> Could you help me figure out what is missing?
>
> Best regards,
> Neal Frager
> AMD
>
>