From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 74F283858D38 for ; Wed, 3 Jan 2024 22:43:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74F283858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74F283858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704321813; cv=none; b=qzTcYtZSJ0mnQ7oLgs+MzDfqoBIDgUCR8NyVO9uqyufYy6iiO5VcrGyd/CoNH0IUbxEGkKs/wY/6EuuIYkll9gETPojv5NjFpNs4/NPUPBAAFsCpJRlY1gxsl3sgWYiMIZk0adS7J+EyCVXuVe/goZV6W0gnglBuITvLz7kfAUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704321813; c=relaxed/simple; bh=3bLEtbXy+y+oLpjSn1eklNPPzdSwZRdu5S/KiENjTD0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ruVi8n3YknNfESeg+5Lv06yMM4dirFyNXiV+NtADWPcP7UxnRALfzkSE/cG2f5qDkKIeKQI9ukZLtea4C51hJ39MGBWb9QPeACOOSOPBGvz56DuKElpO/cmK/eT62+oXwS+amGXBC4JiDKVMz6+My1Qa8+PKlNz+8SpNywb0FBQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704321811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MS6HMmKRq51j2VyFGuqxucnmsXqyrK+Dnp7zBMUA3qA=; b=iF02hXBYO6hVIl9RqgKPgM/fcCZHG7yZMiJRAJF7w8vpcQNsvl7cSh5y+gsdbgypE4wbco 5QLUuHwyiNXtDhD81VpH+TroSUAmIIvWP4v9kjnDfEKXByUemnEwFEIJ7EVGvCqj9iSXtq Sqf5KUYqoBIdaZvmovyoe+53zFwIq9U= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-jNXgtF_fOJ6j2EBlXe79WA-1; Wed, 03 Jan 2024 17:43:24 -0500 X-MC-Unique: jNXgtF_fOJ6j2EBlXe79WA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2cd08f0bfb3so5312001fa.1 for ; Wed, 03 Jan 2024 14:43:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704321803; x=1704926603; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MS6HMmKRq51j2VyFGuqxucnmsXqyrK+Dnp7zBMUA3qA=; b=lAWXZtEy/nY9YIhohZUw0cS8PgTJLv8DhdryZaNtudZBcCkhqtcKtCR+Aou55tYEcM QCHCTHLQ/h3lqWzpbDXuH5PIf4gexyi3udmhncych+84oC5RFqOy/jmLIgCmcJOLnU6F 6e2XjM9311azdPnv6YiwFU5HB6AXz/+PKG3qYaAZaXx8CWwaWD2wM21EUjrkouK3U1DG 8kP0uRZq9opwCDeO21bh8gGh1DYR3nyWKfdyRDv/Ls9cu0rtrqW9KVelqVK2FS81A4/g PeaJm1lH57+0F+DW0ujP+NyjjOfIfXzStw6GYQTezqI18NB6RtY5BQUnGPJ5PSK3GXUC tzsg== X-Gm-Message-State: AOJu0YyGlgaTEvzKbVAQk4+N8lT2M2fnozxKGp+4dYhCXPoogVwppLY9 KrCx8v3n9PxS0thJQjlPFK30hmiZQvJwvEHEixfEjmueWyxRkbcwCYaLqKzyGb4l5dGFJvNu3+9 vd5ivrEdDjIbFTpmyh9IjzIOKLcIXAFCFU37WVV0= X-Received: by 2002:a05:651c:19a5:b0:2cc:d4d9:90f with SMTP id bx37-20020a05651c19a500b002ccd4d9090fmr14549162ljb.0.1704321802868; Wed, 03 Jan 2024 14:43:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmfmfQAUAiYszM3bLUWoc6pEAcyn2TS0vrgmGdv5ROPsfhDGNVxV56Kfv9eha8XKQzhT0xlPk/yVKy4o5zBuE= X-Received: by 2002:a05:651c:19a5:b0:2cc:d4d9:90f with SMTP id bx37-20020a05651c19a500b002ccd4d9090fmr14549155ljb.0.1704321802461; Wed, 03 Jan 2024 14:43:22 -0800 (PST) MIME-Version: 1.0 References: <20231215095529.739093-1-neal.frager@amd.com> <20231215113332.4a0fd114@windsurf> In-Reply-To: From: Jeff Johnston Date: Wed, 3 Jan 2024 17:43:10 -0500 Message-ID: Subject: Re: [PATCH v1 1/1] configure: correct tooldir install path To: "Frager, Neal" Cc: Thomas Petazzoni , "newlib@sourceware.org" , "cjwfirmware@vxmdesign.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009e7e9b060e1257a5" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000009e7e9b060e1257a5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Neal, It looks like this got missed during the holiday season. When you patch configure.ac, you need to regenerate configure (not directly edit it). You can either run autoconf or autoreconf which will need autoconf 2.69 installed on your system. When you submit a patch, you don't submit the generated files such as configure, but you will need to regenerate it to test your changes locally. Thus, your patch should have the changes needed to configure.ac but not configure The configure file will get regenerated for the repo by whoever reviews, approves, and merges the patch. -- Jeff J. On Fri, Dec 15, 2023 at 7:08=E2=80=AFAM Frager, Neal = wrote: > Hi Thomas, > > > This patch is required to fix how the newlib headers are installed > > when using a sysroot install directory. > > > > The cross compiler expects headers to be in > > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > > by default newlib installed the headers into > > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h > > > > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > > ${target_noncanonical} provides an extra arm-none-eabi/ that must be > removed. > > > > Signed-off-by: Neal Frager > > Co-developed-by: Chris Wardman > > --- > > configure | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > The configure script is generated from configure.ac, so you should not > > patch configure but configure.ac. > > When building newlib, I am not seeing the configure script get > generated. If I only patch configure.ac, the configure script stays > the same and my patch appears ignored. > > Do you know what I could be missing? > > > + --with-install-sysroot use sysroot install directory > > --with-debug-prefix-map=3D'A=3DB C=3DD ...' > > map A to B, C to D ... in debug information > > --with-build-config=3D'NAME NAME2...' > > @@ -7057,7 +7059,12 @@ esac > > > > # Some systems (e.g., one of the i386-aix systems the gas testers are > > # using) don't handle "\$" correctly, so don't use it here. > > +# Check whether --with-install-sysroot was given. > > +if test "${with_install_sysroot+set}" =3D set; then : > > > --with/--without options are usually not used for boolean things, > > instead --enable/--disable option are used for boolean things. > > > However here, I think that what would make sense is a --with-tooldir > > option. When not passed, the value is > > '${exec_prefix}'/${target_noncanonical}, and when passed, the value is > > the one passed in the option: > > > ./configure ... --with-tooldir=3D/blabla > > I made this correction, and the --with-tooldir option only works > if I patch it directly into the configure script. > > Could you help me figure out what is missing? > > Best regards, > Neal Frager > AMD > > --0000000000009e7e9b060e1257a5--