From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3D6E43858C54 for ; Mon, 11 Apr 2022 16:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D6E43858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649692904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bC8KC70OtY1nd7KaSgCj83PQ3elZZav+8Gm5q18TuBI=; b=Uj8eoyo+64UItUjqc4CQPQwXpg2pyl/S2gS8NyVBLvIbvy1ugkOCcJFSu5uQuHx8KjTO3T amU9MhoGvXt9CDXYxvubcOalfQk/VmkC7My/HwHBxWvWHYFuK9Q4BzRBYlGZ34t+QI1aND If0nXrbhutBF6hv4rs3K8uJ4qacQApw= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-wmjH4OotMvGSDq4govHZhg-1; Mon, 11 Apr 2022 12:01:36 -0400 X-MC-Unique: wmjH4OotMvGSDq4govHZhg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-2ec44c52e7fso14639977b3.3 for ; Mon, 11 Apr 2022 09:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bC8KC70OtY1nd7KaSgCj83PQ3elZZav+8Gm5q18TuBI=; b=DswUIU9wcfr6nOBHqzehm3fVC1Kz3/ViPkpVjP6E2QqwBPce9O06Z5vMc73B2204h3 sOqkFgK4wcpYTY804pttM8Q+MyFum4SMXtstnioZA/ZROBjSbi9Sz5gK6ZZIhLzwuOSw ettWma/eaAlbE12ADVHqYwkqGU73COXPK3sPOc885Ofxbrb+kU2TPlwueN6N6en/kKq2 nXNuBMApNg1gP57IezpnlX5qWFG8Q7PvFk1IcseLqg8t2Nl6Thef0wOrnanVIpDlAhGJ k/AW0C4Lza2C+20b8DGj7iwdHg1s4XESAZ2/DaWuzdz22evd76RPl+ENZsyvPpDT+HIq 4Jew== X-Gm-Message-State: AOAM530e/jPF1g/8sqbC78/0uvpIVFhYGeETR7sNZcZWOrCMopNN+hJ8 mQhDM7S88Jx9AB3fIOyOVL+fDGqEYNygUrmLolLf960bIlHZ7MS6ZBEITajJU9/1eyZqmIXUlkr mr0NXxXPrDay5NbqkdupwW+DrF7J/wbY= X-Received: by 2002:a05:6902:13c2:b0:641:b6d:a151 with SMTP id y2-20020a05690213c200b006410b6da151mr10135418ybu.348.1649692895365; Mon, 11 Apr 2022 09:01:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycieoPLDnfDzBMsDqN2SfrJA5Ky1yFUUYGoIPWKZeeqGUNJ3EoB7gw+hIscZxJ/eN7EwZhl+Kvm4I2+xn3Lk4= X-Received: by 2002:a05:6902:13c2:b0:641:b6d:a151 with SMTP id y2-20020a05690213c200b006410b6da151mr10135388ybu.348.1649692895013; Mon, 11 Apr 2022 09:01:35 -0700 (PDT) MIME-Version: 1.0 References: <7d0a81fb-4553-a895-1353-97a6af61e6e3@foss.arm.com> In-Reply-To: From: Jeff Johnston Date: Mon, 11 Apr 2022 12:01:23 -0400 Message-ID: Subject: Re: [PATCH V3] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 To: Andrea Corallo Cc: Richard Earnshaw , Torbjorn SVENSSON , "newlib@sourceware.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 16:01:46 -0000 Thanks Andrea. Patch pushed to master. -- Jeff J. On Mon, Apr 11, 2022 at 9:52 AM Andrea Corallo wrote: > Jeff Johnston writes: > > >> On Fri, Apr 8, 2022 at 6:09 AM Richard Earnshaw Richard.Earnshaw@foss.arm.com> wrote: > >> > >> I think the hunks in machine/ieeefp.h warrant a comment as to why we > >> can't rely on __FLT_EVAL_METHOD__. Other than that it LGTM, but you'll > >> need Corinna or Jeff to approve. > > > > R. > > Please add the comment as suggested by Richard and it will be pushed.-- > Jeff J. > > Hi all, > > please find attached the updated version of the patch implementing > Richard's suggestion. > > Best Regards > > Andrea > > PS I've no write access to newlib's repo so feel free to push it if > okay. > >