From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5E5B83858D39 for ; Tue, 7 Feb 2023 21:46:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E5B83858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675806360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IU2qhEt5d/Ju8/fOG3UVdUZosQFvaOkW26BO0LBfouY=; b=ibbq4Zl7gokea3o8Nl4N88EtHOqWtUXJrsmsmUOeI805CecLHyvKvPXo+UFY4s80HzhDL+ 8OHIa7KS5WMq3zxCt79EtOdyuHbbSpmwDIWuRLG+c4wCYKPFw7reWWpQr5zJ4UR8x+J1Te 26Rg5su+jKPN4Hp4IpyyNC3QSywCpEo= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-442-BDIPg80VOOqbKW8JcVdRdw-1; Tue, 07 Feb 2023 16:45:56 -0500 X-MC-Unique: BDIPg80VOOqbKW8JcVdRdw-1 Received: by mail-qk1-f199.google.com with SMTP id h13-20020a05620a244d00b006fb713618b8so10694781qkn.0 for ; Tue, 07 Feb 2023 13:45:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IU2qhEt5d/Ju8/fOG3UVdUZosQFvaOkW26BO0LBfouY=; b=Bh7gInMGIJ9ClkI4NcuoQ5AdpysBZnl5b+Awk1dG+Hil/2SuC7iRTt5h5Z+3Xt8KFo n3RN6f7siBuzdTKTXdWUk/dfnTTS7zsly0SDmKxKtjyIWbNQT/RBEB8lZn0kShjba1CJ MW8zf8WD69KDx6p8hGlU0XC8b1rUXr7MAQx10mDZ0R+dArLi4M85KhO1TV2Y5JT6Cy1U AIeciNpVpSB0RNjBk5uQlq8hxiao91JfYepa8lgvCmVYYl7Wq3eNHNKeW7I/fY9NvlmP yde8BpVwiT7JEPYbtr2iHqbRBMKZ2AdDMKSlHy+lsbAruiqB2IejyKWGVB3CjZshXnYO CDWw== X-Gm-Message-State: AO0yUKU+hMitgTKX/Fa1iFOz0E9xjZPowYELyvhUadiKYP/uTkZmQOw5 qY5vFJRdJ989KduNQRodDSKZ3L/VRjJXg3vfjpLS5tqRoujfjUlugco7j7LkyV9S4cFeelmv9No C/9pPD9XODugyG3aNp8DhzbomO6Dwyn0= X-Received: by 2002:a37:2d82:0:b0:71e:5c64:1036 with SMTP id t124-20020a372d82000000b0071e5c641036mr364679qkh.309.1675806356124; Tue, 07 Feb 2023 13:45:56 -0800 (PST) X-Google-Smtp-Source: AK7set/TXcsrXDKUmwaEMDveJ3UurRYK/N0wdMWmGqnr20db4LOlprnxjRB6lEB1ey8GqHQ7MUZPHhXr/qU5qTvaqoA= X-Received: by 2002:a37:2d82:0:b0:71e:5c64:1036 with SMTP id t124-20020a372d82000000b0071e5c641036mr364672qkh.309.1675806355745; Tue, 07 Feb 2023 13:45:55 -0800 (PST) MIME-Version: 1.0 References: <1b261916-e9f8-b90a-829a-c7b831aaa1cd@arm.com> In-Reply-To: <1b261916-e9f8-b90a-829a-c7b831aaa1cd@arm.com> From: Jeff Johnston Date: Tue, 7 Feb 2023 16:45:44 -0500 Message-ID: Subject: Re: [PATCH] libc: arm: fix setjmp abi non-conformance To: Victor Do Nascimento Cc: Richard Earnshaw , Mike Frysinger , newlib@sourceware.org, richard.earnshaw@arm.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000008c09a205f423126b" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000008c09a205f423126b Content-Type: text/plain; charset="UTF-8" A new snapshot can be made. There is also an issue with -idirafter not being supported by a few platforms. How urgent is this? Can it wait until the other issue is fixed? -- Jeff J. On Tue, Feb 7, 2023 at 10:25 AM Victor Do Nascimento < Victor.DoNascimento@arm.com> wrote: > Dear Richard (now also CCing the mailing list), > > One of the folks over at the Gentoo bug discussion inquired about > getting the patch back-ported to the latest source snapshot (where the > problem originally presented itself), newlib-4.3.0.20230120. > > Is that an option at all? > > Cheers, > Victor > > On 2/3/23 13:09, Richard Earnshaw wrote: > > > > > > On 25/01/2023 13:30, Mike Frysinger wrote: > >> On 13 Dec 2022 14:51, Victor L. Do Nascimento wrote: > >>> As per the arm Procedure Call Standard for the Arm Architecture > >>> section 6.1.2 [1], VFP registers s16-s31 (d8-d15, q4-q7) must be > >>> preserved across subroutine calls. > >>> > >>> The current setjmp/longjmp implementations preserve only the core > >>> registers, with the jump buffer size too small to store the required > >>> co-processor registers. > >>> > >>> In accordance with the C Library ABI for the Arm Architecture > >>> section 6.11 [2], this patch sets _JBTYPE to long long adjusting > >>> _JBLEN to 20. > >>> > >>> It also emits vfp load/store instructions depending on architectural > >>> support, predicated at compile time on ACLE feature-test macros. > >> > >> this breaks building with GCC 11 and older: > >> https://bugs.gentoo.org/891589#c7 > >> > >> i don't think it was intentional that this only work with GCC 12+, or if > >> it was, that we want such requirements. GCC 12 is less than a year old. > >> -mike > > > > This has been fixed with commit c6e601de84ea9f2be2b026c609cc3c1fe82a3103. > > --0000000000008c09a205f423126b--