From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9B300388882E for ; Wed, 30 Mar 2022 20:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B300388882E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648670578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XpIlFPo51ANLqROSeM4uitIBbwa+JI6iouE/EE+ZUyw=; b=FhpRwh/vXUsmFw+ToYWwHkucPiXiOI6K6SjGMQK3KsCpmr+AdHbSsC6Jn993n2VjoFIRP3 Z/HDQ9k7WTPsaGKP/ajRbEZL0vr6wn0UbnxzYPqUbhhGh9CNIyohe2U87dQtujKnBv1tjr xlOtNk50PwUnbUG4AgJGWca9MCUa01M= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-519-YSuFxYdqMVusDZvwAbj0_Q-1; Wed, 30 Mar 2022 16:02:55 -0400 X-MC-Unique: YSuFxYdqMVusDZvwAbj0_Q-1 Received: by mail-yb1-f200.google.com with SMTP id j6-20020a25ec06000000b00633c6f3e072so16351922ybh.12 for ; Wed, 30 Mar 2022 13:02:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XpIlFPo51ANLqROSeM4uitIBbwa+JI6iouE/EE+ZUyw=; b=plxMAS8AC+QB+nULEzz6iu5vO5HAZk3vvCGLj7HKwL7ZXKPXbvi87PTZi211j2fY2H 5ElXtENfyn+ae4XfUZnr0RTDK4Cv2N0CKYB+dFkL37GII6gzFr28f8B2Q0O8OwKutMOb x/gedrjOqZtHaWmBEKAOsMI6VyW+DWULzgnIgZPgCOUeid56yi7JRjcY4ysQCNqX+nr6 bPw3bQPBTjNeme4DVTPA9I9bcwzwhG6Aw0aM351t6sf5LIXQuV/bulMFJm6t7pnct0Sg OlypSy/EwxT1l0D2r80QGa0NAl6TPEMV2W+56lVoVSt3WMXrFLI5Zow60rmZhn28thvC Acxg== X-Gm-Message-State: AOAM533l3FTXvkZ0HcJrXJ5vn5V15u31TSwyE+TJrkIu+6lufMBwY2bU b6giOdZwdE0Apn+ayLIqZxJ+4bd8i2oQ/sIYodszrNjnbOAdfj4TeLBs+U1YsR+sFCuxOvsl6w9 G4xOzCZviBmBkcRe5rJjs+bhPU6gcKlY= X-Received: by 2002:a81:7357:0:b0:2e5:f8d1:eb92 with SMTP id o84-20020a817357000000b002e5f8d1eb92mr1479555ywc.461.1648670574753; Wed, 30 Mar 2022 13:02:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGE62vySclgEmP2kgIX1gtdcjaqL5tZngtfJwbspGMzsnpIgz41g7bfg1Qid5CmCJAbSwh5bKcxRSk0XDqtS0= X-Received: by 2002:a81:7357:0:b0:2e5:f8d1:eb92 with SMTP id o84-20020a817357000000b002e5f8d1eb92mr1479528ywc.461.1648670574498; Wed, 30 Mar 2022 13:02:54 -0700 (PDT) MIME-Version: 1.0 References: <0e04b11a-1b6d-c70a-c0fe-4ece59996461@codesourcery.com> <4c157ae5-3133-88da-7156-0e454e1f6535@codesourcery.com> In-Reply-To: <4c157ae5-3133-88da-7156-0e454e1f6535@codesourcery.com> From: Jeff Johnston Date: Wed, 30 Mar 2022 16:02:43 -0400 Message-ID: Subject: Re: [Patch] (1/n) newlib: Only call _fputwc_r if ELIX_LEVEL >= 4 (was: Build-dependency issues with ELIX_LEVEL) To: Tobias Burnus Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 20:03:00 -0000 Hi Tobias. This patch was merged to master. Thanks, -- Jeff J. On Wed, Mar 30, 2022 at 5:44 AM Tobias Burnus wrote: > Hello, > > this packages the the first patch of last/first email in this thread. > > As described in the commit log (and previous email), > __sprint_r and __sfputs_r of (nano-)vfprintf.c > call fputwc.c's _fputwc_r. > > While the vfprintf.c file is compiled for ELIX_LEVEL >=3D 1, > the fputwc.c file is only compiled with ELIX_LEVEL >=3D 4. > > Solution: This patch ignores the _WIDE_ORIENT support in > __sprint_r / __sfputs_r unless ELIX_LEVEL >=3D 4. > > It feels like the right solution but the ELIX description is > vague enough to be not sure. > > Without that patch I get for ELIX_LEVEL =3D=3D 1 (with nvptx) > a link error (missing symbol) for a code calling 'fprintf' > (with no wide char used). > > OK? =E2=80=93 If so, please commit. Otherwise, comments are welcome. > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955 >