From: Jeff Johnston <jjohnstn@redhat.com>
To: Jordi Sanfeliu <jordi@fibranet.cat>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty
Date: Mon, 17 Jul 2023 15:06:23 -0400 [thread overview]
Message-ID: <CAOox84v-AQC94i7=nRVBrWUTobOLTChgbiq14kjM-Td3Mgqe+g@mail.gmail.com> (raw)
In-Reply-To: <1de3b3ee-7dd8-db16-6e17-365dbd9fde84@fibranet.cat>
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
Original patch pushed, thanks.
-- Jeff J.
On Wed, Jul 12, 2023 at 1:34 PM Jordi Sanfeliu via Newlib <
newlib@sourceware.org> wrote:
> Hello,
>
> In my hobby OS [1] which uses Newlib C as its libc, I noticed that the
> GNU command 'logname' does output nothing when it is redirected or pipe'd.
>
> The current getlogin() implementation [2] forces the three primary file
> descriptors (stdin, stdout and stderr) to be a valid tty before checking
> the utmp file, otherwise it returns NULL. This makes impossible to
> redirect (to a file or to a pipe), the output of a program that is using
> this function because one of its file descriptors won't be a tty.
>
> See:
>
> # cat test.c
> #include <stdio.h>
>
> int main(void)
> {
> char *user;
>
> if(user = getlogin()) {
> printf("%s\n", user);
> }
>
> return 0;
> }
>
> # ./test
> root
> # ./test > xx
> # cat xx
> # ./test | cat
> #
>
> To fix this, I thought that only checking if stdin is a valid tty would
> be enough.
>
> Does this sound reasonable to you?
> Thanks.
>
>
>
> diff --git a/newlib/libc/unix/getlogin.c b/newlib/libc/unix/getlogin.c
> index da4f47a95..e646bcb08 100644
> --- a/newlib/libc/unix/getlogin.c
> +++ b/newlib/libc/unix/getlogin.c
> @@ -16,9 +16,7 @@ getlogin ()
> extern char *ttyname ();
> char *tty;
>
> - if (((tty = ttyname (0)) == 0)
> - || ((tty = ttyname (1)) == 0)
> - || ((tty = ttyname (2)) == 0))
> + if ((tty = ttyname (0)) == 0)
> return 0;
>
> if ((utmp_fd = open (UTMP_FILE, O_RDONLY)) == -1)
>
>
> 1. https://www.fiwix.org
> 2.
>
> https://sourceware.org/git/?p=newlib-cygwin.git;a=blob_plain;f=newlib/libc/unix/getlogin.c;hb=HEAD
>
> --
> Jordi Sanfeliu
> FIBRANET Network Services Provider
> https://www.fibranet.cat
>
>
next prev parent reply other threads:[~2023-07-17 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 17:33 Jordi Sanfeliu
2023-07-12 18:50 ` Torbjorn SVENSSON
2023-07-12 20:06 ` Brian Inglis
2023-07-13 16:26 ` Torbjorn SVENSSON
2023-07-13 8:06 ` Jordi Sanfeliu
2023-07-13 16:25 ` Torbjorn SVENSSON
2023-07-13 16:57 ` Jordi Sanfeliu
2023-07-13 19:01 ` Jeff Johnston
2023-07-17 7:54 ` Corinna Vinschen
2023-07-13 21:12 ` Stefan Tauner
2023-07-17 19:06 ` Jeff Johnston [this message]
2023-07-18 5:57 ` Jordi Sanfeliu
2023-07-18 7:08 ` Jordi Sanfeliu
2023-07-18 17:44 ` Jeff Johnston
2023-07-18 18:59 ` Jordi Sanfeliu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84v-AQC94i7=nRVBrWUTobOLTChgbiq14kjM-Td3Mgqe+g@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=jordi@fibranet.cat \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).