From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C08E33858C27 for ; Tue, 26 Sep 2023 22:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C08E33858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695768005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uhXq3m4K/I9r3ec1FMnYJt6SyZ7mAmhZ7RmxWI2Uqn8=; b=aFrkxTipfCGxcAexuIA5AdwLVRzi9oU6W7T8umNwrKs4Diq34Vb1N57lwzRtlQPP/hsFc2 O3EcHI6t4hztzGvNRk/GX91Mx18y4zDa2cDgv3apPMOpiL89c1tgkPQdS5RUGSTAlqptFn KAab7oGkehNFkcDcNVZrUUwrq4sqwp0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-mjMw0kgVPzenCv8LI7Ntug-1; Tue, 26 Sep 2023 18:40:01 -0400 X-MC-Unique: mjMw0kgVPzenCv8LI7Ntug-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2be48142a6cso27878191fa.1 for ; Tue, 26 Sep 2023 15:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695767999; x=1696372799; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uhXq3m4K/I9r3ec1FMnYJt6SyZ7mAmhZ7RmxWI2Uqn8=; b=joDn3Do11q3X4LTJodIFWb/D9JdoEwkwBfwbFNYb8GZaJIc6pco4mjgkVFuiiQ6Y1b XjBsAiqSe+0LbR313hWt76J4a1lAii+f9N+wsfRgY8gXyEDsDDi2NKyeAa7Pbk/dtEGU /+y+aSWYbqaDVdKIq88ZXH7LUIGzX5ZoaGEexNPBAK8fcFaZ8ud09W+ht1wDe2aQQKvs bfwyK30nTWtcK4RVwyM/PsTXBbaUbzOLt5GvbA4pfTWFRQkyyWfWOCqARmi4jk8Wh7Qe eGNyUvjc1SNW8jSO89VQ81Yq1DnzIPreTvQfWQY5mQjDgxFCaMRUFYS5EsGnbwl8/2EI KeyA== X-Gm-Message-State: AOJu0YwXrkD67alUl1OQDNhOrGIoe2ssglzMx6G+LaiLGDINj9dzkKLC BP17SBX5JUvVlp8s/iRzhFNt2gohx0l3VFl6m8GuXuQA8aCbth0IFTnDJ3yhfqQRl4EXUc5tr6Q 3zwUz51nYvx9KXdRZEqaN8UiVWhlLArkwvKRQV5k= X-Received: by 2002:a2e:4e1a:0:b0:2bc:e36a:9e32 with SMTP id c26-20020a2e4e1a000000b002bce36a9e32mr257729ljb.5.1695767999710; Tue, 26 Sep 2023 15:39:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzEsoDpNnpaEwIJwjspeEsI/dLlH56N4yPvGVIiBCMBhY2LG0jJdac0Pnz0SSaD9Z1XjncXG2lC7KPCLit5Eg= X-Received: by 2002:a2e:4e1a:0:b0:2bc:e36a:9e32 with SMTP id c26-20020a2e4e1a000000b002bce36a9e32mr257723ljb.5.1695767999358; Tue, 26 Sep 2023 15:39:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Johnston Date: Tue, 26 Sep 2023 18:39:47 -0400 Message-ID: Subject: Re: LDBL_EQ_DBL Multilib Issues To: joel@rtems.org Cc: Newlib , Chris Johns , Gedare Bloom X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003947f006064ac108" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003947f006064ac108 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Have you thought about adding a special case in sys/config.h which when it has the appropriate conditions (platform plus compiler flag) will define/redefine _LDBL_EQ_DBL? It gets included as part of _ansi.h and after newlib.h. -- Jeff J. On Tue, Sep 26, 2023 at 10:43=E2=80=AFAM Joel Sherrill wro= te: > Hi > > I wondered when we reorganized LDBL_EQ_DBL logic if there wouldn't be a > multilib edge case. Chris encountered it. > > Attached is a simple test program based on the autoconf probe in > configure.ac that can be preprocessed with different CPU/ABI flags. The > following shows that the default on m68k is not the same as for the 5282. > > $ m68k-rtems6-gcc -O2 -E ldbl.c | less > > $ m68k-rtems6-gcc -O2 -E -mcpu=3D5282 ldbl.c | less > > Turns out the default flags end up with LDBL_EQ_DBL isn't defined but it > should be for -mcpu=3D5282 builds. > > I don't know any mechanism to add header file variants in newlib by > multilib, so I we need to consider moving this to a dynamic check. > > Any thoughts on where to move this? > --0000000000003947f006064ac108--