From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 7AC93389683F for ; Mon, 14 Dec 2020 21:13:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7AC93389683F Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-iSAKYe36M-ytC9h7DSd6wA-1; Mon, 14 Dec 2020 16:13:09 -0500 X-MC-Unique: iSAKYe36M-ytC9h7DSd6wA-1 Received: by mail-pj1-f72.google.com with SMTP id gt6so4192845pjb.7 for ; Mon, 14 Dec 2020 13:13:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OcjyjuTJAUaxvXo59h27CRsixQfhkYXDBOVHrIveHiM=; b=LYmTmWTYwDdQxcl5Y6x70ZqGDroSJHUnq+VQK8HEQMD2hu3AJYNaKhyM8VXrgfeYvf EKwXiBuxc961RU9vdf0pLwT2IUNC6PuJODGE7tjwYwu1NiCI7SvqRw5ODRyU/GkqSge8 flU8oaNTlhoZWKvUqufYBsIMo7lXImNKjmlp7lU6jpGYeBOAYY/dcBkrtuDDdReVAnuU J7WABHuHSt1WQUA+Ze35ihDYFJ/iPDsDY29IigCv3FLr9PbE0WyUG+lb69cL3PUlk+v3 kLlxpoo2CJ3/ESCADnQnQaYLq5dd/LIW47cHW9nDpEfWbD8+cJbOSYZhQU3NS5R94roK xuEQ== X-Gm-Message-State: AOAM53317oyrKZ0V58grrrh3VOx7CiYhDBeAPdwP3LvHfuFHSrJBO+Rm AjOG5p6GZvusXz8MLJqwOxQJruiMhbpOyk+HmcYE0apvnHrpP4g9rSHq2UERbIRZ8DTEzd1EKBF mwuGIzgIQtTB7Mky83UPJdC8s2+owoh4= X-Received: by 2002:a17:90a:6ba4:: with SMTP id w33mr16380849pjj.32.1607980387685; Mon, 14 Dec 2020 13:13:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJybFE72NX+oJGC+vKEkzYgiGSHQNOTJl8Vw578RGNNtqXuKK+Xxmx8wyZAL5NWYzPbBA7PFBin3cPoeVPi2Ils= X-Received: by 2002:a17:90a:6ba4:: with SMTP id w33mr16380838pjj.32.1607980387476; Mon, 14 Dec 2020 13:13:07 -0800 (PST) MIME-Version: 1.0 References: <20201204074204.31629-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20201204074204.31629-1-sebastian.huber@embedded-brains.de> From: Jeff Johnston Date: Mon, 14 Dec 2020 16:12:56 -0500 Message-ID: Subject: Re: [PATCH] arm: Fix memchr() for Armv8-R To: Sebastian Huber Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 21:13:13 -0000 Patch applied to master as there were was no objection from Richard, even though he suggests the function needs resyncing. If someone wants to do the resync before end-of-year, please get approval from Richard or Arm team. -- Jeff J. On Fri, Dec 4, 2020 at 2:42 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > The Cortex-R52 processor is an Armv8-R processor with a NEON unit. This > fix prevents conflicting architecture profiles A/R errors issued by the > linker. > > Signed-off-by: Sebastian Huber > --- > newlib/libc/machine/arm/memchr.S | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/newlib/libc/machine/arm/memchr.S > b/newlib/libc/machine/arm/memchr.S > index 7c22b117e..1a4c6512c 100644 > --- a/newlib/libc/machine/arm/memchr.S > +++ b/newlib/libc/machine/arm/memchr.S > @@ -79,7 +79,11 @@ > > @ NOTE: This ifdef MUST match the one in memchr-stub.c > #if defined (__ARM_NEON__) || defined (__ARM_NEON) > +#if __ARM_ARCH >= 8 && __ARM_ARCH_PROFILE == 'R' > + .arch armv8-r > +#else > .arch armv7-a > +#endif > .fpu neon > > > -- > 2.26.2 > >