public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] iconv: Fix EL/IX level 2 handling
Date: Tue, 22 Mar 2022 11:13:16 -0400	[thread overview]
Message-ID: <CAOox84vQvGFHgd2DBKOHmdZUH3cLqYmF9BeeTC6KsPZ7L=OhyQ@mail.gmail.com> (raw)
In-Reply-To: <ad1fe7c9-09aa-deff-915d-5e72e2fe8a93@embedded-brains.de>

Please go ahead.

-- Jeff J.

On Tue, Mar 22, 2022 at 2:20 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> On 20/03/2022 02:34, Mike Frysinger wrote:
> > On 18 Mar 2022 16:58, Sebastian Huber wrote:
> >> Consistently use
> >>
> >>      if !ELIX_LEVEL_1
> >>
> >> to enable EL/IX level 2 interfaces.
> >
> > based on the comments in the build, looks fine to me.  i can't be
> bothered
> > to actually read the standards and EL/IX advice :).
> >
> > one thing i noticed in the build is the various EL/IX variables are a bit
> > of a mess.  i half debated standardizing the naming across the subdirs,
> but
> > obviously i gave up on that :).
> > -mike
>
> Thanks for having a look at it.
>
> Corinna or Jeff, can I commit this patch?
>
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
>

      reply	other threads:[~2022-03-22 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 15:58 Sebastian Huber
2022-03-20  1:34 ` Mike Frysinger
2022-03-22  6:20   ` Sebastian Huber
2022-03-22 15:13     ` Jeff Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOox84vQvGFHgd2DBKOHmdZUH3cLqYmF9BeeTC6KsPZ7L=OhyQ@mail.gmail.com' \
    --to=jjohnstn@redhat.com \
    --cc=newlib@sourceware.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).