From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 755A538485B2 for ; Wed, 8 Jun 2022 18:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 755A538485B2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654712448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pJmWoBNN7YFRwTzBdpePDrbTWb15qRoXVUJnHLNKrNM=; b=HL5oh6gRLz6rb4ge1ZhdM2+f/sSQXgMEyDiOzRP8XHBwXEL4PwJqa8aYpjM9TGuHMbOGAp yRrreCgvtH5/Q7B4TK5/F9Sw83d3vJWRFTHXUdAvF/Zynaq59WrQqQYjMY/kTnwhd1bXx1 06CJnAp84wR8/6REXXNek6K9POvh0D4= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-30Yb-e3yP8SloAStJ6OS8g-1; Wed, 08 Jun 2022 14:20:47 -0400 X-MC-Unique: 30Yb-e3yP8SloAStJ6OS8g-1 Received: by mail-yb1-f199.google.com with SMTP id l3-20020a257003000000b00663dca68ed8so5057798ybc.4 for ; Wed, 08 Jun 2022 11:20:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pJmWoBNN7YFRwTzBdpePDrbTWb15qRoXVUJnHLNKrNM=; b=BeTPInmDjmQQ4RDlRAf7bO3JcW6Srgvt4LPrs/zuoKczlXu9w3Jl4O/hLDk9OJv0F3 hvAj9SQgq4O7TCeJ7MuujhDGtyDaLMdcFRRyB322w818LyXhvwL7eqid1HpnWhpa/jHk jcPnEYO6cDk6WGTgRNLxalwDM1XlBT9eCg1i9KgowyOD6U2gf7M3/5SUNy+Lmkt9BRXW HA0cfOwhKG/HytnQvc2wL0NyS+PEcFHzva7YuhdF+jqzG64/2JgnbbavZuLrp3NnSGmS j9nuRBONkvDK9xv8rpv62HT96ojIzusFMGX8kNwlvLpfFImCCUl+h8pdJ6GLssr2rdI9 DPXQ== X-Gm-Message-State: AOAM531JRT660jpXAanGKsA+GNV4uJlEo+0HXJ4ios6wuuiIPDGCAGKr scQS5KiLDxIbfHv2Hc6kYtTEokFHkXWdXlMdQsTz5/tT2YIy/1k88H+YAXjfmWaBoUJJZ4DfBdK NN2OxNurmQgJLF0yrUDVRRno7WW7sAaA= X-Received: by 2002:a05:6902:1505:b0:663:7f1e:6ab5 with SMTP id q5-20020a056902150500b006637f1e6ab5mr17254681ybu.17.1654712446464; Wed, 08 Jun 2022 11:20:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGR3rSrQ975Wjn7jLDeGne2g/oRSrYGD9OkflFUJ8YDfz9NWPRXEI+gxWEDs0RPtJobVL0ZuBBM86deWcqr5g= X-Received: by 2002:a05:6902:1505:b0:663:7f1e:6ab5 with SMTP id q5-20020a056902150500b006637f1e6ab5mr17254659ybu.17.1654712446253; Wed, 08 Jun 2022 11:20:46 -0700 (PDT) MIME-Version: 1.0 References: <20220608084247.14531-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20220608084247.14531-1-sebastian.huber@embedded-brains.de> From: Jeff Johnston Date: Wed, 8 Jun 2022 14:20:35 -0400 Message-ID: Subject: Re: [PATCH] Clarify struct _reent comment To: Sebastian Huber Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 18:20:49 -0000 LGTM. -- Jeff J. On Wed, Jun 8, 2022 at 4:43 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > --- > newlib/libc/include/sys/reent.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/include/sys/reent.h > b/newlib/libc/include/sys/reent.h > index 64d76c27c..5d889b4a2 100644 > --- a/newlib/libc/include/sys/reent.h > +++ b/newlib/libc/include/sys/reent.h > @@ -350,9 +350,10 @@ struct _rand48 { > /* > * struct _reent > * > - * This structure contains *all* globals needed by the library. > + * This structure contains the thread-local objects needed by the library. > * It's raison d'etre is to facilitate threads by making all library > routines > - * reentrant. IE: All state information is contained here. > + * reentrant. The exit handler support and FILE maintenance use dedicated > + * global objects which are not included in this structure. > */ > > #ifdef _REENT_SMALL > -- > 2.35.3 > >