From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A9D0D388981E for ; Wed, 30 Mar 2022 19:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9D0D388981E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648668902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNZAGh8ZnRl2Glt2ru7BJl3uyKS+mgcgdi5AB2CNzxE=; b=Fivj8FdAuy9QlnRW0mg3YxGBh5djnO+eHCQMZ/MJ2rWopyprb6JeHI09y+BaSylMg3qm6U VkvWqvBapHHpTnFQ++QAL4hsXT+29pjA9xm28GjQtmGI1y/q9SW+cMVaR2RGc5f8F1tlh+ iExsf04NuaDYVq+0H5CXTbSrJ8tUxcs= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-9Od8Qei9PaeuiMupFimPfg-1; Wed, 30 Mar 2022 15:35:00 -0400 X-MC-Unique: 9Od8Qei9PaeuiMupFimPfg-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-2e61c5a0eb7so177499827b3.22 for ; Wed, 30 Mar 2022 12:35:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hNZAGh8ZnRl2Glt2ru7BJl3uyKS+mgcgdi5AB2CNzxE=; b=cwP0/HRsslF+V3OMbG8bImKLGvJRLIfZteaKUK+RRoNohqgCzt3KISez3E8hLM6d69 75XZ/FjnXSWXH7mxKxhMDaprx5hdgDiEqbGdHnGd9F+1L1SdJr3UrWY3Z5Q0yywO788s d2qaElLJ6Ak6oYRBS2KA3bEcjdHmm79jThKeHGcewf9aAfsj+Yg/jSPFOhvui+uw8s7U ZOctJY3rHSQ7RcS6p2VM8dJa7orUCuy9mmLd3AVxaDWDBqUJc5cMUpKXcwBTJC6siQmI 65eLDIL6k+DaHymHZIiCJEHrze2MTR4HsVdJzPDfDKOf2/W6LvlHATGgbVadcbjcwaLu vimA== X-Gm-Message-State: AOAM530CFblYff24xZID3JLZ5sUOL5FfyZrlpr+btA27ytY/LinfsVHe TxtGiXKwnMrCTxVDosQAC3A8fKvskOBhm8ahZLUf0HW71E+IFAODfJAi5oiWTW04TiITi/xyd72 oAIRWu8t/W/yW5PyVhBX5T3ePtETJl9E= X-Received: by 2002:a25:41d8:0:b0:634:1a47:8165 with SMTP id o207-20020a2541d8000000b006341a478165mr1232356yba.262.1648668900035; Wed, 30 Mar 2022 12:35:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX4Py9hmv5Hunj/aUo6LzOz066uQBX+BAw7NdSFiSrmV8NKSXaIdd3cLzlDEl2NUzJ6mvJhMHKU4TemI2nqA0= X-Received: by 2002:a25:41d8:0:b0:634:1a47:8165 with SMTP id o207-20020a2541d8000000b006341a478165mr1232346yba.262.1648668899901; Wed, 30 Mar 2022 12:34:59 -0700 (PDT) MIME-Version: 1.0 References: <20220330095745.72802-1-sebastian.huber@embedded-brains.de> <20220330095745.72802-2-sebastian.huber@embedded-brains.de> In-Reply-To: <20220330095745.72802-2-sebastian.huber@embedded-brains.de> From: Jeff Johnston Date: Wed, 30 Mar 2022 15:34:48 -0400 Message-ID: Subject: Re: [PATCH 2/2] newlib: Rename __sfmoreglue() and make it static To: Sebastian Huber Cc: Newlib Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 19:35:04 -0000 Looks fine. -- Jeff J. On Wed, Mar 30, 2022 at 5:58 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Rename __sfmoreglue() in sfmoreglue() and make it static. This function is > only used by __sfp() in the same translation unit. > > Remove use of register keyword. > --- > newlib/libc/stdio/findfp.c | 7 +++---- > newlib/libc/stdio/local.h | 1 - > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/newlib/libc/stdio/findfp.c b/newlib/libc/stdio/findfp.c > index 7bb48e014..eca47bd92 100644 > --- a/newlib/libc/stdio/findfp.c > +++ b/newlib/libc/stdio/findfp.c > @@ -122,9 +122,8 @@ struct glue_with_file { > FILE file; > }; > > -struct _glue * > -__sfmoreglue (struct _reent *d, > - register int n) > +static struct _glue * > +sfmoreglue (struct _reent *d, int n) > { > struct glue_with_file *g; > > @@ -160,7 +159,7 @@ __sfp (struct _reent *d) > if (fp->_flags == 0) > goto found; > if (g->_next == NULL && > - (g->_next = __sfmoreglue (d, NDYNAMIC)) == NULL) > + (g->_next = sfmoreglue (d, NDYNAMIC)) == NULL) > break; > } > _newlib_sfp_lock_exit (); > diff --git a/newlib/libc/stdio/local.h b/newlib/libc/stdio/local.h > index 09ccd6407..86422eb11 100644 > --- a/newlib/libc/stdio/local.h > +++ b/newlib/libc/stdio/local.h > @@ -184,7 +184,6 @@ extern void _cleanup_r (struct _reent *); > extern void __smakebuf_r (struct _reent *, FILE *); > extern int __swhatbuf_r (struct _reent *, FILE *, size_t *, int *); > extern int _fwalk_reent (struct _reent *, int (*)(struct _reent *, > FILE *)); > -struct _glue * __sfmoreglue (struct _reent *,int n); > extern int __submore (struct _reent *, FILE *); > > #ifdef __LARGE64_FILES > -- > 2.34.1 > >