From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D6CC83858016 for ; Wed, 28 Sep 2022 14:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6CC83858016 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664376757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F0AnmzJPiLSp+Fobr7Qo7ZoOp6+JiqfE90jjuR0fyVk=; b=ZGNPsgYrFVOm/wiztlVSTgTXKLHucsQgxekxfbtlt+lZVQZvl/NwWBWDVhQMKfFNcFmo8d RwcQG/9k6CPudmV5axfOQi0IpTebT/GvO+Dg/3yjOmiyOPK3g7yzsR0a6uiL8YP54b9yoF x+zQwOPUOBWiGlEnEXvkVQelpUszIw0= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-142-pq0t5ResN2qkQz_yEuRwZQ-1; Wed, 28 Sep 2022 10:52:34 -0400 X-MC-Unique: pq0t5ResN2qkQz_yEuRwZQ-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-34d3fbc7cfcso122126247b3.7 for ; Wed, 28 Sep 2022 07:52:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=F0AnmzJPiLSp+Fobr7Qo7ZoOp6+JiqfE90jjuR0fyVk=; b=GUPPryIqtDQilwlSZePGeepHE+5m4JqBsUW62qjRkJ+CNjVtjz49d4rw0D/LBos1Nf yKIN5YbDYbidxHOjc1AxWGxwHzjuAegL40Anum3zpTa49CcCbm2CUl+4csMbvUFSRqZK iyOgixIpoQwPAXsXBXbjlJOz9K4qBkkQZhcj6JGSMEj+go3LrslP6KYyHQpCpOHKawN4 svFUCduEeSVK3SKbl6wDCzY+CMvHBUYnVzdtydTip6m8UvDk+toDRZ544x+4WRzb+rKa E006qwQ/GKrRP3RzU0wjcVc3/CohVQEtHDVAsFmTMEOX7ma5kF7E+HWAaTnbO4kCRY6Y aTfA== X-Gm-Message-State: ACrzQf2xo7yA1ieeO46BFIhqompu3CHIF9OQ0e3yDBzeveF/t8VZcIq2 d4iNP2uCWmneHR/vrREjZl5DkJCigZjefeUw5SB5socEVEDxE+nhURWOOxql2qzKbL4ORVm95le Etzx2GeARK8+Sa5eRIXZqxepQGZZKj0c= X-Received: by 2002:a25:af49:0:b0:6af:fbf5:92d5 with SMTP id c9-20020a25af49000000b006affbf592d5mr31030874ybj.624.1664376751435; Wed, 28 Sep 2022 07:52:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4CAPHe2H4OA+zBWUfUvY6LiM90BcfhMm0Nf6oIBVj3ScekZQgXfRFLlKEqjOmr2xhEZX30yFbP3F6yKz78aB0= X-Received: by 2002:a25:af49:0:b0:6af:fbf5:92d5 with SMTP id c9-20020a25af49000000b006affbf592d5mr31030849ybj.624.1664376751205; Wed, 28 Sep 2022 07:52:31 -0700 (PDT) MIME-Version: 1.0 References: <20220928143253.3210378-1-szabolcs.nagy@arm.com> In-Reply-To: <20220928143253.3210378-1-szabolcs.nagy@arm.com> From: Jeff Johnston Date: Wed, 28 Sep 2022 10:52:19 -0400 Message-ID: Subject: Re: [PATCH] Rerun automake in newlib/ To: Szabolcs Nagy Cc: Newlib , Richard Earnshaw , "Richard.Earnshaw@arm.com" , Torbjorn SVENSSON , Niklas DAHLQUIST X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000000740f405e9bde9e6" X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000000740f405e9bde9e6 Content-Type: text/plain; charset="UTF-8" Patch applied, thanks. -- Jeff J. On Wed, Sep 28, 2022 at 10:33 AM Szabolcs Nagy wrote: > newlib/libc/sys/arm/Makefile.inc was modified but automake was not rerun in > > commit 5230eb7f8c6b43c71d7e38d138935c48de930b76 > Implement sysconf for Arm > > on arm-none-eabi target this caused > > ld: B/arm-none-eabi/lib/libg.a(libc_a-mallocr.o): in function > `malloc_extend_top': > S/newlib-cygwin/newlib/libc/stdlib/_mallocr.c:2161: undefined reference > to `sysconf' > --- > newlib/Makefile.in | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/newlib/Makefile.in b/newlib/Makefile.in > index f26d99ae9..d77f44560 100644 > --- a/newlib/Makefile.in > +++ b/newlib/Makefile.in > @@ -523,7 +523,7 @@ check_PROGRAMS = > @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ libc/sys/amdgcn/close.c > libc/sys/amdgcn/fstat.c libc/sys/amdgcn/isatty.c libc/sys/amdgcn/lseek.c > libc/sys/amdgcn/read.c libc/sys/amdgcn/write.c \ > @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ libc/sys/amdgcn/fcntl.c > libc/sys/amdgcn/getpid.c libc/sys/amdgcn/kill.c libc/sys/amdgcn/open.c > libc/sys/amdgcn/raise.c libc/sys/amdgcn/stat.c libc/sys/amdgcn/unlink.c > > -@HAVE_LIBC_SYS_ARM_DIR_TRUE@am__append_45 = libc/sys/arm/access.c > libc/sys/arm/aeabi_atexit.c > +@HAVE_LIBC_SYS_ARM_DIR_TRUE@am__append_45 = libc/sys/arm/access.c > libc/sys/arm/aeabi_atexit.c libc/sys/arm/sysconf.c > @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__append_46 = > libc/sys/arm/libcfunc.c libc/sys/arm/trap.S libc/sys/arm/syscalls.c > @HAVE_LIBC_SYS_D10V_DIR_TRUE@am__append_47 = libc/sys/d10v/syscalls.c > libc/sys/d10v/trap.S libc/sys/d10v/creat.c > @HAVE_LIBC_SYS_EPIPHANY_DIR_TRUE@am__append_48 = > libc/sys/epiphany/e_printf.c > @@ -1579,7 +1579,8 @@ am__objects_51 = libc/ssp/libc_a-chk_fail.$(OBJEXT) \ > @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ > libc/sys/amdgcn/libc_a-stat.$(OBJEXT) \ > @HAVE_LIBC_SYS_AMDGCN_DIR_TRUE@ > libc/sys/amdgcn/libc_a-unlink.$(OBJEXT) > @HAVE_LIBC_SYS_ARM_DIR_TRUE@am__objects_55 = > libc/sys/arm/libc_a-access.$(OBJEXT) \ > -@HAVE_LIBC_SYS_ARM_DIR_TRUE@ libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT) > +@HAVE_LIBC_SYS_ARM_DIR_TRUE@ > libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT) \ > +@HAVE_LIBC_SYS_ARM_DIR_TRUE@ libc/sys/arm/libc_a-sysconf.$(OBJEXT) > @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__objects_56 = > libc/sys/arm/libc_a-libcfunc.$(OBJEXT) \ > @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/arm/libc_a-trap.$(OBJEXT) \ > @HAVE_LIBC_SYS_ARM_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/arm/libc_a-syscalls.$(OBJEXT) > @@ -6802,6 +6803,8 @@ libc/sys/arm/libc_a-access.$(OBJEXT): > libc/sys/arm/$(am__dirstamp) \ > libc/sys/arm/libc_a-aeabi_atexit.$(OBJEXT): \ > libc/sys/arm/$(am__dirstamp) \ > libc/sys/arm/$(DEPDIR)/$(am__dirstamp) > +libc/sys/arm/libc_a-sysconf.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \ > + libc/sys/arm/$(DEPDIR)/$(am__dirstamp) > libc/sys/arm/libc_a-libcfunc.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \ > libc/sys/arm/$(DEPDIR)/$(am__dirstamp) > libc/sys/arm/libc_a-trap.$(OBJEXT): libc/sys/arm/$(am__dirstamp) \ > @@ -12833,6 +12836,7 @@ distclean-compile: > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/arm/$(DEPDIR)/libc_a-aeabi_atexit.Po@am__quote@ > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/arm/$(DEPDIR)/libc_a-libcfunc.Po@am__quote@ > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/arm/$(DEPDIR)/libc_a-syscalls.Po@am__quote@ > +@AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/arm/$(DEPDIR)/libc_a-sysconf.Po@am__quote@ > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/arm/$(DEPDIR)/libc_a-trap.Po@am__quote@ > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/d10v/$(DEPDIR)/libc_a-creat.Po@am__quote@ > @AMDEP_TRUE@@am__include@ @am__quote@libc > /sys/d10v/$(DEPDIR)/libc_a-syscalls.Po@am__quote@ > @@ -29556,6 +29560,20 @@ libc/sys/arm/libc_a-aeabi_atexit.obj: > libc/sys/arm/aeabi_atexit.c > @AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE) > $(depcomp) @AMDEPBACKSLASH@ > @am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS) > $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) > $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-aeabi_atexit.obj `if > test -f 'libc/sys/arm/aeabi_atexit.c'; then $(CYGPATH_W) > 'libc/sys/arm/aeabi_atexit.c'; else $(CYGPATH_W) > '$(srcdir)/libc/sys/arm/aeabi_atexit.c'; fi` > > +libc/sys/arm/libc_a-sysconf.o: libc/sys/arm/sysconf.c > +@am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) > $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT > libc/sys/arm/libc_a-sysconf.o -MD -MP -MF > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo -c -o > libc/sys/arm/libc_a-sysconf.o `test -f 'libc/sys/arm/sysconf.c' || echo > '$(srcdir)/'`libc/sys/arm/sysconf.c > +@am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv) > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Po > +@AMDEP_TRUE@@am__fastdepCC_FALSE@ > $(AM_V_CC)source='libc/sys/arm/sysconf.c' > object='libc/sys/arm/libc_a-sysconf.o' libtool=no @AMDEPBACKSLASH@ > +@AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE) > $(depcomp) @AMDEPBACKSLASH@ > +@am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS) > $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) > $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-sysconf.o `test -f > 'libc/sys/arm/sysconf.c' || echo '$(srcdir)/'`libc/sys/arm/sysconf.c > + > +libc/sys/arm/libc_a-sysconf.obj: libc/sys/arm/sysconf.c > +@am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) > $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT > libc/sys/arm/libc_a-sysconf.obj -MD -MP -MF > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo -c -o > libc/sys/arm/libc_a-sysconf.obj `if test -f 'libc/sys/arm/sysconf.c'; then > $(CYGPATH_W) 'libc/sys/arm/sysconf.c'; else $(CYGPATH_W) > '$(srcdir)/libc/sys/arm/sysconf.c'; fi` > +@am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv) > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Tpo > libc/sys/arm/$(DEPDIR)/libc_a-sysconf.Po > +@AMDEP_TRUE@@am__fastdepCC_FALSE@ > $(AM_V_CC)source='libc/sys/arm/sysconf.c' > object='libc/sys/arm/libc_a-sysconf.obj' libtool=no @AMDEPBACKSLASH@ > +@AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE) > $(depcomp) @AMDEPBACKSLASH@ > +@am__fastdepCC_FALSE@ $(AM_V_CC@am__nodep@)$(CC) $(DEFS) > $(DEFAULT_INCLUDES) $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) > $(libc_a_CFLAGS) $(CFLAGS) -c -o libc/sys/arm/libc_a-sysconf.obj `if test > -f 'libc/sys/arm/sysconf.c'; then $(CYGPATH_W) 'libc/sys/arm/sysconf.c'; > else $(CYGPATH_W) '$(srcdir)/libc/sys/arm/sysconf.c'; fi` > + > libc/sys/arm/libc_a-libcfunc.o: libc/sys/arm/libcfunc.c > @am__fastdepCC_TRUE@ $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) > $(INCLUDES) $(libc_a_CPPFLAGS) $(CPPFLAGS) $(libc_a_CFLAGS) $(CFLAGS) -MT > libc/sys/arm/libc_a-libcfunc.o -MD -MP -MF > libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Tpo -c -o > libc/sys/arm/libc_a-libcfunc.o `test -f 'libc/sys/arm/libcfunc.c' || echo > '$(srcdir)/'`libc/sys/arm/libcfunc.c > @am__fastdepCC_TRUE@ $(AM_V_at)$(am__mv) > libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Tpo > libc/sys/arm/$(DEPDIR)/libc_a-libcfunc.Po > -- > 2.25.1 > > --0000000000000740f405e9bde9e6--