From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68885 invoked by alias); 31 Jul 2017 17:34:44 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 68814 invoked by uid 89); 31 Jul 2017 17:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=Hx-languages-length:1876, licensing, We'd, H*Ad:U*patches X-HELO: mail-pg0-f51.google.com Received: from mail-pg0-f51.google.com (HELO mail-pg0-f51.google.com) (74.125.83.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Jul 2017 17:34:41 +0000 Received: by mail-pg0-f51.google.com with SMTP id v189so11577039pgd.2 for ; Mon, 31 Jul 2017 10:34:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ksn5a0XAq4Qd4/gdvhbz2AmfCjXcizB18lkMvxf7a+0=; b=ftAn5PhZE8bRGGB/21J66fqMN1mtpvH0AHvoDghnp0nuAbSmvrDcHjeZOQaAHH2n2i P3xGpc8dmMz/2GAcvmdMzLlL0myg3HAfS3AR0PzbKtd1bXOJ9WNBgIuMGqxkFGtZLUCL HHqbo3kveYRb+QMNKn4CSF/49xTNbm9ad1dSXkP+6sbcIoNkX2tei2acPI4adKLQsEYJ iycTfwBl2FATim3pMyQ2ucV2WqA0Oe/Na6cMTsOnh0HR1++y8I78CaCwgdA9+xMtvsSD TGwB8pFngTnDJWjb0Yw0WK/SuvKHQR7iDKAjw9dAuCEsRwAQqjxunihm6to1OwJEdOys hpeA== X-Gm-Message-State: AIVw1126eFaaXxjImd8F6wNYw6DHsoiRpICoGYhx2IsQS1o8NpECJnU7 bpv0dXBn5YqnlJdXHkQ9tMNs8GV8grEz X-Received: by 10.98.150.135 with SMTP id s7mr16294528pfk.172.1501522480050; Mon, 31 Jul 2017 10:34:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.184.9 with HTTP; Mon, 31 Jul 2017 10:34:39 -0700 (PDT) In-Reply-To: References: From: Jeff Johnston Date: Mon, 31 Jul 2017 17:34:00 -0000 Message-ID: Subject: Re: Newlib/libgloss port for RISC-V To: Kito Cheng Cc: Newlib , Palmer Dabbelt , Andrew Waterman , patches@groups.riscv.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00704.txt.bz2 Hi Kito, Before I continue reviewing, I have noticed that you have no licensing information in any of your non-generated files. You need to add this as Red Hat has the default license. You can make it BSD-like or see other licenses in the repository that are even more permissive. That said, you have another issue in that one of your files (asm.h) in the first patch has been taken from glibc and is LPGL. This can cause problems unless you are building newlib as a dynamic library as code that links to your library becomes LGPL unless it provides everything required to relink. See: https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking My suggestion would be to create your own version of asm.h and any other files that are LGPL and license them how you see fit. Regards, -- Jeff J. On Thu, Jul 27, 2017 at 5:29 AM, Kito Cheng wrote: > Hi all: > > We'd like to contribute for RISC-V[1] support to newlib/libgloss. > RISC-V is an open ISA which support both 32 and 64 bit. > > For the other part of GNU toolchain, GCC and binutils already included > in upstream in GCC 7 / binutils 2.28. > > We've also tested with newlib and gcc testsuite for following targets: > > riscv32-unknown-elf > riscv64-unknown-elf > > [PATCH 1/3] Add RISC-V port for newlib > https://sourceware.org/ml/newlib/2017/msg00669.html > [PATCH 2/3] Add RISC-V port for libm > https://sourceware.org/ml/newlib/2017/msg00670.html > [PATCH 3/3] Add RISC-V port for libgloss > https://sourceware.org/ml/newlib/2017/msg00671.html > > Contributor list: > - Andrew Waterman > - Kito Cheng > - Palmer Dabbelt > - Scott Beamer > - Michael Neilly > - Alex Suykov > > > [1] https://riscv.org/