From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 478563858C39 for ; Wed, 6 Oct 2021 18:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 478563858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633543864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vUMLF6tqBaE2qI097UTx708gt2ZXSpJdX+Y7nNMJX44=; b=Z8WOZAPL8NE/4Rd070EG0++WCYHI14tdggDf07HvILa4q/vAJ7b9nPTRiL25mAUaU9f1D8 fvYP+gezewcXMlBOR8kGKn4JkyevOct2ms3UZlN7YYVG2rCQa2mDIUxIIWoRn17a7vO7Z9 KZQncisuD5F+q+BsvT2ZPIitpv3QNT8= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-Un32YnwmObODwe4IABnX6w-1; Wed, 06 Oct 2021 14:11:03 -0400 X-MC-Unique: Un32YnwmObODwe4IABnX6w-1 Received: by mail-pj1-f71.google.com with SMTP id b11-20020a17090aa58b00b0019c8bfd57b8so1944125pjq.1 for ; Wed, 06 Oct 2021 11:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vUMLF6tqBaE2qI097UTx708gt2ZXSpJdX+Y7nNMJX44=; b=AhYeF/dedz2tq9hrYWfjnuBnhDXUEYFXBV8jCQJrGgtW6ygOJxX70DTsgJz5yYML7q oX/vn75al1V9wqaQ1S0ebgAJxUYSp8ct+SroMzY+yIJId3CuwzgVFN6oziSj9VEE4D1J xtkHJfN4dex/1Hesa6D+B/gua2dTzt6qzNEuhXb2+UigHYgQm9gWzLaa5IHf06fLnvFn 5QLh8ZBzuf+VSDVSfp9oRzejKCD/Q4OMwRT4tDfDd3HMWuLJFExrA73kQv6SLx7ow+6j GcODpC4lcJdfNQkl8OBdRUeCfKmVPi2hTCE/9factpeXj51OV1Co0+KaZhVjv+gOmkBM sH6w== X-Gm-Message-State: AOAM531TIXBoBDPxMwgaWffN5JQEb0Rt2CxTpPoW3cfdaINA1fv5vAdF ccVJtGB2GGnhB7nUyVhbsWR2xhO6wwe4AQlFq5ctCWYtOGGhB5k7UwhTvrgngwM0YzTW25baGow sW6nx1rUvqZ16u1+N87SVKNxtZAjvEgU= X-Received: by 2002:a17:902:a503:b029:12b:2429:385e with SMTP id s3-20020a170902a503b029012b2429385emr12493868plq.64.1633543862449; Wed, 06 Oct 2021 11:11:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzECBPssI+MHXmug1HvXLThISEmZast4CJEMUG029UsNSipHHg4wyAYnJp28Jg2jNmTreM/4eRsaYhZgftYq8I= X-Received: by 2002:a17:902:a503:b029:12b:2429:385e with SMTP id s3-20020a170902a503b029012b2429385emr12493784plq.64.1633543862008; Wed, 06 Oct 2021 11:11:02 -0700 (PDT) MIME-Version: 1.0 References: <20211005153344.91266-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20211005153344.91266-1-sebastian.huber@embedded-brains.de> From: Jeff Johnston Date: Wed, 6 Oct 2021 14:10:51 -0400 Message-ID: Subject: Re: [PATCH v2 0/4] Optimize red-black tree insert/extract To: Sebastian Huber Cc: Newlib , devel Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jjohnstn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 18:11:07 -0000 Hi Sebastian, LGTM. If no one else objects, I will merge tomorrow. -- Jeff J. On Tue, Oct 5, 2021 at 11:34 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Code coverage analysis of the red-black tree insert/extract operations > defined > in showed that the macros contain dead code. This patch set > simplifies some expressions and add specialized rotations. > > v2: > > Add comments in patch 3 and 4. > > Sebastian Huber (4): > sys/tree.h: Simplify loop condition > sys/tree.h: Simplify chain of conditions > sys/tree.h: Add parent rotations > sys/tree.h: Red child with black sibling rotations > > newlib/libc/include/sys/tree.h | 90 +++++++++++++++++++++++++++++++--- > 1 file changed, 82 insertions(+), 8 deletions(-) > > -- > 2.26.2 > >