From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 00A183858C2F for ; Mon, 15 Aug 2022 19:13:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00A183858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660590824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tq/YcOjKAZenxVJBkhhFnoWMMkYa3xhbKmL0tVbfXpc=; b=RZgVzyl52s86zOqD7C2GlkvpQJGcj1z/nbniY50k21Kg3/RxarCByg+0g/lbF/XsB3pyiY hoNjbE6hrDH8sO9IR2GsVh5ODxhDlu+Ly84iXxRUFK5PsX++YR/HH/XZa8Z6oMczR2ubm+ bfBCObqlbwAOrGLshX62GkwaD5pOzRc= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-282-ba2UiLk0PfCImzuTRZCtdA-1; Mon, 15 Aug 2022 15:13:43 -0400 X-MC-Unique: ba2UiLk0PfCImzuTRZCtdA-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-31f5960500bso71806777b3.14 for ; Mon, 15 Aug 2022 12:13:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=Tq/YcOjKAZenxVJBkhhFnoWMMkYa3xhbKmL0tVbfXpc=; b=R5VdCAqr47vKdbNirXqaMuQr0KpBo228m7//x9KnFCNVcBmwXEU3NQWnoPj+x6zrqe /fuPdS3Nw0wMayY5AZFFYnKtCc3tVp8PssL27+aTNcqXlue/IM0Usijhus/yZ/xCY0yI prU5hrk9Fveyl8DfygjFpsuKFfU5Ac6rYP7jUMz70XkxoVngBE+mrLVK7ZjWGq0DWD8j GZ9wWiTBaWSeahS33Ik64y2EzrsMXcHKk5u/P7dh9bjiIOYkWJb1cbSzyImen0XTlcYu ctLbZBL7kQn5evHxACyV8AcVkScLq29mhAAqh7QCfavzlM6egExt/XLPrRjIN22KPUff iPeg== X-Gm-Message-State: ACgBeo1NKoNPUqJYP1yxbevr/7XqWru2cl3CSq22Vt8txaja/cRHEAWi G0WuQ5YweYV2jQMPPUKWoxp0n4OBVSATZZGfKwoTqh19Hmrb3vFiG+Zh3QnP/SNZLQPUJ1qvZKv CTke/WAqcmyzL+MJZg/aVMGTAvJhFEyg= X-Received: by 2002:a25:3458:0:b0:684:1b88:1d59 with SMTP id b85-20020a253458000000b006841b881d59mr10521895yba.399.1660590822705; Mon, 15 Aug 2022 12:13:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR4/Q3tXFJmuyUH8rJZFDHO0lsDx13kU9rbylaGNIWHlx2xRV9ymuoYbHfmQAIp2aKWryiKX1N9O+dfkFYErS1I= X-Received: by 2002:a25:3458:0:b0:684:1b88:1d59 with SMTP id b85-20020a253458000000b006841b881d59mr10521878yba.399.1660590822261; Mon, 15 Aug 2022 12:13:42 -0700 (PDT) MIME-Version: 1.0 References: <20220813162250.125537-1-imi415@imi.moe> In-Reply-To: <20220813162250.125537-1-imi415@imi.moe> From: Jeff Johnston Date: Mon, 15 Aug 2022 15:13:31 -0400 Message-ID: Subject: Re: [PATCH] SH: Do not build syscalls if option provided To: Yilin Sun Cc: Newlib X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 19:13:47 -0000 Thanks Yilin, patch pushed to master. -- Jeff J. On Sat, Aug 13, 2022 at 12:23 PM Yilin Sun via Newlib wrote: > This patch makes syscalls for SH architecture respecting the global option > "--disable-newlib-supplied-syscalls". This is useful when a bare-metal > toolchain is needed. > > Signed-off-by: Yilin Sun > --- > newlib/Makefile.in | 12 ++++++------ > newlib/libc/sys/sh/Makefile.inc | 2 ++ > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/newlib/Makefile.in b/newlib/Makefile.in > index ad81c4fd7..f26d99ae9 100644 > --- a/newlib/Makefile.in > +++ b/newlib/Makefile.in > @@ -552,7 +552,7 @@ check_PROGRAMS = > @HAVE_LIBC_SYS_RDOS_DIR_TRUE@ libc/sys/rdos/wait.c libc/sys/rdos/write.c > > @HAVE_LIBC_SYS_RTEMS_DIR_TRUE@am__append_56 = libc/sys/rtems/dummysys.c > libc/sys/rtems/cpusetalloc.c libc/sys/rtems/cpusetfree.c > -@HAVE_LIBC_SYS_SH_DIR_TRUE@am__append_57 = libc/sys/sh/syscalls.c > libc/sys/sh/trap.S libc/sys/sh/creat.c libc/sys/sh/ftruncate.c > libc/sys/sh/truncate.c > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__append_57 = > libc/sys/sh/syscalls.c libc/sys/sh/trap.S libc/sys/sh/creat.c > libc/sys/sh/ftruncate.c libc/sys/sh/truncate.c > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@am__append_58 = \ > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@ libc/sys/sysmec/_exit.c > libc/sys/sysmec/access.c libc/sys/sysmec/chmod.c libc/sys/sysmec/chown.c > libc/sys/sysmec/close.c libc/sys/sysmec/creat.c libc/sys/sysmec/crt1.c \ > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@ libc/sys/sysmec/execv.c > libc/sys/sysmec/execve.c libc/sys/sysmec/fork.c libc/sys/sysmec/fstat.c > libc/sys/sysmec/getpid.c libc/sys/sysmec/isatty.c \ > @@ -1661,11 +1661,11 @@ am__objects_51 = > libc/ssp/libc_a-chk_fail.$(OBJEXT) \ > @HAVE_LIBC_SYS_RTEMS_DIR_TRUE@am__objects_66 = > libc/sys/rtems/libc_a-dummysys.$(OBJEXT) \ > @HAVE_LIBC_SYS_RTEMS_DIR_TRUE@ > libc/sys/rtems/libc_a-cpusetalloc.$(OBJEXT) \ > @HAVE_LIBC_SYS_RTEMS_DIR_TRUE@ libc/sys/rtems/libc_a-cpusetfree.$(OBJEXT) > -@HAVE_LIBC_SYS_SH_DIR_TRUE@am__objects_67 = > libc/sys/sh/libc_a-syscalls.$(OBJEXT) \ > -@HAVE_LIBC_SYS_SH_DIR_TRUE@ libc/sys/sh/libc_a-trap.$(OBJEXT) \ > -@HAVE_LIBC_SYS_SH_DIR_TRUE@ libc/sys/sh/libc_a-creat.$(OBJEXT) \ > -@HAVE_LIBC_SYS_SH_DIR_TRUE@ libc/sys/sh/libc_a-ftruncate.$(OBJEXT) \ > -@HAVE_LIBC_SYS_SH_DIR_TRUE@ libc/sys/sh/libc_a-truncate.$(OBJEXT) > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@am__objects_67 = > libc/sys/sh/libc_a-syscalls.$(OBJEXT) \ > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/sh/libc_a-trap.$(OBJEXT) \ > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/sh/libc_a-creat.$(OBJEXT) \ > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/sh/libc_a-ftruncate.$(OBJEXT) \ > +@HAVE_LIBC_SYS_SH_DIR_TRUE@@MAY_SUPPLY_SYSCALLS_TRUE@ > libc/sys/sh/libc_a-truncate.$(OBJEXT) > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@am__objects_68 = > libc/sys/sysmec/libc_a-_exit.$(OBJEXT) \ > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@ > libc/sys/sysmec/libc_a-access.$(OBJEXT) \ > @HAVE_LIBC_SYS_SYSMEC_DIR_TRUE@ > libc/sys/sysmec/libc_a-chmod.$(OBJEXT) \ > diff --git a/newlib/libc/sys/sh/Makefile.inc > b/newlib/libc/sys/sh/Makefile.inc > index d4081ec92..d4ea148f3 100644 > --- a/newlib/libc/sys/sh/Makefile.inc > +++ b/newlib/libc/sys/sh/Makefile.inc > @@ -1 +1,3 @@ > +if MAY_SUPPLY_SYSCALLS > libc_a_SOURCES += %D%/syscalls.c %D%/trap.S %D%/creat.c %D%/ftruncate.c > %D%/truncate.c > +endif > -- > 2.37.1 > >