From: Jeff Johnston <jjohnstn@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] newlib: info: tweak iconv node to avoid collisions
Date: Mon, 12 Dec 2022 20:28:38 -0500 [thread overview]
Message-ID: <CAOox84vwqHzC0RzZmOg1iky5KW2SQHDjKAbZR4DQxvvVB-d-QA@mail.gmail.com> (raw)
In-Reply-To: <20221210082931.29182-1-vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
LGTM.
-- Jeff J.
On Sat, Dec 10, 2022 at 3:30 AM Mike Frysinger <vapier@gentoo.org> wrote:
> We have "Iconv" and "iconv" nodes which generates Iconv.html and
> iconv.html files. On a case-insensitive filesystem, these collide.
> Rename the "Iconv" node to match the chapter name that it's already
> using to avoid the issue.
> ---
> newlib/libc/iconv/iconv.tex | 2 +-
> newlib/libc/libc.texi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/libc/iconv/iconv.tex b/newlib/libc/iconv/iconv.tex
> index 42d04c0b616f..5b1f7518a4fe 100644
> --- a/newlib/libc/iconv/iconv.tex
> +++ b/newlib/libc/iconv/iconv.tex
> @@ -1,4 +1,4 @@
> -@node Iconv
> +@node Encoding conversions
> @chapter Encoding conversions (@file{iconv.h})
>
> This chapter describes the Newlib iconv library.
> diff --git a/newlib/libc/libc.texi b/newlib/libc/libc.texi
> index d217d8118277..72328e148bf6 100644
> --- a/newlib/libc/libc.texi
> +++ b/newlib/libc/libc.texi
> @@ -151,7 +151,7 @@ into another language, under the above conditions for
> modified versions.
> * Posix::
> * Syscalls::
> * Arglists::
> -* Iconv::
> +* Encoding conversions::
> * Overflow Protection::
>
> * Document Index::
> --
> 2.38.1
>
>
prev parent reply other threads:[~2022-12-13 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 16:06 Iconv.html and iconv.html Torbjorn SVENSSON
2022-12-09 16:29 ` Mike Frysinger
2022-12-09 16:40 ` Torbjorn SVENSSON
2022-12-10 8:29 ` Mike Frysinger
2022-12-10 8:29 ` [PATCH] newlib: info: tweak iconv node to avoid collisions Mike Frysinger
2022-12-13 1:28 ` Jeff Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOox84vwqHzC0RzZmOg1iky5KW2SQHDjKAbZR4DQxvvVB-d-QA@mail.gmail.com \
--to=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).