From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1ADAC3858D33 for ; Wed, 16 Aug 2023 18:55:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1ADAC3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692212152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DlFRdZ/6VJ5Tj98cCSmUBopKsGDAqqBuQ63tPsfiTQE=; b=aH2vrLMweOxLXA15e8KDvPoNCacYzyFp8R8ip18DXlB1J87Fn02z/m8iI2eAMn/7W109eq SvsuW1DQWu28YwnhXnsB/vo5gzGOf5Q2JjHL+HmFH4BKpSovlY8j/GTsoh3fqts7FOfbQ8 vO9HoWHDyBeqNu1qNs9/euC0JN4UEaQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-cOB0S-p8NqKCz2I4ejV7vw-1; Wed, 16 Aug 2023 14:55:51 -0400 X-MC-Unique: cOB0S-p8NqKCz2I4ejV7vw-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-51e535b143fso1023068a12.1 for ; Wed, 16 Aug 2023 11:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692212150; x=1692816950; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DlFRdZ/6VJ5Tj98cCSmUBopKsGDAqqBuQ63tPsfiTQE=; b=kYxg70iSUnnymTIp1Dn+nOKUoQWi+gHpC3PP4K6/xswvu4a8WuMrGwHr5Ma3CJ5iG3 Fkp6mVBmeiHpY7e/nbLmx/K8OGDN+UuYuWzKpMhPxpHbxi8NWuVVpuhuvcKZV2Z4GOlu /MEaLsgWX9Q5BmTRuF1SRAg7J/HLBckG100rX78EmX+1+iAsnbEvtbc592XTsELoX251 AMgOUk2xwdQN4cPsOWUDdIYFxsjpQFziuiTaJuCTz7dGXVIkdue7VidZmIMltXFb9eUi r29ef1ExRPlVs10RlIFZWDqSBs+w0KmSK1Lxxhze1Wwsk/hAPyR4hTcbMBKeY0Ss8c4r KGCQ== X-Gm-Message-State: AOJu0Yy2VoqmopEuTcRChCIUzmkDjV1lUwTbS4I/3EFJ67BoARrvIzLB QDMrUbXRa2q1EWVSvrKB9dsr3RzzNSaPbS7Ydx6sMFFubLhQH3twwpO1c1bk/MVz5J7IFHP5a5P W5SYLP4KH23OvUI/+vdUzt9xd/xVAhXs= X-Received: by 2002:a17:906:74c8:b0:99d:675e:5217 with SMTP id z8-20020a17090674c800b0099d675e5217mr1964301ejl.7.1692212150107; Wed, 16 Aug 2023 11:55:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwS8nZVZKsxMUlsY4kRxl5gXM/eyHJMCpCeEG7Ljw2vdaybq7Qo58LvLd11qzXy6UPmGqP3ZdE1P9hjwT6BNg= X-Received: by 2002:a17:906:74c8:b0:99d:675e:5217 with SMTP id z8-20020a17090674c800b0099d675e5217mr1964293ejl.7.1692212149835; Wed, 16 Aug 2023 11:55:49 -0700 (PDT) MIME-Version: 1.0 References: <1cb9e9f8c8e4e1df52b439184333d628b3532f65.camel@espressif.com> <15cedffa7c98bea187abe6041c7542db03dbe834.camel@espressif.com> <88d7f122c6bc8bbafd38f0da4c384a3c12e16386.camel@espressif.com> <3bde2977f67106650dd56105819e144842ab9077.camel@espressif.com> In-Reply-To: From: Jeff Johnston Date: Wed, 16 Aug 2023 14:55:38 -0400 Message-ID: Subject: Re: [PATCH, RFC v3 0/3] add xtensa port To: Alexey Lapshin Cc: Alexey Gerenkov , "newlib@sourceware.org" , "jcmvbkbc@gmail.com" , Ivan Grokhotkov X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000138eaa06030ed841" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000138eaa06030ed841 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Alexey, Ok, that's fine. Two last issues with Patch 2. 1. You don't include your libm/machine/xtensa/Makefile.inc in libm/Makefile.inc 2. You shouldn't modify libm/math/ef_sqrt.c. Instead, add your own ef_sqrt.c in libm/machine/xtensa. Machine objects override the common ones. -- Jeff J. On Wed, Aug 16, 2023 at 3:46=E2=80=AFAM Alexey Lapshin wrote: > > Is this change required and is missing from this latest Patch 2 or did > you change your mind regarding the change? > > I removed changes from the patch that were unrelated to the xtensa port. > Sent this change as separate patch. ( > https://sourceware.org/pipermail/newlib/2023/020490.html) > --000000000000138eaa06030ed841--