From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id F251B385800A for ; Tue, 26 Oct 2021 19:36:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F251B385800A Received: by mail-qt1-x82f.google.com with SMTP id f1so281012qto.9 for ; Tue, 26 Oct 2021 12:36:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lf4auQjCy0rbZyNNsYHevmJCBScNJhQNNRvHPDZczK8=; b=TEx9xmH8Alret/Lm/i4xPi2i9ZQU5HlEsUTZ4Fe7hd/fkSmWgXEwA3Gfb+6I2Q2ArX LDVdt+/vTzeYkxuhn135W76j974P7lAYeWpecFFdspJWAje0Vdlu4Eo/sQZuxqTrWkdC GZ5bMlVqjT1Fnd8P6feO22xO7Rtz3pH4JXN/0Vc6C8gKqUt5XTrbPwp6ygqIPaZPnNKu PNbt2pg5a+w+Gway/jYlPt7iE2TZ2+jlf+YIZnRiZiKod16W3/orHzBabWcMEGR7eSMk R0atezlq7OS6Y+yd/kZMLLWF+U/NgpRHbdQ4dOxtDPFeYjFe/DyEOH2J0e+VuLKlaqja k9qw== X-Gm-Message-State: AOAM530qdWPVnVC3Yx2nF27Q6Zcp2Emn8+PAo9IHN3Qvh77F6DIMv+Jz znpXR0AwJu3YbsxEc6PQL139bIOrKWFRmzJN/j9pOrhigtU= X-Google-Smtp-Source: ABdhPJw5rsjYsqTpJwX6Xnjlaxq7DYxvedAtkbguGg7iZj5gbsO2Na05HqvAZlkSfDL2AzcgJuYnIHCu+aUuasnP8Cc= X-Received: by 2002:ac8:5706:: with SMTP id 6mr22120818qtw.95.1635277003191; Tue, 26 Oct 2021 12:36:43 -0700 (PDT) MIME-Version: 1.0 References: <20211008194654.627119-1-cbiesinger@google.com> In-Reply-To: <20211008194654.627119-1-cbiesinger@google.com> From: Christian Biesinger Date: Tue, 26 Oct 2021 15:35:59 -0400 Message-ID: Subject: Re: [PATCH] Unconditionally declare strsignal To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-23.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 19:36:45 -0000 Ping? On Fri, Oct 8, 2021 at 3:46 PM Christian Biesinger wrote: > > Currently, newlib does not declare strsignal if DEFS_H is defined, > ostensibly to work around a gdb bug. However, gdb itself compiles > even with this ifndef removed, and this makes sim (another part of > gdb) fail to compile. > > Since it is not clear exactly what issue this was working around, > this patch just removes that ifndef. > --- > newlib/libc/include/string.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/newlib/libc/include/string.h b/newlib/libc/include/string.h > index 60e837bc0..ec74b10d5 100644 > --- a/newlib/libc/include/string.h > +++ b/newlib/libc/include/string.h > @@ -130,9 +130,7 @@ char *strlwr (char *); > char *strupr (char *); > #endif > > -#ifndef DEFS_H /* Kludge to work around problem compiling in gdb */ > char *strsignal (int __signo); > -#endif > > #ifdef __CYGWIN__ > int strtosigno (const char *__name); > -- > 2.33.0.882.g93a45727a2-goog >