From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56182 invoked by alias); 22 Jul 2019 23:26:57 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 56171 invoked by uid 89); 22 Jul 2019 23:26:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*RU:209.85.128.65, HX-Spam-Relays-External:209.85.128.65 X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jul 2019 23:26:55 +0000 Received: by mail-wm1-f65.google.com with SMTP id f17so36803951wme.2 for ; Mon, 22 Jul 2019 16:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=WHMJEHo/Q17PC1hri+3YNE7RC7R4TYL4tpcM6AtKa+Q=; b=QhRQP5E4EXYcgYzaFzVrVb8l3HmFuIRi4j/YRh7YYIHySNO9tJj1qYU33zMeynD/2G SgoGW6mPn6KEDs67xfhdLxj2rDYZh898i4N9OPT78ith7i3ZROVrnU4aL4kdZ+aoOInf aDRKjdVfSn7GApX4EGENDjTQ12xbRLn+jlPR2zOz0+pMJtcWHKCztoRuwqbLehdss4Eh Moyjd9QcgDqB3s+cdqzVsz5xByhw7If1GQem/NR9gKOb7fX+CdG3n0kLqd/Sp1QXW+/x 0s0dKB3WK5kzSpYYbAHrCqZVz/z4GQPkb7dsGYibbHQB69xvVUYHO5JSM87McglMK/uR oQgA== MIME-Version: 1.0 References: <20190722090456.GC21169@calimero.vinschen.de> <20190722105059.GD21169@calimero.vinschen.de> In-Reply-To: <20190722105059.GD21169@calimero.vinschen.de> From: Kota Uchida Date: Mon, 22 Jul 2019 23:26:00 -0000 Message-ID: Subject: Re: Build error for wcwidth and gcvt To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019/txt/msg00324.txt.bz2 I got understand about wchar_t data sizes. I fixed my patch and sent it: https://sourceware.org/ml/newlib/2019/msg00322.html > The header should be kept untouched, of course. The header file (wchar.h) must be fixed in order to match types between the header and .c file. On Mon, Jul 22, 2019 at 7:51 PM Corinna Vinschen wrote: > > On Jul 22 11:46, Thomas Wolff wrote: > > On 22.07.2019 11:04, Corinna Vinschen wrote: > > > On Jul 20 17:50, Kota Uchida wrote: > > > > Hi All, > > > > > > > > This is my first mail to newlib community. > > > > I've send this mail because I found some build errors > > > > on newlib's master branch. > > > > > > > > Cygwin: unbreak the build with GCC 7 > > > > 6b7723a83032bd355d3c529d957fe209cb35b4d9 > > > > > > > > I encountered 2 errors about wcwidth and gcvt. > > > > I've pushed simple patches to forked repository: > > > > https://github.com/uchan-nos/newlib-cygwin/commits/fix-build > > The first patch is not correct: > > - wcwidth (const wint_t wc) > > + wcwidth (const wchar_t wc) > > > > Note the manual page. > > Even if you see the wchar_t definition for Linux/POSIX, note that wchar_t > > has 32 bits there. > > On cygwin, however, wchar_t was defined to have only 16 bits, corresponding > > to the Windows UTF-16 encoding. > > The wcwidth parameter type wint_t is needed to support width enquiries for > > non-BMP characters; > > changing it would seriously deprive the function of part of its > > capabilities. > > Thomas > > We might need a generic and a Cygwin-specific definition in the source, i.e. > > #ifdef __CYGWIN__ > use wint_t > #else > use wchar_t > #endif > > The header should be kept untouched, of course. > > > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat