From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52823 invoked by alias); 27 Aug 2019 14:59:10 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 52807 invoked by uid 89); 27 Aug 2019 14:59:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=27=e6, H*f:sk:U65HX4T, H*i:sk:U65HX4T, quinn?= X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2019 14:59:08 +0000 Received: by mail-wr1-f65.google.com with SMTP id c3so19135593wrd.7 for ; Tue, 27 Aug 2019 07:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yU+L+sRMRqv6bmLpMLxtkExP5l6DkMFghoXOsL6gos0=; b=JElDmF9lvIGTFicwdv6IMB7bdN+InG40BF4gp2IAA502Q0jGpf/sKcizEnd4va6N8V beRHK1svKs5KCWcmgmyEppHGZd5oX9vP/Yqf/fajr5jLrHHs+MF1ggpfG1VAoVxoNt8i B/yyHm3Le+D6aL4XITNfbZ2MwwdUDUXunk31gz5JoCx/S6NlIQocYzh16zVrfZNftvaS iSl8St7GSFd16fP9LJ7RptDT8SiA9vvezA8pEyiuSi70l8RU61RR6iVBeZYJKktGjQsF iPXvxCLR2/kxpjemH3/wRtz5NQhQsugMOjlgZeVUtGwDec0bRwcBjNN/XbvLlS8WzoU+ TAvA== MIME-Version: 1.0 References: In-Reply-To: From: Kota Uchida Date: Tue, 27 Aug 2019 14:59:00 -0000 Message-ID: Subject: Re: Bug with gcvtf To: Rian Quinn , joel@rtems.org Cc: Newlib Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019/txt/msg00513.txt.bz2 I've already sent a patch on Tue, 23 Jul 2019. https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;a=3Dcommitdiff;= h=3D9cde02051ea528e5f1af1aa2dea50224eec57860 2019=E5=B9=B48=E6=9C=8827=E6=97=A5(=E7=81=AB) 21:39 Joel Sherrill : > > On Tue, Aug 27, 2019 at 7:27 AM Rian Quinn wrote: > > > > I was using the latest Newlib 3.1 and Libc++ 9.0. I have not checked th= e master branches, but if that is what you are looking for, I would be more= than happy to check that out as well. Just let me know. I will say that in= the past I have had to make a lot of mods and that does not seem to be the= case anymore, with either project. Other than this one fix, everything see= ms to work out of the box. > > Sorry. This file didn't originate in NetBSD or FreeBSD like many files > in newlib did. > The implementation is newlib specific so just submit a patch. > > --joel > > > Rian > > > > On Mon, Aug 26, 2019 at 1:32 PM Joel Sherrill wrote: > >> > >> > >> > >> On Mon, Aug 26, 2019, 7:16 AM Rian Quinn wrote: > >>> > >>> The "gcvtf" function in newlib/newlib/libc/stdlib/efgcvt.c is in the = file > >>> before gcvt, but relies on it with an implicit definition. When attem= pting > >>> to compile Newlib on x86_64 for Libc++ support, I get a compile error= as > >>> the definitions of the implicit version does not match the actual ver= sion. > >>> To fix the issue, all I had to do was to place the gcvtf version _aft= er_ > >>> the implementation of gcvt and it compiles fine. > >> > >> > >> Can you find the upstream source of this file and see if it has this c= hange and possibly others? > >> > >> I don't doubt the change is needed but this sounds like a hint to see = if we are.in sync with the upstream. > >> > >> Thanks. > >> > >> --joel > >>> > >>> > >>> Rian